Skip to content

🎨 Palette: Improve HTML report table accessibility and number alignment - #187

Closed
seonghobae wants to merge 4 commits into
mainfrom
ux-table-accessibility-4216998538196319922
Closed

🎨 Palette: Improve HTML report table accessibility and number alignment#187
seonghobae wants to merge 4 commits into
mainfrom
ux-table-accessibility-4216998538196319922

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

💡 What: The UX enhancement added:

  • Replaced the first column <td> cells with <th scope="row"> for better semantic HTML.
  • Added the font-variant-numeric: tabular-nums; CSS rule for th and td to ensure number columns align perfectly for easier visual scanning.
  • Updated the CSS to apply the correct existing table styles (text-align: left, white-space: nowrap, border-bottom) to the new tbody th elements so the visual design isn't broken.

🎯 Why: The user problem it solves

  • Screen reader users need proper row headers to understand which row data they are reading when navigating complex data tables. The lack of <th> made reading the table tedious.
  • Numbers of different widths (e.g. 1 vs 10) were slightly offset visually in standard fonts. tabular-nums fixes this alignment for an easier reading experience.

♿ Accessibility: Any a11y improvements made

  • Added <th scope="row"> inside <tbody> for proper semantic association in screen readers.

PR created automatically by Jules for task 4216998538196319922 started by @seonghobae

- Changed the first column in report tables from `<td>` to `<th scope="row">` to improve screen reader navigation.
- Added `font-variant-numeric: tabular-nums;` to table cells to align numerical data properly.
- Updated corresponding CSS selectors to apply standard table cell styles to the new `tbody th` elements, preventing visual regressions.
- Explicitly set `font-weight: normal` on `tbody th` to match previous visual style.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head e9109a0b077b43030aec267ea1973b298726aa39.

  • Head SHA: e9109a0b077b43030aec267ea1973b298726aa39

  • Workflow run: 29683984677

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
Loading

@opencode-agent

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: e9109a0b077b43030aec267ea1973b298726aa39
  • Workflow run: 29683984677
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head e9109a0b077b43030aec267ea1973b298726aa39.

  • Head SHA: e9109a0b077b43030aec267ea1973b298726aa39

  • Workflow run: 29683984677

  • Workflow attempt: 1

Coverage evidence

Coverage Decision

  • Result: FAIL
  • Test evidence: not proven passing
  • Docstring evidence: not proven passing when configured
  • Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (2 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (2 files)"]
  R1 --> V1["required checks"]
Loading

…head for re-review

The previous CHANGES_REQUESTED verdict on this head was an infrastructure
failure (the central coverage-evidence sandbox could not install numpy —
fixed by ContextualWisdomLab/.github#611), not a code judgment. This commit
documents the change and produces a fresh head so the scheduler dispatches
a new review under the repaired pipeline.
Copilot AI review requested due to automatic review settings July 22, 2026 05:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Improves the generated HTML report table’s accessibility and scanability by adding semantic row headers and aligning numeric columns with tabular figures.

Changes:

  • Rendered the first column in each <tbody> row as <th scope="row"> for better screen reader navigation.
  • Added font-variant-numeric: tabular-nums; to table cell styles for consistent numeric alignment.
  • Updated CSS selectors to ensure tbody th inherits the intended table cell styling and doesn’t look like a header row.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
python/fast_mlsirm/report.py Updates table HTML generation and refines CSS selectors for row-header <th> cells and numeric alignment.
CHANGELOG.md Documents the accessibility and table styling improvements in the generated report.
.jules/palette.md Adds a note capturing the lesson/action about updating CSS when changing semantic HTML tags.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread python/fast_mlsirm/report.py
Comment thread python/fast_mlsirm/report.py
…onflict

The changelog entry added for re-review now conflicts with the heavily
extended CHANGELOG on main. Reverting this branch's CHANGELOG to the
merge-base version makes the file untouched by this PR, so the base
branch's version merges cleanly; the PR keeps its report.py change.
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d5e82206-48ad-464f-9adc-b60743adfeb1

📥 Commits

Reviewing files that changed from the base of the PR and between a3123a2 and f18395a.

📒 Files selected for processing (2)
  • .jules/palette.md
  • python/fast_mlsirm/report.py

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded: Palette accessibility/empty-state/tabular-nums/skip-link themes already landed on main (e.g. #283 empty-state ARIA) or this branch is CONFLICTING with no clean rebase path. Closing as superseded.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Closing as superseded: Palette theme already on main or blocked by unresolvable conflicts with current main. Prefer re-open from a fresh branch if still needed.

@seonghobae seonghobae closed this Jul 31, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded: Palette accessibility/empty-state/tabular-nums/skip-link themes already landed on main (e.g. #283 empty-state ARIA) or this branch is CONFLICTING with no clean rebase path. Closing as superseded.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

@google-labs-jules

Copy link
Copy Markdown

Closing as superseded: Palette theme already on main or blocked by unresolvable conflicts with current main. Prefer re-open from a fresh branch if still needed.

Understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants