🎨 Palette: Improve HTML report table accessibility and number alignment - #187
🎨 Palette: Improve HTML report table accessibility and number alignment#187seonghobae wants to merge 4 commits into
Conversation
- Changed the first column in report tables from `<td>` to `<th scope="row">` to improve screen reader navigation. - Added `font-variant-numeric: tabular-nums;` to table cells to align numerical data properly. - Updated corresponding CSS selectors to apply standard table cell styles to the new `tbody th` elements, preventing visual regressions. - Explicitly set `font-weight: normal` on `tbody th` to match previous visual style.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current heade9109a0b077b43030aec267ea1973b298726aa39. -
Head SHA:
e9109a0b077b43030aec267ea1973b298726aa39 -
Workflow run: 29683984677
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (2 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (2 files)"]
R1 --> V1["required checks"]
|
…head for re-review The previous CHANGES_REQUESTED verdict on this head was an infrastructure failure (the central coverage-evidence sandbox could not install numpy — fixed by ContextualWisdomLab/.github#611), not a code judgment. This commit documents the change and produces a fresh head so the scheduler dispatches a new review under the repaired pipeline.
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Improves the generated HTML report table’s accessibility and scanability by adding semantic row headers and aligning numeric columns with tabular figures.
Changes:
- Rendered the first column in each
<tbody>row as<th scope="row">for better screen reader navigation. - Added
font-variant-numeric: tabular-nums;to table cell styles for consistent numeric alignment. - Updated CSS selectors to ensure
tbody thinherits the intended table cell styling and doesn’t look like a header row.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| python/fast_mlsirm/report.py | Updates table HTML generation and refines CSS selectors for row-header <th> cells and numeric alignment. |
| CHANGELOG.md | Documents the accessibility and table styling improvements in the generated report. |
| .jules/palette.md | Adds a note capturing the lesson/action about updating CSS when changing semantic HTML tags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…onflict The changelog entry added for re-review now conflicts with the heavily extended CHANGELOG on main. Reverting this branch's CHANGELOG to the merge-base version makes the file untouched by this PR, so the base branch's version merges cleanly; the PR keeps its report.py change.
|
Warning Review limit reached
Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
|
Superseded: Palette accessibility/empty-state/tabular-nums/skip-link themes already landed on main (e.g. #283 empty-state ARIA) or this branch is CONFLICTING with no clean rebase path. Closing as superseded. |
|
Closing as superseded: Palette theme already on main or blocked by unresolvable conflicts with current main. Prefer re-open from a fresh branch if still needed. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
Understood. |
💡 What: The UX enhancement added:
<td>cells with<th scope="row">for better semantic HTML.font-variant-numeric: tabular-nums;CSS rule forthandtdto ensure number columns align perfectly for easier visual scanning.text-align: left,white-space: nowrap,border-bottom) to the newtbody thelements so the visual design isn't broken.🎯 Why: The user problem it solves
<th>made reading the table tedious.1vs10) were slightly offset visually in standard fonts.tabular-numsfixes this alignment for an easier reading experience.♿ Accessibility: Any a11y improvements made
<th scope="row">inside<tbody>for proper semantic association in screen readers.PR created automatically by Jules for task 4216998538196319922 started by @seonghobae