Skip to content

🎨 Palette: Improve HTML report table accessibility with row headers - #333

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette/report-table-row-headers-7142361684149478452
Closed

🎨 Palette: Improve HTML report table accessibility with row headers#333
seonghobae wants to merge 1 commit into
mainfrom
palette/report-table-row-headers-7142361684149478452

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

This PR introduces a micro-UX and accessibility enhancement to the standalone HTML reports generated by fast-mlsirm.

💡 What

  • Modifies the table generation logic in report.py to output <th scope="row"> for the first cell in each row, rather than a generic <td>.
  • Updates CSS selectors so that base padding, borders, and text alignment apply to both column headers (thead th), row headers (tbody th), and data cells (td).
  • Forces font-weight: normal on tbody th to maintain the existing clean visual hierarchy without unwanted bold text on row headers.
  • Adds font-variant-numeric: tabular-nums; to the base table cell CSS to ensure that numerical digits align perfectly vertically when reading down a column.

🎯 Why

  • Accessibility: Screen readers use <th> elements to announce context as users navigate across data cells. Without row-scoped headers, users reading across a wide table may lose track of which person, item, or candidate they are evaluating.
  • Usability: Adding tabular-nums ensures that numbers with varying glyph widths (like '1' vs '8') take up the exact same horizontal space, making large columns of diagnostics metrics much easier to scan visually.

♿ Accessibility

  • scope="row" explicitly binds the first cell to the rest of the cells in that <tr>.
  • Does not alter visual appearance for sighted users, preventing regressions while vastly improving the experience for assistive technologies.

PR created automatically by Jules for task 7142361684149478452 started by @seonghobae

Updates the standalone HTML report generator to use `<th scope="row">`
for the first column in data tables instead of standard `<td>` cells.
This improves screen reader accessibility by creating a clear semantic
relationship between the identifying row header and its corresponding
data cells.

Also updates base CSS selectors (`thead th, tbody th, td`) to ensure
visual parity is maintained and adds `font-variant-numeric: tabular-nums`
so that numbers perfectly align vertically across rows.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 58 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b676909-312a-402d-a62a-0ca7b2de0567

📥 Commits

Reviewing files that changed from the base of the PR and between a3123a2 and 096e3ee.

📒 Files selected for processing (2)
  • .jules/palette.md
  • python/fast_mlsirm/report.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch palette/report-table-row-headers-7142361684149478452

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

중복 정리: report.py 테이블 행 헤더 접근성 개선으로, 리뷰 대기 중인 #187 과 동일 대상·동일 취지입니다. 그룹당 대표 1건만 남기는 백로그 정리 방침에 따라 닫습니다. 필요 시 재오픈 가능합니다.


Generated by Claude Code

@google-labs-jules

Copy link
Copy Markdown

중복 정리: report.py 테이블 행 헤더 접근성 개선으로, 리뷰 대기 중인 #187 과 동일 대상·동일 취지입니다. 그룹당 대표 1건만 남기는 백로그 정리 방침에 따라 닫습니다. 필요 시 재오픈 가능합니다.


Generated by Claude Code

알겠습니다. 기존 PR(#187)과 중복되는 작업으로 인해 해당 작업이 취소 및 닫혔음을 확인하였습니다. 이에 따라 본 이슈에 대한 작업을 중단하겠습니다.

@seonghobae seonghobae closed this Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant