Skip to content

๐ŸŽจ Palette: HTML ๋ฆฌํฌํŠธ ๊ฐ€๋…์„ฑ ํ–ฅ์ƒ์„ ์œ„ํ•œ ๋“ฑํญ ์ˆซ์ž(tabular-nums) ์ ์šฉ - #253

Closed
seonghobae wants to merge 2 commits into
mainfrom
feat/ux-tabular-nums-4653761318850556588
Closed

๐ŸŽจ Palette: HTML ๋ฆฌํฌํŠธ ๊ฐ€๋…์„ฑ ํ–ฅ์ƒ์„ ์œ„ํ•œ ๋“ฑํญ ์ˆซ์ž(tabular-nums) ์ ์šฉ#253
seonghobae wants to merge 2 commits into
mainfrom
feat/ux-tabular-nums-4653761318850556588

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What: ์ •์  HTML ๋ฆฌํฌํŠธ ์ƒ์„ฑ์— ์‚ฌ์šฉ๋˜๋Š” ์ „์—ญ body CSS ๊ทœ์น™์— font-variant-numeric: tabular-nums; ๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ๋ฆฌํฌํŠธ์—๋Š” ์„ฑ๋Šฅ ์ˆ˜์น˜๋‚˜ ์ ์ˆ˜ ๋“ฑ์˜ ์ˆซ์ž๊ฐ€ ์„ธ๋กœ๋กœ ๋‚˜์—ด๋˜๋Š” ๊ฒฝ์šฐ๊ฐ€ ๋งŽ์€๋ฐ, ๊ธฐ๋ณธ์ ์œผ๋กœ ์ˆซ์ž๋“ค์ด ๊ฐ€๋ณ€ ํญ์„ ๊ฐ€์ง€๊ธฐ ๋•Œ๋ฌธ์— ์„ธ๋กœ๋กœ ์ •๋ ฌ ์‹œ ์‚๋šค๋นผ๋šคํ•˜๊ฒŒ ๋ณด์ž…๋‹ˆ๋‹ค. ๋“ฑํญ(tabular) ์ˆซ์ž๋ฅผ ์ ์šฉํ•˜๋ฉด ์ˆซ์ž๋“ค์ด ์™„๋ฒฝํ•˜๊ฒŒ ์ค„์„ ๋งž์ถฐ ๋ Œ๋”๋ง๋˜์–ด ๊ฐ€๋…์„ฑ์ด ํ›จ์”ฌ ํ–ฅ์ƒ๋ฉ๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ์‹œ๊ฐ์  ํ™•์ธ(screenshot)์„ ํ†ตํ•ด ์ง„๋‹จ ๊ฒฐ๊ณผ ์ ์ˆ˜(์˜ˆ: 0.95, 0.8)๋“ค์ด ๊น”๋”ํ•˜๊ฒŒ ์ •๋ ฌ๋˜๋Š” ๊ฒƒ์„ ๊ฒ€์ฆ ์™„๋ฃŒํ•˜์˜€์Šต๋‹ˆ๋‹ค.
โ™ฟ Accessibility: ๋ฐ์ดํ„ฐ์™€ ์ˆซ์ž๋ฅผ ๋งŽ์ด ํฌํ•จํ•œ ๋ณด๊ณ ์„œ๋ฅผ ๋” ์‰ฝ๊ฒŒ ์Šค์บ”ํ•˜๊ณ  ์ฝ์„ ์ˆ˜ ์žˆ๋„๋ก ์‹œ๊ฐ์  ์•ˆ์ •์„ฑ์„ ์ œ๊ณตํ•˜์—ฌ ์ธ์ง€ ์ ‘๊ทผ์„ฑ ์ธก๋ฉด์— ๋„์›€์„ ์ค๋‹ˆ๋‹ค.


PR created automatically by Jules for task 4653761318850556588 started by @seonghobae

* `python/fast_mlsirm/report.py` ๋‚ด๋ถ€ `_css()` ํ•จ์ˆ˜ ๋ณธ๋ฌธ ์Šคํƒ€์ผ ๊ทœ์น™์— `font-variant-numeric: tabular-nums;`๋ฅผ ์ถ”๊ฐ€ํ•˜์—ฌ ๋ณด๊ณ ์„œ์—์„œ ์„ธ๋กœ๋กœ ์ •๋ ฌ๋œ ์ˆซ์ž๊ฐ€ ๋” ์ž˜ ์ฝํžˆ๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 25, 2026 07:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โœ… Ready to approve

๋ณ€๊ฒฝ์ด CSS ๋‹จ์ผ ์†์„ฑ ์ถ”๊ฐ€๋กœ ์ œํ•œ๋˜์–ด ์žˆ๊ณ  ๊ธฐ์กด ์ ‘๊ทผ์„ฑ/ํ”„๋ฆฐํŠธ ๊ทœ์น™๊ณผ๋„ ์ถฉ๋Œํ•˜์ง€ ์•Š์•„ ๋ฆฌ์Šคํฌ๊ฐ€ ๋งค์šฐ ๋‚ฎ์Šต๋‹ˆ๋‹ค.

Note: this review does not count toward required approvals for merging.

Pull request overview

์ •์  HTML ๋ฆฌํฌํŠธ์˜ ์ „์—ญ body ์Šคํƒ€์ผ์— tabular numbers(๋“ฑํญ ์ˆซ์ž)๋ฅผ ์ ์šฉํ•ด, ์ ์ˆ˜/์ง€ํ‘œ์ฒ˜๋Ÿผ ์„ธ๋กœ๋กœ ๋‚˜์—ด๋˜๋Š” ์ˆซ์ž ์ปฌ๋Ÿผ์˜ ์‹œ๊ฐ์  ์ •๋ ฌ๊ณผ ๊ฐ€๋…์„ฑ์„ ๊ฐœ์„ ํ•˜๋Š” PR์ž…๋‹ˆ๋‹ค. ๋ฆฌํฌํŠธ ๋ Œ๋”๋ง ๋กœ์ง์€ ๊ฑด๋“œ๋ฆฌ์ง€ ์•Š๊ณ  CSS ๋ ˆ๋ฒจ์—์„œ ์ผ๊ด€๋œ ์ˆซ์ž ํญ์„ ๋ณด์žฅํ•˜๋Š” ํ˜•ํƒœ๋กœ ์ฝ”๋“œ๋ฒ ์ด์Šค ๋ชฉ์ (์ง„๋‹จ/๋ฆฌํฌํŠธ ๊ฐ€๋…์„ฑ)๊ณผ ์ž˜ ๋งž์Šต๋‹ˆ๋‹ค.

Changes:

  • HTML ๋ฆฌํฌํŠธ ์ „์—ญ body CSS์— font-variant-numeric: tabular-nums; ์ถ”๊ฐ€
  • ํŒ”๋ ˆํŠธ ํ•™์Šต ๋ฌธ์„œ์— โ€œ๋ฐ์ดํ„ฐ ๋ฆฌํฌํŠธ์—์„œ๋Š” tabular-nums๋ฅผ ๊ธฐ๋ณธ์œผ๋กœ ํฌํ•จโ€ ๊ฐ€์ด๋“œ ์ถ”๊ฐ€
File summaries
File Description
python/fast_mlsirm/report.py ๋ฆฌํฌํŠธ ์ „์—ญ body ์Šคํƒ€์ผ์— tabular-nums๋ฅผ ์ถ”๊ฐ€ํ•ด ์ˆซ์ž ์ •๋ ฌ ๊ฐ€๋…์„ฑ ๊ฐœ์„ 
.Jules/palette.md ํ–ฅํ›„ ๋ฆฌํฌํŠธ/์ปดํฌ๋„ŒํŠธ CSS ๋ณ€๊ฒฝ ์‹œ ๋™์ผ ๊ทœ์น™์„ ์œ ์ง€ํ•˜๋„๋ก ๊ฐ€์ด๋“œ๋ผ์ธ ๊ธฐ๋ก

Review details

  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Low

Note

Your feedback helps us improve the quality of this feature.
Please use ๐Ÿ‘ or ๐Ÿ‘Ž to tell us whether this assessment is correct.


๐Ÿ’ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings July 26, 2026 01:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โš ๏ธ Not ready to approve

.Jules/palette.md currently contains a literal \n escape sequence and now mixes formatting styles, so it should be normalized to proper Markdown newlines for consistent rendering.

Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 1
  • Review effort level: Low

Note

Your feedback helps us improve the quality of this feature.
Please use ๐Ÿ‘ or ๐Ÿ‘Ž to tell us whether this assessment is correct.

Comment thread .Jules/palette.md
Comment on lines +11 to +13
## 2026-07-25 - Tabular Numbers for Data Reports
**Learning:** Proportional numbers in vertical columns or data-heavy reports can look jagged and are harder to read and compare. Using tabular numbers ensures all digits have the same width.
**Action:** Always include `font-variant-numeric: tabular-nums;` in body styles or data-heavy components within HTML reports to ensure numbers align properly vertically for improved readability and scanning.
@seonghobae
seonghobae enabled auto-merge (squash) July 26, 2026 09:02
@opencode-agent
opencode-agent Bot disabled auto-merge July 26, 2026 09:44

Copy link
Copy Markdown
Contributor Author

์ค‘๋ณต ์ •๋ฆฌ: report.py body์˜ tabular-nums ์ ์šฉ์œผ๋กœ, ๋ฆฌ๋ทฐ ๋Œ€๊ธฐ ์ค‘์ธ #187/#199 ์— ํฌ๊ด„๋ฉ๋‹ˆ๋‹ค. ๊ทธ๋ฃน๋‹น ๋Œ€ํ‘œ 1๊ฑด๋งŒ ๋‚จ๊ธฐ๋Š” ๋ฐฑ๋กœ๊ทธ ์ •๋ฆฌ ๋ฐฉ์นจ์— ๋”ฐ๋ผ ๋‹ซ์Šต๋‹ˆ๋‹ค. ํ•„์š” ์‹œ ์žฌ์˜คํ”ˆ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.


Generated by Claude Code

@google-labs-jules

Copy link
Copy Markdown

์ค‘๋ณต ์ •๋ฆฌ: report.py body์˜ tabular-nums ์ ์šฉ์œผ๋กœ, ๋ฆฌ๋ทฐ ๋Œ€๊ธฐ ์ค‘์ธ #187/#199 ์— ํฌ๊ด„๋ฉ๋‹ˆ๋‹ค. ๊ทธ๋ฃน๋‹น ๋Œ€ํ‘œ 1๊ฑด๋งŒ ๋‚จ๊ธฐ๋Š” ๋ฐฑ๋กœ๊ทธ ์ •๋ฆฌ ๋ฐฉ์นจ์— ๋”ฐ๋ผ ๋‹ซ์Šต๋‹ˆ๋‹ค. ํ•„์š” ์‹œ ์žฌ์˜คํ”ˆ ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค.


Generated by Claude Code

๋„ค, ์ค‘๋ณต ์ œ๊ฑฐ ๋ฐ ๋ฐฑ๋กœ๊ทธ ์ •๋ฆฌ ๋ฐฉ์นจ์— ๋”ฐ๋ผ ๋‹ซ์•„์ฃผ์‹  ์  ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. ์ง„ํ–‰ ์ค‘์ด๋˜ ์ž‘์—…์€ ์ค‘๋‹จํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants