๐จ Palette: ๋ฐ์ดํฐ ํ ์ด๋ธ ์ ๊ทผ์ฑ ํฅ์ ๋ฐ ์ซ์ ์ ๋ ฌ(tabular-nums) ์ ์ฉ - #249
Conversation
- Changed the first column in data tables to use `<th scope="row">` to provide structural context for screen readers. - Updated CSS base selectors to support `tbody th` and explicitly prevent visual regressions on the new row headers. - Applied `font-variant-numeric: tabular-nums` to all data cells for better number alignment.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the generated HTML diagnostics report tables by adding proper row headers for assistive technologies and refining table typography so numeric columns align more cleanly.
Changes:
- Render the first cell of each table body row as a row header (
<th scope="row">) instead of a<td>to improve screen reader row context. - Refine table CSS selectors to separately style
thead thvstbody th, and applyfont-variant-numeric: tabular-numsfor consistent numeric alignment. - Record the accessibility/UX takeaway in
.jules/palette.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| python/fast_mlsirm/report.py | Updates HTML table row rendering to use row headers and refines table CSS (header/body selectors + tabular-nums). |
| .jules/palette.md | Adds a journal entry documenting the accessibility + typography rationale for the table changes. |
๐ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tr:last-child td, | ||
| tr:last-child th { | ||
| border-bottom: 0; | ||
| } |
| cells = "".join( | ||
| f"<td>{escape(_format_value(row.get(column, '')))}</td>" | ||
| for column in columns | ||
| f'<th scope="row">{escape(_format_value(row.get(column, "")))}</th>' | ||
| if i == 0 | ||
| else f'<td>{escape(_format_value(row.get(column, "")))}</td>' | ||
| for i, column in enumerate(columns) | ||
| ) |
|
์ค๋ณต ์ ๋ฆฌ: Generated by Claude Code |
์๊ฒ ์ต๋๋ค. ๋ฐฑ๋ก๊ทธ ์ ๋ฆฌ ๋ฐฉ์นจ์ ๋ฐ๋ผ ์ค๋ณต์ผ๋ก ์ฒ๋ฆฌ๋์ด ๋ซํ ๊ฒ์ ํ์ธํ์ผ๋ฉฐ ์์ ์ ์ค๋จํฉ๋๋ค. |
๐ก ํด๊ฒฐ ๋ด์ฉ (What)
๋ฐ์ดํฐ ํ ์ด๋ธ์ ์ฒซ ๋ฒ์งธ ์ด์ ๋ ๋๋งํ ๋
<td>๋์<th scope="row">๋ฅผ ์ฌ์ฉํ๋๋ก ์์ ํ์ฌ, ์คํฌ๋ฆฐ ๋ฆฌ๋ ๋ฑ ๋ณด์กฐ ๊ธฐ๊ธฐ๊ฐ ํ์ ๊ฐ ํ์ ๋ํ ์ ๋ชฉ(Context)์ ์ ํํ๊ฒ ์ธ์ํ ์ ์๋๋ก ์ ๊ทผ์ฑ์ ๊ฐ์ ํ์ต๋๋ค.๐ฏ ๋ฌธ์ ์์ธ ๋ฐ ๊ธฐ๋ ํจ๊ณผ (Why)
td,tbody th)์font-variant-numeric: tabular-nums๋ฅผ ์ ์ฉํ์ฌ ๊ณ ์ ํญ ์ซ์ ํ๊ธฐ๊ฐ ๋๋๋ก ๊ฐ์ ํ์ต๋๋ค. ์ด๋ฅผ ํตํด ์ซ์ ๋ฐ์ดํฐ๊ฐ ์ธ๋ก๋ก ๊น๋ํ๊ฒ ์ ๋ ฌ๋ฉ๋๋ค.<th>ํ๊ทธ ๋์ ์ผ๋ก ์ธํด ๊ธ์จ๊ฐ ๊ตต์ด์ง๊ฑฐ๋ ๊ธฐ์กด ๋์์ธ์ด ๊นจ์ง์ง ์๋๋ก, CSS ์ ํ์๋ฅผthead th,tbody th๋ก ์ธ๋ถํํ๊ณ ์ ์ ํ ์คํ์ผ(์:font-weight: normal)์ ์ถ๊ฐํ์ต๋๋ค.๐ธ ์ฃผ์ ๋ณ๊ฒฝ ์ฌํญ
python/fast_mlsirm/report.py์_tableํจ์ ๋ด ํ ๋ ๋๋ง ๋ก์ง ์์ .jules/palette.md์ ๋์ ๊ธฐ๋กPR created automatically by Jules for task 15485063106557305020 started by @seonghobae