Skip to content

fix(ci): skip docs-only changes for Tests workflow - #923

Merged
seonghobae merged 1 commit into
mainfrom
chore/paths-ignore-fix
Sep 3, 2026
Merged

fix(ci): skip docs-only changes for Tests workflow#923
seonghobae merged 1 commit into
mainfrom
chore/paths-ignore-fix

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

An org-wide audit of ContextualWisdomLab CI configuration found that .github/workflows/tests.yml had no paths-ignore filter on either its push or pull_request triggers, so every push and PR — including docs-only changes — runs the full pytest + PostgreSQL service job and the frontend lint/test/build/Storybook job.

Across the org this is a meaningful contributor to the Actions queue backlog (the org is on a 60-concurrent-job plan ceiling), so trimming needless triggers on repos where it's safe reduces contention for every repo sharing that ceiling.

This PR adds:

paths-ignore:
  - "docs/**"
  - "*.md"

to both the push and pull_request blocks of tests.yml, matching the paths/paths-ignore style already used elsewhere in this repo's workflows (ontology-pages.yml, prov-o-contract.yml).

Safety verification performed

  • main has no classic branch protection (GET .../branches/main/protection returns 404).
  • The org-required-workflows ruleset (CWL Central required workflows, id 18156473) does not include tests.yml in its workflows rule at all, so this file is not part of any required-check enforcement — editing its triggers cannot starve a required check.
  • The only other active ruleset (LineageWeave: no force pushes) only enforces non_fast_forward, unrelated to CI triggers.
  • Confirmed tests.yml had no existing paths/paths-ignore filter before this change.

Test plan

  • Validated YAML with python3 -c "import yaml; yaml.safe_load(open('.github/workflows/tests.yml'))"
  • Diff is additive only (6 lines added, 0 removed) — all existing keys (branches, types) preserved exactly

🤖 Generated with Claude Code


Devin Review

Summary by CodeRabbit

  • CI 개선
    • 문서 파일만 변경된 경우 테스트 워크플로가 실행되지 않도록 조정했습니다.
    • 코드 변경이 없는 문서 업데이트의 검증 절차가 간소화됩니다.

Org-wide audit found tests.yml lacked paths-ignore, triggering full CI on every push/PR including docs-only changes and contributing to org-wide Actions queue congestion.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@seonghobae
seonghobae merged commit 0f1d447 into main Sep 3, 2026
14 of 21 checks passed
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 6ebd7631-95c6-4eb8-820a-779766d49e16

📥 Commits

Reviewing files that changed from the base of the PR and between 3f61c82 and 15ff6ec.

📒 Files selected for processing (1)
  • .github/workflows/tests.yml

📝 Walkthrough

Walkthrough

Tests 워크플로의 push 및 pull_request 트리거가 docs/***.md 변경을 무시하도록 수정되었습니다.

Changes

CI 경로 필터링

Layer / File(s) Summary
Tests 워크플로 경로 필터링
.github/workflows/tests.yml
push 및 pull_request 트리거에 docs/***.md에 대한 paths-ignore 조건을 추가했습니다.

Estimated code review effort: 1 (매우 간단) | ~2 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/paths-ignore-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 3 potential issues.

Devin Review

Comment on lines +6 to +13
paths-ignore:
- "docs/**"
- "*.md"
pull_request:
types: [opened, synchronize, reopened, closed]
paths-ignore:
- "docs/**"
- "*.md"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Documentation contracts lose test coverage

Changes to contract schemas, ADRs, and release notes now skip pytest, which validates those files. Broken contracts and repository-policy violations can merge undetected.

Suggested change
paths-ignore:
- "docs/**"
- "*.md"
pull_request:
types: [opened, synchronize, reopened, closed]
paths-ignore:
- "docs/**"
- "*.md"
pull_request:
types: [opened, synchronize, reopened, closed]
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Comment on lines +11 to +13
paths-ignore:
- "docs/**"
- "*.md"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Close filtering preserves cleanup behavior

A documentation-only pull request has no Tests run to cancel when it closes. Filtering its closed event therefore leaves the concurrency cleanup behavior intact.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

push:
branches: [main]
paths-ignore:
- "docs/**"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Info: Ontology changes retain dedicated validation

Changes under docs/ontology/** still trigger Ontology Pages. Its pull-request job validates the ontology and publication contracts independently of the full suite.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt protected main #923's docs-only Tests workflow change without rewriting the Customer Master product delta.
seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt protected main #923's docs-only Tests workflow delta while preserving Affiliate Tree hierarchy evidence unchanged.
seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt protected main #923's docs-only Tests workflow delta without changing Event Lineage presentation semantics.
seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt protected main #923's docs-only Tests workflow delta without restoring the retired direct CalDAV boundary.
seonghobae added a commit that referenced this pull request Sep 3, 2026
…d main

Adopt protected main #923's docs-only Tests workflow delta without changing the pg8000/asyncpg ownership boundary.
seonghobae added a commit that referenced this pull request Sep 3, 2026
Preserve the branch's explicit ubuntu-24.04 runner declarations while adopting protected main #923's docs-only Tests trigger filters.
seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt protected main #923's docs-only Tests workflow delta while preserving the occupational PRD/ADR identity repair unchanged.
seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt protected main #923's docs-only Tests workflow delta while preserving the shared StatusNotice dashboard migration.
seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt protected main #923's docs-only Tests workflow delta without changing the tests-only coverage slice.
seonghobae added a commit that referenced this pull request Sep 3, 2026
Adopt protected main #923's docs-only Tests workflow delta without changing the tests-only coverage slice.
seonghobae added a commit that referenced this pull request Sep 3, 2026
…main

Adopt protected main #923's docs-only Tests workflow delta while preserving the governance-motivated #782 revert unchanged.
seonghobae added a commit that referenced this pull request Sep 3, 2026
… main

Adopt protected main #923's docs-only Tests workflow delta without rewriting the reviewed leftover-map product tree.
seonghobae added a commit that referenced this pull request Sep 3, 2026
…ts read doc content as contracts (#924)

Reverts #923's paths-ignore for this repo: pytest treats several docs/**/*.md and root CHANGELOG.md files as content-checked behavioral contracts, so a docs-only PR was silently skipping the full test run. Verified: 1703 passed, 209 skipped, 0 failed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant