[QUEUE_SATURATION_CHICKEN_EGG] fix(ci): revert docs paths-ignore, tests read doc content as contracts - #924
Merged
Conversation
#923's paths-ignore on docs/**/*.md let a docs-only PR skip the full pytest run. LineageWeave's suite treats several doc files as behavioral contracts, not inert prose: - tests/test_documentation_hygiene.py dynamically globs every file under docs/adr/*.md and asserts non-placeholder content, and separately content-checks docs/product-technical-gap-baseline.md and a specific ADR file against a Dockerfile pin. - tests/test_ingestion_transaction_contracts.py asserts exact prose in root-level CHANGELOG.md (matched by the *.md ignore pattern). - tests/test_occupational_construct_ontology.py parses docs/ontology/lineageweave-kg-shapes.ttl as SHACL shapes and validates behavior derived from its content; this file lives under docs/** but outside the narrower ontology-pages.yml trigger's own test list, so no other workflow covers it. The ADR check's dynamic glob (195+ files, growing) makes a safe static allowlist unreliable, and the ontology-ttl hit means the exposure isn't confined to *.md as originally assumed. Reverting the paths-ignore addition is the safe default here per this org's own "contract tests pin workflows AND prose" convention; a docs-only PR now runs the full suite again, same as before #923. Verified: `uv run --frozen python -m pytest -q` — 1703 passed, 209 skipped, 0 failed, against a local Postgres 16 container matching CI. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough문서 및 Markdown 파일만 변경된 push와 pull request도 전체 테스트 워크플로를 실행하도록 GitHub Actions 이벤트 필터를 변경했습니다. Changes테스트 워크플로 트리거
Estimated code review effort: 1 (Trivial) | ~2 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving the contextual-orchestrator ownership boundary without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving Voice export authority delta without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving the activity-stream identity/read-model delta without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving the TEPP accepted-receipt product delta without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving the Customer Master hierarchy/read-model delta without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving deterministic Event Lineage presentation without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving Affiliate Tree hierarchy evidence without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering without restoring the retired direct CalDAV boundary or inventing CalendarWeave authority.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored documentation-contract test triggering while preserving this branch's explicit ubuntu-24.04 hosted-runner declarations and public-surface delta.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving the project-history empty-state UI/evidence delta without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving dashboard StatusNotice/retry behavior without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving the tests-only fixture coverage slice without force rewrite.
seonghobae
added a commit
that referenced
this pull request
Sep 3, 2026
Adopt #924's restored docs-contract test triggering while preserving the tests-only ask-time-axis coverage slice without force rewrite.
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Org-wide sweep #923 added
paths-ignore: ["docs/**", "*.md"]to this repo's.github/workflows/tests.ymltrigger, on the assumption that docs-only changes are inert prose. That assumption is false for LineageWeave: this repo's own pytest suite treats several doc files as behavioral contracts.Confirmed doc-content-reading assertions that the paths-ignore silently skipped:
tests/test_documentation_hygiene.pytest_adr_numbers_are_unique_and_documents_are_not_placeholders— dynamicallyglob("*.md")s every file indocs/adr/(195+ files) and asserts each is non-empty / free of placeholder markers.test_product_gap_baseline_contains_no_private_post_identifiers— readsdocs/product-technical-gap-baseline.mdcontent and regex-asserts no private post identifiers leaked in.test_orchestrator_runtime_pin_matches_adr— readsdocs/adr/0083-orchestrator-runtime-commit-pin.mdcontent and cross-checks a commit hash against a Dockerfile.tests/test_ingestion_transaction_contracts.pytest_release_notes_describe_balanced_outer_emphasis_strippingandtest_fetch_persisted_summary_returns_stored_person_catalog_id— read root-levelCHANGELOG.mdcontent and assert exact prose is present (matched by the*.mdignore pattern).tests/test_occupational_construct_ontology.pytest_construct_assertion_shape_requires_evidence_and_provenance— parsesdocs/ontology/lineageweave-kg-shapes.ttlas SHACL shapes and validates real data against it; behavior is derived directly from that file's content. This file is underdocs/**but the separateontology-pages.ymlworkflow'spathstrigger does not include this particular test file, so no other workflow covers it.Because the ADR check globs dynamically over a large and growing directory, and because the exposure turned out not to be confined to
*.md(the ontology.ttlhit), a safe static "ignore everything except these known files" allowlist would be fragile and easy to silently invalidate with a future doc addition. Per this org's own "contract tests pin workflows AND prose" convention, the safe default is to revert thepaths-ignoreaddition entirely for this repo — a docs-only PR now runs the full suite again, same as before #923.Change
Removes the two
paths-ignore: ["docs/**", "*.md"]blocks added in #923 from.github/workflows/tests.yml. No other change.Test plan
uv sync --frozen --extra dev --extra backenduv run --frozen python -m pytest -qagainst a local Postgres 16 container (matching the CI service config) — 1703 passed, 209 skipped, 0 failedtests/test_tests_workflow_contract.py(which pins other parts of this same workflow file's content) still passes unchangedpytest --collect-only— 1912 tests collected, no import errors🤖 Generated with Claude Code
Summary by CodeRabbit