fix(voice): distinguish carrying and evidence exports by seonghobae · Pull Request #780 · ContextualWisdomLab/LineageWeave

seonghobae · 2026-08-28T03:00:50Z

Summary

add explicit carrying-Post and derivation-evidence-Post columns to exact-value CSV while retaining the compatibility field;
repair the ADR 0251/0256 authority collision and lock the mapping with a regression test;
refresh the non-identifying exact-head gap overlay and audit the existing token-backed Storybook scene at desktop and mobile sizes;
synchronize the project version in uv.lock with pyproject.toml.

Verification boundary

Historical focused Voice/source-post, frontend, Storybook, and rendered desktop/mobile evidence is predecessor evidence after branch movement and is not current merge evidence. Authenticated PostgreSQL/API acceptance is not claimed by this export-only slice.

Protected-main convergence

Protected main advanced to 0f1d44726cc8fd9fd05a4f9b91ec40ff6be8802d through #923. Its sole delta from the prior protected head is .github/workflows/tests.yml; this PR does not modify that path. The branch adopted that current protected delta immediately and non-destructively through merge commit 68c4285a10b6717e25abddc8a69a62a0fd30aa95, whose parents are the prior Voice head df6aac995176f64b184aaa2f6e34a064af20cc64 and current protected main. No force push, destructive rebase, product-source overwrite, or predecessor evidence transfer was used.

The child documentation PR #901 was then converged onto this exact parent by its own non-force merge commit bbf24cce8b82f23a8954decb2b8b78de2e81cd6b; its base SHA now exactly matches this head.

Exact live state

protected base: main@0f1d44726cc8fd9fd05a4f9b91ec40ff6be8802d;
exact current head: 68c4285a10b6717e25abddc8a69a62a0fd30aa95;
GitHub: open / Ready / mechanically mergeable;
exact-head CodeQL 33710094043 ended startup_failure before usable analysis evidence;
exact-head Security 33710092978, Scorecard 33710093015, SAST 33710092971, Tests 33710092999, Ontology Pages 33710092991, and OSV 33710093313 are queued and therefore non-passing;
current-head qualifying independent approval is still required; predecessor reviews/checks do not transfer.

#901 still has one semantic baseline defect independent of ancestry: its ADR 0134 row must classify the already-protected shared StatusNotice contract from #643 as delivered rather than as an open placeholder. Keep that child Draft until the canonical large-file row can be changed through a conflict-safe write path and current-head governance evidence exists.

No self-approval, bypass, force push, scanner substitution, or gate weakening.

coderabbitai · 2026-08-28T03:02:10Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 83db76f0-e8e1-4c4a-8fe9-ae38c61526a9

📥 Commits

Reviewing files that changed from the base of the PR and between ddcc473 and cfe7a42.

📒 Files selected for processing (1)

docs/product-technical-gap-baseline.md

🚧 Files skipped from review as they are similar to previous changes (1)

docs/product-technical-gap-baseline.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

Voice 할당 CSV가 carrying_post_id와 derivation_evidence_post_id를 제공합니다. Voice 조합 문서는 ADR 0256을 참조합니다. 관련 테스트와 감사 기준선을 갱신합니다.

Changes

Voice 조합 정합성

Layer / File(s)	Summary
Voice 할당 CSV 식별 열 추가 `frontend/src/ontologyLayout.ts`, `frontend/src/ontologyLayout.test.ts`	`neighborhoodCsv`의 열 순서를 변경합니다. Voice 할당 행은 `evidence_post_id`, `carrying_post_id`, `derivation_evidence_post_id`를 구분하여 출력합니다. 테스트는 헤더, 행 값, 기본 Voice의 중복 증거 ID 방지를 검증합니다.
Voice 조합 ADR 참조 정렬 `docs/voice-combination-technical-requirements.md`, `docs/adr/0252-temporal-primary-voice-history.md`, `docs/adr/README.md`, `docs/storybook-inventory.md`, `tests/test_voice_authority_contract.py`	Voice 조합 문서와 Storybook 인벤토리가 ADR 0256을 참조합니다. 새 테스트가 ADR 0251 참조의 부재와 ADR 0256 참조를 검증합니다.
감사 기준선 갱신 `docs/product-technical-gap-baseline.md`	감사 기준선에 최신 `main` 헤드, 14개 open PR 상태와 16:46 KST queue-audit 결과를 기록합니다. PR `#782와` stacked child `#783의` 검증 상태도 기록합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to cfe7a

The change adds explicit carrying and derivation-evidence CSV fields while preserving compatibility and updating related authority documentation and metadata; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1…	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 `carrying` 및 `evidence` 내보내기를 구분하는 PR의 주요 변경 사항을 정확하고 간결하게 설명합니다.

Full details: Docstring Coverage

Explanation

Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/voice-export-authority-20260828

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector · 2026-08-28T04:05:55Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

…ority-20260828 # Conflicts: # docs/product-technical-gap-baseline.md # uv.lock

chatgpt-codex-connector · 2026-08-28T04:06:50Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

chatgpt-codex-connector · 2026-08-28T04:11:52Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.