feat(reports): preserve leftover-map plot-origin delta for post-#918 ADR/version reconstruction - #890
Conversation
… of leftover-map axis origin ticks, leftover-map axis share, and leftover-map singular values (v2.104.0)
|
Exact head |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
changed the title
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| **Decision status:** Proposed | ||
| **Date:** 2026-08-31 | ||
|
|
||
| **Numbering status:** provisional conflict. ADR 0347 is also claimed by the active leftover-map criterion-origin stack (#891). This proposal was retargeted behind the current #917 stack after that collision was detected and MUST receive a new non-conflicting ADR/version identity during conflict-preserving reconstruction before it can become Accepted or merge. |
There was a problem hiding this comment.
🔍 Unresolved ADR identity blocks merge
The feature still ships as ADR 0347 after Decision status becomes Proposed. Its declared numbering conflict must be resolved before merge.
Was this helpful? React with 👍 or 👎 to provide feedback.
seonghobae
added
priority: medium
status: blocked
type: feature
area: ui-ux
labels
ChatGPT Codex Connector
|
leftoverMapPlotOriginBadge reconstruction remains after ADR 0354 / v2.111.0. #918 stacked leftoverMapCompareListCriterionBadge origin onto #917 @ |
| [project] | ||
| name = "lineageweave" | ||
| version = "2.103.0" | ||
| version = "2.104.0" |
There was a problem hiding this comment.
🟡 Release identity collides with existing lineage
After the existing v2.104.0 lineage, version still declares 2.104.0 for a different feature. Publishing can reject or misidentify this release.
Prompt for agents
Assign this feature the next unique version and ADR identity after the current #917 stack. Update pyproject.toml, frontend/package.json, the changelog fragment and entries, ADR file and references, AGENTS.md, ARCHITECTURE.md, CLAUDE.md, tests, comments, and supporting baseline consistently. Reconstruct the feature delta on the actual current predecessor rather than retaining the sibling v2.104.0/ADR 0347 lineage.
Was this helpful? React with 👍 or 👎 to provide feedback.
| export function leftoverMapPlotOriginBadge(): LeftoverMapPlotOriginBadge | null { | ||
| const origin = formatLeftoverMapCoordinatePair(0, 0); | ||
| if (origin === null) { | ||
| return null; | ||
| } | ||
| return { key: LEFTOVER_MAP_PLOT_ORIGIN, values: { origin } }; | ||
| } |
There was a problem hiding this comment.
📝 Info: Origin does not fabricate measurements
leftoverMapPlotOriginBadge formats the chart’s fixed zero crossing. It does not derive coordinates from rank, shares, singular values, or plotted points.
Was this helpful? React with 👍 or 👎 to provide feedback.
| function leftoverMapPlotOriginText(variant: LeftoverMapPlotVariant): string | null { | ||
| if (variant === "comparison") { | ||
| return null; | ||
| } | ||
| const badge = leftoverMapPlotOriginBadge(); | ||
| if (badge === null) { | ||
| return null; | ||
| } | ||
| return tf(badge.key, badge.values); |
There was a problem hiding this comment.
📝 Info: Comparison rendering stays isolated
leftoverMapPlotOriginText returns null for comparison plots. Existing comparison axes, ticks, and point labels remain unchanged.
Was this helpful? React with 👍 or 👎 to provide feedback.
seonghobae
changed the title
|
Hourly loop 2026-09-03: unique leftoverMapPlotOriginBadge product delta reconstructed as ADR 0355 / v2.112.0 on stacked #920 ( This draft stays a preservation note. Do not retarget, resolve ours/theirs, force-push, or mix stale ADR 0347 / v2.104.0 identity into #920. Do not mix #877 origin-tick stack. Leave #890 open as dirty draft. Do not squash-merge. Do not self-approve. Issues #79 and #87 stay OPEN. |
…r-axis independently of leftover-map comparison graphic leftover-map origin (v2.114.0)
Caption leftover-map comparison leftover-axis leftover-map origin through leftoverMapCompareAxisOriginBadge (ADR 0357). Distinct accessible name leftover map comparison leftover axis leftover-map origin {origin}. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftoverMapAxisOriginBadge stays unnamed. No SQL. Do not invent leftover-map origin from ζ, leftover-map axis share, or σ_k. Do not mix #877. Do not mix #890.
1 participant
Current stack repair
The feature delta is preserved, but its original ADR/version allocation is no longer authoritative. Live queue inspection found that this branch and #891 both claimed ADR 0347 / v2.104.0 from the same #889 predecessor. The canonical leftover-map line continued through #891 → #892 → #893 → #912 → #913 → #916 → #917 and now #918.
This PR is retargeted to the current #918 branch
feat/leftover-map-compare-list-criterion-origin-badge-v21110@a91d2ec56bad922f9159e17649f77d229a0f98d3. GitHub reports a real content conflict on that exact predecessor. Do not resolve it with ours/theirs, force-push, destructive rebase, or stale whole-file replacement.Exact head:
d2d67de7e1ed80f62d1941ce304c414699f8f60b.Exact base:
#918@a91d2ec56bad922f9159e17649f77d229a0f98d3.docs/adr/0347-leftover-map-plot-origin-badge.mdremains explicitly Proposed because that number/version belongs to the historical collision, not to an accepted current contract. The preserved unique product delta is to name the non-comparison leftover-map graphic origin throughleftoverMapPlotOriginBadge, keep comparison origin unnamed in this increment, preserve origin-tick/axis-share/singular semantics, and never invent a leftover score or theta.Before this lane can become mergeable/Accepted, that unique source/test/i18n delta must be conflict-preservingly reconstructed on #918 (or its live successor) and receive a new unique ADR/version identity after the predecessor's current allocation. No ADR number or product version is reserved merely by this repair note. The previous pre-retarget lint/type/vitest claims are not current-head evidence, and predecessor checks/reviews/approvals do not transfer.