Skip to content

feat(reports): leftover-map origin on leftover-map comparison graphic leftover-map criterion leftover-map item coordinates independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates (v2.107.0) - #912

Draft
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-post-origin-badge-v21060from
feat/leftover-map-compare-plot-criterion-origin-badge-v21070
Draft

feat(reports): leftover-map origin on leftover-map comparison graphic leftover-map criterion leftover-map item coordinates independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates (v2.107.0)#912
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-plot-post-origin-badge-v21060from
feat/leftover-map-compare-plot-criterion-origin-badge-v21070

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #893 @ f2a1860 (feat/leftover-map-compare-plot-post-origin-badge-v21060). leftoverMapComparePlotCriterionBadge (ADR 0350 / v2.107.0) names leftover-map origin on leftover-map comparison graphic leftover-map criterion leftover-map item coordinates independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates.

  • Distinct accessible name leftover map comparison graphic leftover-map criterion {label} at leftover-map origin ζ {item} when leftoverMapPlotCoordinatePairIsOrigin returns true (formatLeftoverMapCoordinatePair(0, 0) === (0.00, 0.00)).
  • Rank-0 unused axes still name leftover-map origin (0.00, 0.00).
  • Non-origin leftover-map comparison graphic leftover-map criterion leftover-map item coordinates stay leftover map comparison graphic leftover-map criterion {label} at ζ {item}.
  • leftoverMapPlotCriterionBadge stays leftover-map graphic leftover-map criterion leftover-map origin leftover-map item coordinate keys from ADR 0347.
  • leftoverMapComparePlotPostBadge stays leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinate keys from ADR 0349.
  • leftoverMapListCriterionBadge stays leftover-map pair leftover-map criterion leftover-map item coordinate keys from ADR 0340.
  • leftoverMapCompareListCriterionBadge stays leftover-map comparison leftover-pair leftover-map criterion leftover-map item coordinate keys from ADR 0342. Do not mix feat(reports): leftover-map origin on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share and leftover-map singular values (v2.92.0) #877.
  • Do not invent leftover-map origin from leftover-map person coordinates ξ.
  • UI-only. No SQL. No new columns. Never invent a leftover score. Never invent a theta.

Test plan

Leave open for independent review. Do not self-approve. Do not squash-merge.


Devin Review

… leftover-map criterion leftover-map item coordinates independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates (v2.107.0)

Caption leftover-map comparison graphic leftover-map criterion leftover-map origin leftover-map item coordinates through leftoverMapComparePlotCriterionBadge independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates (ADR 0350). Distinct accessible name leftover map comparison graphic leftover-map criterion {label} at leftover-map origin ζ {item} when leftoverMapPlotCoordinatePairIsOrigin returns true. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftoverMapPlotCriterionBadge stays leftover-map graphic leftover-map criterion leftover-map origin leftover-map item coordinate keys. leftoverMapComparePlotPostBadge stays leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinate keys. Do not invent leftover-map origin from leftover-map person coordinates ξ. Do not mix #877.
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 05a426f8-dd61-4674-b0ba-3945026f8611

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Cycle overlay 2026-09-02: leftoverMapComparePlotCriterionBadge (ADR 0350 / v2.107.0) names leftover-map origin on leftover-map comparison graphic leftover-map criterion leftover-map item coordinates independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates. Exact head 2ac677b stacked on #893 @ f2a1860. No independent APPROVE (Devin COMMENT is not APPROVE). Leave open. Do not self-approve. Do not squash-merge. Do not mix #877. Issues #79 and #87 stay OPEN. leftoverMapListPostBadge stays leftover-map pair leftover-map post leftover-map person coordinate keys this increment. Next buyer gap is leftover-map origin on leftover-map pair leftover-map post leftover-map person coordinates independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

Comment thread CHANGELOG.md
Comment on lines +11 to +21
- Period leftover pairs now caption leftover-map comparison graphic leftover-map criterion leftover-map origin leftover-map item coordinates
through leftoverMapComparePlotCriterionBadge independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates (ADR 0350 / v2.107.0). After `make seed`, leftover-map comparison graphic leftover-map
criterion leftover-map origin leftover-map item coordinates name leftover-map origin when leftoverMapPlotCoordinatePairIsOrigin returns true. Distinct accessible name
`leftover map comparison graphic leftover-map criterion {label} at leftover-map origin ζ {item}`. Rank-0 unused axes still name leftover-map origin `(0.00, 0.00)`.
Non-origin leftover-map comparison graphic leftover-map criterion leftover-map item coordinates stay
`leftover map comparison graphic leftover-map criterion {label} at ζ {item}`. leftoverMapPlotCriterionBadge stays leftover-map graphic leftover-map
criterion leftover-map origin leftover-map item coordinate keys. leftoverMapComparePlotPostBadge stays leftover-map comparison graphic leftover-map
post leftover-map origin leftover-map person coordinate keys this increment. Do not invent leftover-map origin from leftover-map person coordinates `ξ`.
Do not mix #877. A finite negative leftover is shown, never clamped. Never invent a leftover score or a theta. No new columns.


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Previous changelog entry loses heading

The v2.106.0 entry now starts mid-sentence without its bullet heading. Readers cannot identify the feature that its remaining text describes.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2ac677bae5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CHANGELOG.md
Comment on lines +11 to +12
- Period leftover pairs now caption leftover-map comparison graphic leftover-map criterion leftover-map origin leftover-map item coordinates
through leftoverMapComparePlotCriterionBadge independently of leftover-map comparison graphic leftover-map post leftover-map origin leftover-map person coordinates (ADR 0350 / v2.107.0). After `make seed`, leftover-map comparison graphic leftover-map

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore the displaced v2.106 changelog heading

Adding the v2.107 entry replaces the first two lines of the existing ADR 0349 / v2.106 entry instead of inserting above them. As a result, lines 22–28 are now an orphaned continuation beginning with “post leftover-map…” and the changelog no longer identifies the v2.106 feature or its helper/ADR. Preserve the prior bullet intact below the new entry so generated or rendered release notes retain that release history.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Pushed stacked ADR 0351 / v2.108.0 leftoverMapListPostBadge origin onto this exact head 2ac677b as feat/leftover-map-list-post-origin-badge-v21080. leftoverMapComparePlotCriterionBadge stays leftover-map comparison graphic leftover-map criterion leftover-map origin leftover-map item coordinate keys this increment. Leave #912 open. No independent APPROVE on 2ac677b (Devin COMMENT is not APPROVE). Do not self-approve. Do not squash-merge. Do not mix #877. Issues #79 and #87 stay OPEN.

Copy link
Copy Markdown
Contributor Author

Devin/Codex CHANGELOG heading note: inserting v2.107.0 replaced the v2.106.0 bullet start. Restoration of intact ADR 0350 / v2.107.0 and ADR 0349 / v2.106.0 Unreleased bullets lands on stacked #913 @ 371bb82. Do not self-approve #912. Devin COMMENT is not independent APPROVE. Leave open. Do not squash-merge. Do not mix #877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant