Skip to content

feat(reports): leftover-map origin on leftover-map graphic independently of leftover-map comparison leftover-pair leftover-map criterion leftover-map origin leftover-map item coordinates (v2.112.0) - #920

Draft
seonghobae wants to merge 2 commits into
feat/leftover-map-compare-list-criterion-origin-badge-v21110from
feat/leftover-map-plot-origin-badge-v21120
Draft

feat(reports): leftover-map origin on leftover-map graphic independently of leftover-map comparison leftover-pair leftover-map criterion leftover-map origin leftover-map item coordinates (v2.112.0)#920
seonghobae wants to merge 2 commits into
feat/leftover-map-compare-list-criterion-origin-badge-v21110from
feat/leftover-map-plot-origin-badge-v21120

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #918 @ a91d2ec56bad922f9159e17649f77d229a0f98d3 (feat/leftover-map-compare-list-criterion-origin-badge-v21110). leftoverMapPlotOriginBadge (ADR 0355 / v2.112.0 allocation) names leftover-map graphic origin independently of comparison criterion-origin coordinates, axis-origin ticks, axis share, and singular values.

This reconstructs the unique product delta of dirty draft #890 without reusing its stale ADR 0347 / v2.104.0 identity. Do not close #890 until full successor inheritance is verified.

Current repair state

  • Distinct accessible name remains leftover-map origin {origin} when the plot exists and the origin badge is usable; rank-0 remains (0.00, 0.00).
  • No SQL/schema change; no invented leftover score or theta.
  • Review found the branch had been Ready while its material-UI validation was incomplete. It is Draft again.
  • ADR 0355 was prematurely marked Accepted on an unmerged Draft. Exact-head repair d54c5611cc693bb7a85e9164814761417ccb563e restores Decision status: Proposed; it becomes Accepted only through the protected delivery decision, not by branch-local assertion.
  • Repository i18n currently exposes only EN/KO/ZH/JA/VI and ships translations from frontend/src/i18n.ts. That does not satisfy the required KO/EN/JA/ZH/VI/ES/DE/FR + versioned DB translation-ledger/screen-key-cache boundary. Owner-path repair and RED/GREEN acceptance are tracked in i18n: move UI translations to versioned DB ledger and complete 8-locale coverage #922. English fallback is not translated coverage; ontology labels remain separate.

Exact live merge boundary

Keep Draft until #922-compatible i18n/accessibility evidence, exact-head terminal checks, and qualifying independent review exist. No self-approval, force-push, destructive rebase, bypass, or gate weakening.

…tly of leftover-map comparison leftover-pair leftover-map criterion leftover-map origin leftover-map item coordinates (v2.112.0)

Caption leftover-map graphic leftover-map origin through leftoverMapPlotOriginBadge independently of leftover-map comparison leftover-pair leftover-map criterion leftover-map origin leftover-map item coordinates, leftover-map axis origin ticks, leftover-map axis share, and leftover-map singular values (ADR 0355). Distinct accessible name leftover-map origin {origin}. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftover-map comparison graphic leftover-map origin stays unnamed this increment. leftoverMapCompareListCriterionBadge stays leftover-map comparison leftover-pair leftover-map criterion leftover-map origin leftover-map item coordinate keys. leftoverMapPlotTickAxisBadge stays leftover-map graphic leftover-map axis origin tick keys. Do not invent leftover-map origin from leftover-map item coordinates ζ. Do not mix #877. Do not mix #890 stale ADR 0347 / v2.104.0 identity.
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Hourly loop 2026-09-03: opened stacked leftoverMapPlotOriginBadge (ADR 0355 / v2.112.0) reconstructing #890 unique product delta onto #918 without mixing stale ADR 0347 / v2.104.0 identity.

Exact head 350400792c1f9aca1b1237328c47e805d8eb7f5f. leftover-map comparison graphic leftover-map origin stays unnamed this increment (next buyer leftoverMapComparePlotOriginBadge / ADR 0356 / v2.113.0). Only collaborator is seonghobae — do not self-approve. Do not squash-merge. Issues #79 and #87 stay OPEN. Do not mix #877. Do not mix #890.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Hourly loop 2026-09-03: leftoverMapComparePlotOriginBadge stacked as the next buyer increment on this head (ADR 0356 / v2.113.0, feat/leftover-map-compare-plot-origin-badge-v21130 @ fb9d0a30e3952ace79fa19720538222233e7e2ab). Distinct accessible name leftover map comparison graphic leftover-map origin {origin}. leftoverMapPlotOriginBadge stays leftover-map graphic leftover-map origin keys.

#920 still lacks independent APPROVE. Only collaborator is seonghobae — cannot request independent review. Do not self-approve. Do not squash-merge #920 onto unprotected leftover bases. Do not mix #877. Do not mix #890. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finding on exact head 350400792c1f9aca1b1237328c47e805d8eb7f5f: this is also a material UI/i18n increment, but the repository currently supports only EN/KO/ZH/JA/VI and keeps production translations in the SPA source. ES/DE/FR plus the versioned database translation-ledger/screen-key-cache boundary are missing. I moved the PR back to Draft and opened #922 with RED/GREEN acceptance. Do not mark this lane Ready merely because current five-locale tests pass; English fallback is not translated coverage, and ontology labels must remain outside the presentation translation ledger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant