Skip to content

feat(reports): leftover-map origin on leftover-map comparison graphic independently of leftover-map graphic leftover-map origin (v2.113.0) - #921

Draft
seonghobae wants to merge 2 commits into
feat/leftover-map-plot-origin-badge-v21120from
feat/leftover-map-compare-plot-origin-badge-v21130
Draft

feat(reports): leftover-map origin on leftover-map comparison graphic independently of leftover-map graphic leftover-map origin (v2.113.0)#921
seonghobae wants to merge 2 commits into
feat/leftover-map-plot-origin-badge-v21120from
feat/leftover-map-compare-plot-origin-badge-v21130

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #920 exact head d54c5611cc693bb7a85e9164814761417ccb563e. leftoverMapComparePlotOriginBadge (ADR 0356 / v2.113.0 allocation) names leftover-map comparison graphic origin independently of the non-comparison graphic origin, criterion-origin coordinates, axis-origin ticks, axis share, and singular values.

Current repair state

  • Distinct accessible name remains leftover map comparison graphic leftover-map origin {origin} when the comparison plot exists and the origin badge is usable; rank-0 remains (0.00, 0.00).
  • No SQL/schema change; no invented leftover score or theta.
  • Review found this branch had been Ready while its material-UI validation was incomplete. It is Draft again.
  • ADR 0356 was prematurely Accepted. During parent convergence ADR 0355 was restored to Proposed, and this child was non-force restacked by merge commit 76ebcb10a72955a68c616c02e6e0732db0800f93; the same commit restores ADR 0356 to Proposed. No force-push/destructive rebase was used.
  • The two Devin inline notes were informational (plot-gated origin rendering; origin helper independent of plot metadata), matched current source, and are resolved. They are not approvals.
  • Repository i18n currently exposes only EN/KO/ZH/JA/VI and keeps production translations in the SPA source. Required ES/DE/FR plus the versioned DB translation-ledger/screen-key-cache boundary remain missing; i18n: move UI translations to versioned DB ledger and complete 8-locale coverage #922 owns the RED/GREEN product repair. English fallback is not translated coverage, and ontology labels stay separate.

Exact live merge boundary

  • base: #920@d54c5611cc693bb7a85e9164814761417ccb563e
  • exact head: 76ebcb10a72955a68c616c02e6e0732db0800f93
  • GitHub: open / Draft / mechanically mergeable
  • exact-head Tests run 33705821329 is non-terminal; predecessor test evidence does not transfer
  • no qualifying independent APPROVE applies to this changed head
  • no open descendant targets this branch at the current sweep

Keep Draft until #922-compatible i18n/accessibility evidence, exact-head terminal checks, and qualifying independent review exist. No self-approval, force-push, destructive rebase, bypass, or gate weakening.

… independently of leftover-map graphic leftover-map origin (v2.113.0)

Caption leftover-map comparison graphic leftover-map origin through leftoverMapComparePlotOriginBadge independently of leftover-map graphic leftover-map origin, leftover-map comparison leftover-pair leftover-map criterion leftover-map origin leftover-map item coordinates, leftover-map axis origin ticks, leftover-map axis share, and leftover-map singular values (ADR 0356). Distinct accessible name leftover map comparison graphic leftover-map origin {origin}. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftoverMapPlotOriginBadge stays leftover-map graphic leftover-map origin keys. leftoverMapComparePlotTickAxisBadge stays leftover-map comparison graphic leftover-map axis origin tick keys. Do not invent leftover-map origin from leftover-map item coordinates ζ. Do not mix #877. Do not mix #890 stale ADR 0347 / v2.104.0 identity.
@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Hourly loop 2026-09-03: opened stacked leftoverMapComparePlotOriginBadge (ADR 0356 / v2.113.0) onto #920 without mixing #877 or #890 stale ADR 0347 / v2.104.0 identity.

Exact head fb9d0a30e3952ace79fa19720538222233e7e2ab. leftoverMapPlotOriginBadge stays leftover-map graphic leftover-map origin keys. Next buyer leftoverMapCompareAxisOriginBadge / ADR 0357 / v2.114.0. Only collaborator is seonghobae — do not self-approve. Do not squash-merge. Issues #79 and #87 stay OPEN.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 2 potential issues.

Devin Review

Comment thread frontend/src/components/LeftoverMapPlot.tsx
Comment thread frontend/src/leftoverMapPlotAxisSingular.ts
@seonghobae
seonghobae marked this pull request as draft September 3, 2026 01:53

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finding on exact head fb9d0a30e3952ace79fa19720538222233e7e2ab: this material UI increment adds a new production translation key only to the current KO/ZH/JA/VI source dictionary. Live SUPPORTED_LOCALES is still EN/KO/ZH/JA/VI, so ES/DE/FR are absent, and the production translation source remains bundled in frontend/src/i18n.ts rather than the required versioned database translation ledger + screen-key cache. I moved this PR back to Draft; do not mark it Ready or treat its i18n checklist as complete until the owner-path repair in #922 has a released/consumable contract or this branch is safely converged onto that repair. English fallback is not evidence of Spanish/German/French translation coverage. Keep ontology labels separate from presentation translations.

Copy link
Copy Markdown
Contributor Author

Cycle 2026-09-03T05:01Z: i18n / translation-ledger work (#922, ADR 0357, v2.31.0, branch feat/i18n-translation-ledger-eight-locales) is independent of this leftover-map origin stack. It does not mix into #912#921, does not change leftover-map origin badges, and does not invent a leftover score or a theta. Origin-badge PRs stay stacked; i18n targets main.

Copy link
Copy Markdown
Contributor Author

Cycle retry (2026-09-03 KST). Next buyer increment is leftoverMapCompareAxisOriginBadge (ADR 0357 / v2.114.0) stacked on this leftover-map comparison graphic leftover-map origin head. leftoverMapAxisOriginBadge stays unnamed this increment. Do not self-approve. Keep Draft until independent APPROVE + exact-head required success. Synthetic fixtures only; PII masking forbidden. NVIDIA_NIM_API_KEY only.

Copy link
Copy Markdown
Contributor Author

Cycle retry 2026-09-03T17:08 KST. leftoverMapCompareAxisOriginBadge (ADR 0357 / v2.114.0) is implemented locally on feat/leftover-map-compare-axis-origin-badge-v21140 stacked on this exact head 76ebcb1. Tests GREEN (App.test 103; leftoverMapPlotAxisSingular/i18n/leftoverMapAxisBadge/leftoverMapPlotLayout 636). leftoverMapAxisOriginBadge stays unnamed. Do not squash-merge this PR without independent APPROVE + exact-head required success. Never self-approve. Keep Draft.

Copy link
Copy Markdown
Contributor Author

Descendant Draft #926 (feat/leftover-map-compare-axis-origin-badge-v21140 @ ede308929b20f24a56c5ff3ae2211dd84d20f3ae, ADR 0357 / v2.114.0 leftoverMapCompareAxisOriginBadge) is stacked on this exact head. Do not squash-merge this PR without independent APPROVE + exact-head required success. Never self-approve. Keep Draft. leftoverMapAxisOriginBadge stays unnamed until the next increment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant