feat(reports): leftover-map origin on leftover-map graphic leftover-map criterion leftover-map item coordinates independently of leftover-map person coordinates (v2.104.0) - #891
Conversation
…ap criterion leftover-map item coordinates independently of leftover-map person coordinates (v2.104.0)
Caption leftover-map graphic leftover-map criterion leftover-map origin leftover-map item coordinates through leftoverMapPlotCriterionBadge independently of leftover-map person coordinates (ADR 0347). Distinct accessible name leftover-map criterion {label} at leftover-map origin ζ {item} when leftoverMapPlotCoordinatePairIsOrigin returns true. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftoverMapComparePlotCriterionBadge stays leftover-map comparison graphic leftover-map criterion leftover-map item coordinate keys. leftoverMapPlotPostBadge stays leftover-map graphic leftover-map post leftover-map person coordinate keys. Do not invent leftover-map origin from leftover-map person coordinates ξ. Do not mix #877.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| export function leftoverMapPlotCoordinatePairIsOrigin(pairLabel: string): boolean { | ||
| const origin = formatLeftoverMapCoordinatePair(0, 0); | ||
| return origin !== null && pairLabel === origin; | ||
| } | ||
|
|
||
| export function formatLeftoverMapCoordinates( | ||
| personAxis1: number | null | undefined, | ||
| personAxis2: number | null | undefined, |
There was a problem hiding this comment.
📝 Info: Origin follows displayed precision
leftoverMapPlotCoordinatePairIsOrigin treats coordinates rounding to (0.00, 0.00) as origin. This matches ADR 0347 and the displayed two-decimal coordinates.
Was this helpful? React with 👍 or 👎 to provide feedback.
| const origin = leftoverMapPlotCoordinatePairIsOrigin(item); | ||
| return { | ||
| key: origin ? LEFTOVER_MAP_PLOT_CRITERION_ORIGIN : LEFTOVER_MAP_PLOT_CRITERION, | ||
| values: { label, item }, | ||
| }; |
There was a problem hiding this comment.
📝 Info: Origin key remains isolated
Only leftoverMapPlotCriterionBadge selects the new key. Comparison, post, and list labels retain their existing helpers and accessible names.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
Next buyer increment stacks on this exact head ( |
1 participant
Summary
Stacked on #889 @
4bfb490(feat/leftover-map-axis-tick-origin-badge-v21030). leftoverMapPlotCriterionBadge (ADR 0347 / v2.104.0) names leftover-map origin on leftover-map graphic leftover-map criterion leftover-map item coordinates independently of leftover-map person coordinates.leftover-map criterion {label} at leftover-map origin ζ {item}when leftoverMapPlotCoordinatePairIsOrigin returns true (formatLeftoverMapCoordinatePair(0, 0)===(0.00, 0.00)).(0.00, 0.00).leftover-map criterion {label} at ζ {item}.ξ.Test plan
pnpm exec oxlinton leftover-map criterion origin files: 0 warnings, 0 errorspnpm exec tsc -bcleanLeave open for independent review. Do not self-approve. Do not squash-merge.