Skip to content

feat(reports): leftover-map origin on leftover-map comparison leftover-pair leftover-map criterion leftover-map item coordinates independently of leftover-map comparison leftover-pair leftover-map post leftover-map origin leftover-map person coordinates (v2.111.0) - #918

Draft
seonghobae wants to merge 1 commit into
feat/leftover-map-compare-list-post-origin-badge-v21100from
feat/leftover-map-compare-list-criterion-origin-badge-v21110

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Stacked on #917 @ 8192b485 (feat/leftover-map-compare-list-post-origin-badge-v21100). leftoverMapCompareListCriterionBadge (ADR 0354 / v2.111.0) names leftover-map origin on leftover-map comparison leftover-pair leftover-map criterion leftover-map item coordinates independently of leftover-map comparison leftover-pair leftover-map post leftover-map origin leftover-map person coordinates.

  • Distinct accessible name leftover map comparison leftover pair leftover-map criterion {label} at leftover-map origin ζ {item} when leftoverMapPlotCoordinatePairIsOrigin returns true (formatLeftoverMapCoordinatePair(0, 0) === (0.00, 0.00)).
  • Rank-0 unused axes still name leftover-map origin (0.00, 0.00).
  • Non-origin leftover-map comparison leftover-pair leftover-map criterion leftover-map item coordinates stay leftover map comparison leftover pair leftover-map criterion {label} at ζ {item}.
  • leftoverMapCompareListPostBadge stays leftover-map comparison leftover-pair leftover-map post leftover-map origin leftover-map person coordinate keys from ADR 0353.
  • leftoverMapListCriterionBadge stays leftover-map pair leftover-map criterion leftover-map origin leftover-map item coordinate keys from ADR 0352.
  • leftoverMapComparePlotCriterionBadge stays leftover-map comparison graphic leftover-map criterion leftover-map origin leftover-map item coordinate keys from ADR 0350.
  • leftoverMapPlotCriterionBadge stays leftover-map graphic leftover-map criterion leftover-map origin leftover-map item coordinate keys from ADR 0347. Do not mix feat(reports): leftover-map origin on leftover-map comparison graphic leftover-map axis ticks independently of leftover-map axis share and leftover-map singular values (v2.92.0) #877. Do not mix feat(reports): preserve leftover-map plot-origin delta for post-#918 ADR/version reconstruction #890 leftoverMapPlotOriginBadge reconstruction into this increment.
  • Do not invent leftover-map origin from leftover-map person coordinates ξ.
  • UI-only. No SQL. No new columns. Never invent a leftover score. Never invent a theta.

Exact head: a91d2ec56bad922f9159e17649f77d229a0f98d3

Test plan

Leave open for independent review. Do not self-approve. Do not squash-merge.


Devin Review

…r-pair leftover-map criterion leftover-map item coordinates independently of leftover-map comparison leftover-pair leftover-map post leftover-map origin leftover-map person coordinates (v2.111.0)

Caption leftover-map comparison leftover-pair leftover-map criterion leftover-map origin leftover-map item coordinates through leftoverMapCompareListCriterionBadge independently of leftover-map comparison leftover-pair leftover-map post leftover-map origin leftover-map person coordinates (ADR 0354). Distinct accessible name leftover map comparison leftover pair leftover-map criterion {label} at leftover-map origin ζ {item} when leftoverMapPlotCoordinatePairIsOrigin returns true. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftoverMapCompareListPostBadge stays leftover-map comparison leftover-pair leftover-map post leftover-map origin leftover-map person coordinate keys. leftoverMapListCriterionBadge stays leftover-map pair leftover-map criterion leftover-map origin leftover-map item coordinate keys. leftoverMapComparePlotCriterionBadge stays leftover-map comparison graphic leftover-map criterion leftover-map origin leftover-map item coordinate keys. Do not invent leftover-map origin from leftover-map person coordinates ξ. Do not mix #877.
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a9836632-190d-46eb-81d1-009dd97b8570

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact head a91d2ec56bad922f9159e17649f77d229a0f98d3 on feat/leftover-map-compare-list-criterion-origin-badge-v21110, stacked on #917 @ 8192b485. leftoverMapCompareListCriterionBadge (ADR 0354 / v2.111.0) names leftover-map origin when leftoverMapPlotCoordinatePairIsOrigin returns true. Distinct accessible name leftover map comparison leftover pair leftover-map criterion {label} at leftover-map origin ζ {item}. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). Local checks: oxlint 0/0, tsc -b clean, vitest leftoverMapCoordinates leftoverMapPlotLayout LeftoverPairList App i18n 822 passed. Copilot review requested. Leave open for independent APPROVE. Do not self-approve. Do not squash-merge onto unprotected leftover bases. Do not mix #877. Do not mix #890 leftoverMapPlotOriginBadge reconstruction (next increment ADR 0355 / v2.112.0). Issues #79 and #87 stay OPEN.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Cycle 2026-09-02T23:20 KST: exact head a91d2ec56 still has only Devin COMMENT, not independent APPROVE. Leave open. Do not self-approve. Do not squash-merge onto the unprotected leftover base. Next leftover-map origin increment (v2.112.0) will stack onto this head, not mix into #890 reconstruction or #877 origin-tick. Issues #79 and #87 stay OPEN.

Copy link
Copy Markdown
Contributor Author

Loop 2026-09-03 09:15 KST. Writes work (MCP). Do not self-approve.

Exact head a91d2ec56bad922f9159e17649f77d229a0f98d3 still lacks independent APPROVE (Devin/Copilot/CodeRabbit COMMENT is not APPROVE). Only collaborator is seonghobae; no independent reviewer can be requested from this token.

This cycle reconstructs leftoverMapPlotOriginBadge independently of leftover-map comparison leftover-pair leftover-map criterion leftover-map origin leftover-map item coordinates as ADR 0355 / v2.112.0 on a fresh branch stacked on this head. Distinct accessible name leftover-map origin {origin}. Rank-0 unused axes still name leftover-map origin (0.00, 0.00). leftover-map comparison graphic leftover-map origin stays unnamed this increment. Do not mix #877. Do not mix dirty draft #890 stale ADR 0347 / v2.104.0 identity.

Leave this PR open. Do not squash-merge onto an unprotected leftover base. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE.

Copy link
Copy Markdown
Contributor Author

Hourly loop 2026-09-03: leftoverMapPlotOriginBadge reconstruction stacked as #920 (feat/leftover-map-plot-origin-badge-v21120 @ 350400792c1f9aca1b1237328c47e805d8eb7f5f, ADR 0355 / v2.112.0) onto this head. Unique product of dirty draft #890 without mixing stale ADR 0347 / v2.104.0 identity.

#918 still lacks independent APPROVE (Devin COMMENT 5088996142 is not independent APPROVE). Only collaborator is seonghobae — cannot request independent review. Do not squash-merge #918 or #920 onto unprotected leftover bases. Do not mix #877. Do not mix #890. Issues #79 and #87 stay OPEN. Do not merge #808 without independent APPROVE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant