[AutoPR @azure/arm-recoveryservices-siterecovery] ASR: Adding new Resource replication protection intent and its associated PUT and GET call#1687
Closed
openapi-sdkautomation[bot] wants to merge 406 commits into
Closed
Conversation
10 tasks
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery@10484
branch
6 times, most recently
from
46e5dd7 to
a9bbb4c
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery
branch
from
d03f2b8 to
dbc35d7
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery@10484
branch
3 times, most recently
from
eb0bd1b to
628a2cb
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery
branch
from
dbc35d7 to
2ba35c8
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery@10484
branch
4 times, most recently
from
673dd1b to
8f36fc5
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery
branch
from
2ba35c8 to
df6803d
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery@10484
branch
from
8f36fc5 to
2dc6d58
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery
branch
from
df6803d to
bfb28fa
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery@10484
branch
3 times, most recently
from
ad489f7 to
086df7c
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery
branch
2 times, most recently
from
6862f70 to
b8a8882
Compare
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery
branch
from
b8a8882 to
8a3a63b
Compare
…cals tsconfig fixes (Azure#11453) * Extend tsconfig in cosmos, identity from base config * identity noImplicitReturns tslint fixes * identity noUnusedParameters tslint fixes * identity noUnusedLocals tslint fixes * Restore options param to getToken method * Use _options param in getToken method * Restore options param for getToken method * Removed redundant compilerOptions * update getAzureCliAccessToken return type * Remove eslint-disable no-unused-vars comment Co-authored-by: Ramya Achutha Rao <ramyar@microsoft.com> Co-authored-by: Mohsin Mehmood <mohsin85mehmod@gmail.com>
- Update our README.md to point at the master branch of azure-rest-api-specs as all the changes we were depending on in feature branches have now been merged. - Re-run Autorest to regenerate the generated code, as part of this change we are picking up a new KeyVault event and some small changes to the names of some Azure Communication Service types. - Add the Azure Key Valut events to the list of supported system events.
* Prototype batch * Format * Support SharedKey auth * Formatting * Add comments * Take InnerBatchRequest * Address some comments * Fix circular dependency * Hide internalBatchRequest * Parse sub responses * rename subResponses * Update import * move sample interface to the top * Fix eslint * Add span * Split tests * Fix lint * undo changes in tableclient test * Use the right URL * Hide BatchOptions and mock guid * Format * Workaround generateUuid stub issue * format
* Add the Code -> code mapping for StorageError * fix ci
* uploadData for Node.js and browsers, refactor duplicated code * inline, changelog and add test case for browser * nit: comments
…dexer, datasource and skillset metadata (Azure#12275) * Result of Regeneration Command * Changes to the custom layer * API Changes * Update Recordings
Azure#12203) * [ai-form-recognizer] modelName convenience layer * Major refactor of training tests * Re-record all tests * Generate javascript samples and fix sample metadata * CHANGELOG * Some samples fixes * Fixed recording file length, removed some extraneous recordings. * Lint fixes * A few cleanup items
Let's release preview.8!
) * [MetricsAdvisor] change timestamps type from Date to number This addresses one of the Arch Board review feedback. I still keep the timestamps in MetricSeriesData and MetricEnrichedSeriesData as Date type because their most common usage is plotting because keeping them as Date make it easier to use year/month/date in x-axis labels. * Remove unused type * Update CHANGELOG
Azure#11976) This PR does the following: 1. Simplifies the workflow of ManagedIdentityCredential, fixing Azure#11653 2. Implements caching on the managed credential so that we only verify which MSI is available once per instance of this class. There's no issue for this, but this is necessary to align with .Net 3. Adds Azure Arc support, fixing Azure#10235 4. Adds Azure Fabric support, fixing Azure#10238 ### Simplifies the workflow of ManagedIdentityCredential This is now how we pick what MSI credential is available: ```ts const MSIs = [appServiceMsi2019, appServiceMsi2017, arcMsi, cloudShellMsi, imdsMsi]; for (const msi of MSIs) { if (await msi.isAvailable(this.identityClient, resource, clientId, getTokenOptions)) { this.cachedMSI = msi; return msi; } } ``` Shows the order of verification more clearly. Reduces the complexity of the credential. ### Implements caching on the managed credential The managed credential was verifying the availability of the MSIs on each request - except for the IMDS one, which had a very weird flow with a stateful boolean value that was passed through from method to method. Instead of doing that, the first time we authenticate we define what MSI is available, and subsequent calls won't run any validation. This aligns with .Net. ### Adds Azure Arc support This PR also showcases the refactoring by how simple it is to add a new MSI to the main ManagedIdentityCredential class. The notes on how I was able to write and test the Arc MSI are here: https://gist.github.com/sadasant/888dc7e88543a21ee7061997984dd207 The change on the ManagedIdentityCredential consists of adding `arcMsi` to the array of MSIs used inside of the `cachedAvailableMSI` function. There's an important note on how I'm currently validating this environment here: [link](Azure#11976 (comment)). --- I'll leave this PR as draft until we find the time to do an internal review, then I'll move it out of draft. Fixes Azure#11653 Fixes Azure#10235 **New:** Fixes Azure#11595 Fixes Azure#10238 Closes Azure#12164 Fixes Azure#12058
* Add option to unpublish package
…#12285) Pick older core-http(~~1.1.6~~ 1.1.9) for service-bus preview.8 since 1.2.0 is not released. This will be reverted once the service-bus preview.8 is released.
…#12065) * [core-http] Support overriding xml parser char key via options Currently our xml parser uses hard-coded `_` as key to access parsed xml element content. This causes issue like storage customer getting errors listing blobs when they use `_` as Blob metadata key. This PR add support to allow customizing the xml parser char key via options. Currently `xmlCharKey` option is supported, with room for other xml parser options (e.g., attr key for accessing parsed xml attributes). * Address CR feedback - introduce XmlOptions interface - Make xml options required for private methods - Remove duplicate by introducing locals * Rename XmlOptions to more general SerializerOptions * Make internal options `Required<SerializerOptions>` * - Fix one missing place - update CHANGELOG
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: SDK Automation <sdkautomation@microsoft.com>
Co-authored-by: SDK Automation <sdkautomation@microsoft.com>
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery@10484
branch
3 times, most recently
from
db0bfce to
715d1e8
Compare
This test was unintentionally checked-in as part of a huge PR, I meant to remove it but left it since it was harmless. Just cleaning it up now to reduce the false positives in [here](https://dev.azure.com/azure-sdk/internal/_build/results?buildId=606570&view=logs&j=073ebbf1-9390-59a1-0ff8-08c656576bcd&t=428931fe-c351-55db-0604-c27a1c97620f).
…zure#12202) and fix TypeScript sample build errors
…r retryable disconnect event (Azure#12280) Fixes Azure#12278 ## Description This PR adds a check within the `PartitionPump`'s receive events loop to determine whether the receiver has been closed. If the receiver has been closed, it will create a new receiver using an event start position that matches the last event seen by the pump. The receiver is explicitly closed when a disconnected event is received on the underlying AMQP connection, which causes calls to `receiveBatch` to immediately return any events it had collected up to this point. Note that once the receiver is closed, the receiver's onAmqpMessage handler is removed so it won't receive any additional events. ## Updates to testing I manually tested the changes in this PR against the sample code in the linked issue. I also updated the existing `disconnect` test to confirm that - the `maxWaitTimeInSeconds` is honoured after a disconnected event is encountered. - new events can be received on subsequent `processEvents` invocations.
* Align readme with other languages * Align readme with other languages * Remove unused links
openapi-sdkautomation
Bot
force-pushed
the
sdkAutomation/@azure_arm-recoveryservices-siterecovery@10484
branch
from
715d1e8 to
6b67f1e
Compare
openapi-sdkautomation
Bot
deleted the
sdkAutomation/@azure_arm-recoveryservices-siterecovery@10484
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created to sync Azure/azure-rest-api-specs#10484.
Installation Instructions
You can install the package
@azure/arm-recoveryservices-siterecoveryof this PR using the following command:Direct Download
The generated package can be directly downloaded from here: