Skip to content

[Service Bus] Pick older core-http for service-bus preview.8 🏁#12285

Merged
3 commits merged into
Azure:masterfrom
HarshaNalluru:harshan/service-bus-7.0.0-preview.8
Nov 4, 2020
Merged

[Service Bus] Pick older core-http for service-bus preview.8 🏁#12285
3 commits merged into
Azure:masterfrom
HarshaNalluru:harshan/service-bus-7.0.0-preview.8

Conversation

@HarshaNalluru
Copy link
Copy Markdown
Contributor

@HarshaNalluru HarshaNalluru commented Nov 4, 2020

Pick older core-http(1.1.6 1.1.9) for service-bus preview.8 since 1.2.0 is not released.

This will be reverted once the service-bus preview.8 is released.

@ghost ghost added the Service Bus label Nov 4, 2020
@HarshaNalluru HarshaNalluru marked this pull request as ready for review November 4, 2020 22:39
@jeremymeng
Copy link
Copy Markdown
Member

When do you plan to release sb preview.8? I am planning to release core-http 1.2.0 today or tomorrow

Comment thread sdk/servicebus/service-bus/package.json Outdated
"@azure/core-amqp": "2.0.0-beta.1",
"@azure/core-asynciterator-polyfill": "^1.0.0",
"@azure/core-http": "^1.2.0",
"@azure/core-http": "^1.1.6",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use the latest released 1.1.9?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, 1.1.6 was the last used version, and hence picked that.
I don't see a reason to not update to 1.1.9. Will do.

@HarshaNalluru
Copy link
Copy Markdown
Contributor Author

When do you plan to release sb preview.8?

Today.. more like now

@ghost
Copy link
Copy Markdown

ghost commented Nov 4, 2020

Hello @HarshaNalluru!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 0c118a7 into Azure:master Nov 4, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants