[storage] parallel upload refactor#12185
Conversation
ljian3377
requested review from
HarshaNalluru,
XiaoningLiu,
bterlson,
jeremymeng,
jiacfan,
vinjiang and
xirzec
as code owners
ghost
added
the
ljian3377
added
the
APIChange
| assert.equal((await blockBlobClient.getProperties()).accessTier, "Hot"); | ||
| }); | ||
|
|
||
| it("uploadData should work with Buffer, ArrayBuffer and ArrayBufferView", async () => { |
There was a problem hiding this comment.
Not testing the browser path for uploadData, please add!
| - `generateAccountSASQueryParameters()` | ||
| - `generateBlobSASQueryParameters()` | ||
| - Parallel uploading and downloading | ||
| - Parallel uploading and downloading. Note that `BlockBlobClient.uploadData()` is available in both Node.js and browsers. |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
|
||
| /** | ||
| * Compare the content of body from downloading operation methods with a Uint8Array. | ||
| * Work on both Node.js and browser environment. |
There was a problem hiding this comment.
NIT
| * Work on both Node.js and browser environment. | |
| * Works in both Node.js and browser environment. |
|
I really like the consolidation into a single method. |
| // High level functions | ||
|
|
||
| /** | ||
| * Uploads a Buffer(Node.js)/Blob(browsers)/ArrayBuffer/ArrayBufferView object to a BlockBlob. |
There was a problem hiding this comment.
Blob [](start = 31, length = 4)
Blob is also avaiable in Node.js.
4 participants
uploadData for Node.js and browsers, refactor duplicated code.
This fixes #9500, fixes #9927, fixes #6119 and fixes #6120.