[MetricsAdvisor] Add an alias type for createDateFeed feed parameter#12202
Merged
Conversation
jeremymeng
requested review from
KarishmaGhiya,
bterlson and
xirzec
as code owners
Member
Author
There was a problem hiding this comment.
Without the correct type, building samples would give errors like
error TS2345: Argument of type '{ name: string; crossMetricsOperator: string; metricAlertConfigurations: ({ detectionConfigurationId: string; alertScope: { scopeType: string; dimensionAnomalyScope?: undefined; }; } | { ...; })[]; hookIds: never[]; description: string; }' is not assignable to parameter of type 'Pick<AnomalyAlertConfiguration, "name" | "description" | "crossMetricsOperator" | "hookIds" | "metricAlertConfigurations">'.
Types of property 'crossMetricsOperator' are incompatible.
Type 'string' is not assignable to type '"AND" | "OR" | "XOR" | undefined'.
KarishmaGhiya
approved these changes
Nov 4, 2020
and fix TypeScript sample build errors
jeremymeng
force-pushed
the
ma-alias-types
branch
from
d23b2c9 to
f495aea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and fix TypeScript sample build errors
This resolves #11957