[Data plane][Azure Cognitive Search] Add encryptionKey property to indexer, datasource and skillset metadata#12275
Merged
Merged
Conversation
ghost
added
the
openapi-sdkautomation Bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 12, 2021
Added move validation enum values & fix S360 linting issues (Azure#12275) * Added new move product validation error codes * Added integer formats to fix S360 swagger lint validation * Fixed ModelValidation errors for v2018-11-01-preview Co-authored-by: Braden Watkins <brwatkin@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On October 2, 2020 - there was a PR (Azure/azure-rest-api-specs#10839) to search-documents swagger. The change was only in one file (searchservice.json). The file changes are:
encryptionKeyproperty to:a.
SearchIndexerDataSourceb.
SearchIndexerc.
SearchIndexerSkillSetThis PR is to generate the SDK to include the above change and do the corresponding custom layer changes. (Note: In the first run, the CI failed for 3 of the tests with error Nock: No recording found. This might be an intermittent error. Just to be on the safe side, I have recreated the recordings)
@xirzec Please review and approve