[core-http] fix An exception thrown on Safari 5.0

[ewfian]

Fixes #11758

When uploading files on Safari 5.0, An exception body must be a string, Blob, ArrayBuffer, ArrayBufferView, or a function returning NodeJS.ReadableStream. will thrown.

[ghost]

Thank you for your contribution ewfian! We will review the pull request and get back to you soon.

[xirzec]

The fix looks good to me, though can you confirm if the different way of doing this in core-client also works in Safari 5?

azure-sdk-for-js/sdk/core/core-client/src/serializer.ts

Line 387 in 57911f6

!(value?.constructor?.name === "Blob")

[ewfian]

The fix looks good to me, though can you confirm if the different way of doing this in core-client also works in Safari 5?

azure-sdk-for-js/sdk/core/core-client/src/serializer.ts

Line 387 in 57911f6

!(value?.constructor?.name === "Blob")

@xirzec There is no above code line in js file what I bundled. But the result of next is as follows. it seems won't be work.

azure-sdk-for-js/sdk/core/core-http/src/serializer.ts

Line 365 in 4399def

!(typeof Blob === "function" && value instanceof Blob)

[jeremymeng]

Thank you for the fix!

[bterlson]

Concerned that we will not have a good error message now if a user passes in a vanilla object, since we'll now try to do an instanceof check using it.

[xirzec]

Concerned that we will not have a good error message now if a user passes in a vanilla object, since we'll now try to do an instanceof check using it.

This shouldn't affect the value being passed in, the only thing that seems to be changing is how we detect that the global name Blob is present. Arguably, we could have inverted it with typeof(Blob) !== "undefined"

[jeremymeng]

@bterlson any more concerns?

[bterlson]

Sorry, no concerns, @xirzec is right that I misread the situation.