Conversation
…w/2024-01-01-preview to version 2024-04-01-preview
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.12) | new version | base version |
|---|---|---|
| AlertRules.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| AutomationRules.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| AutomationRules.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| BillingStatistics.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| Bookmarks.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| Bookmarks.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ContentPackages.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| ContentPackages.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ContentProductPackages.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| ContentProductPackages.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ContentProductTemplates.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| ContentProductTemplates.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ContentTemplates.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| ContentTemplates.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| EnrichmentWithWorkspace.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| Entities.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| EntityQueries.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| EntityQueryTemplates.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| FileImports.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| Hunts.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| Incidents.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| Incidents.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| Metadata.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| Metadata.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| OfficeConsents.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| OnboardingStates.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| OnboardingStates.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| Recommendations.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| SecurityMLAnalyticsSettings.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| SecurityMLAnalyticsSettings.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| Settings.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| SourceControls.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| SourceControls.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ThreatIntelligence.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| ThreatIntelligence.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ThreatIntelligenceCount.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ThreatIntelligenceQuery.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| TriggeredAnalyticsRuleRuns.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| Watchlists.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| Watchlists.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| WorkspaceManagerAssignments.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| WorkspaceManagerConfigurations.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| WorkspaceManagerGroups.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| WorkspaceManagerMembers.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| AlertTypes.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| AlertTypes.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ContentCommonTypes.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| ContentCommonTypes.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| EntityTypes.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| EntityTypes.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| IncidentTypes.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| IncidentTypes.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| RelationTypes.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| ThreatIntelligenceTypes.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| dataConnectorDefinitions.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| dataConnectors.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
| operations.json | 2024-04-01-preview(1f2419e) | 2024-03-01(main) |
| operations.json | 2024-04-01-preview(1f2419e) | 2024-01-01-preview(main) |
The following breaking changes are detected by comparison with the latest stable version:
Only 8 items are listed, please refer to log for more details.
The following breaking changes are detected by comparison with the latest preview version:
Only 8 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
"new":"https://github.com/Azure/azure-rest-api-specs/blob/1f2419ec0bdfe4f3747a214c3b0b6fe0eb71d5a9/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2024-04-01-preview/AlertRules.json", "old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2024-01-01-preview/AlertRules.json", "details":"Command failed: dotnet "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.111/common/temp/node_modules/.pnpm/@Azure+oad@0.10.12/node_modules/@azure/oad/dlls/OpenApiDiff.dll" -o /tmp/oad-psdW6Y/old-resolved.json -n /tmp/oad-rnEBVX/new-resolved.json\nUnhandled exception. System.NullReferenceException: Object reference not set to an instance of an object.\n at AutoRest.Swagger.Model.Schema.CompareRequired(ComparisonContext 1 context,<br> Schema priorSchema) in D:\\a\\_work\\1\\s\\openapi-diff\\src\\modeler\\AutoRest.Swagger\\Model\\Schema.cs:line 214\n at AutoRest.Swagger.Model.Schema.Compare(ComparisonContext1 context,Schema previous) in D:\a\_work\1\s\openapi-diff\src\modeler\AutoRest.Swagger\Model\Schema.cs:line 181\n at AutoRest.Swagger.Model.Schema.CompareProperties(ComparisonContext 1 context,<br> Schema priorSchema) in D:\\a\\_work\\1\\s\\openapi-diff\\src\\modeler\\AutoRest.Swagger\\Model\\Schema.cs:line 270\n at AutoRest.Swagger.Model.Schema.Compare(ComparisonContext1 context,Schema previous)" |
| The new version adds a response code '200'. New: Microsoft.SecurityInsights/preview/2024-04-01-preview/FileImports.json#L176:11 |
|
| The new version adds a response code '201'. New: Microsoft.SecurityInsights/preview/2024-04-01-preview/Settings.json#L207:11 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.SecurityInsights/preview/2024-04-01-preview/FileImports.json#L84:13 Old: Microsoft.SecurityInsights/preview/2024-01-01-preview/FileImports.json#L84:13 |
|
| The '$ref' property points to different models in the old and new versions. New: common-types/resource-management/v5/types.json#L307:9 Old: resource-manager/common/2.0/types.json#L77:9 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.SecurityInsights/preview/2024-04-01-preview/FileImports.json#L132:13 Old: Microsoft.SecurityInsights/preview/2024-01-01-preview/FileImports.json#L132:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.SecurityInsights/preview/2024-04-01-preview/FileImports.json#L184:13 Old: Microsoft.SecurityInsights/preview/2024-01-01-preview/FileImports.json#L178:13 |
|
| The '$ref' property points to different models in the old and new versions. New: Microsoft.SecurityInsights/preview/2024-04-01-preview/FileImports.json#L235:13 Old: Microsoft.SecurityInsights/preview/2024-01-01-preview/FileImports.json#L224:13 |
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️❌LintDiff: 38 Errors, 392 Warnings failed [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-preview-2024-04 | package-preview-2024-04(1f2419e) | default(main) |
[must fix]The following errors/warnings are introduced by current PR:
Only 8 items are listed, please refer to log for more details.
| Rule | Message | Related RPC [For API reviewers] |
|---|---|---|
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/AlertRules.json#L781 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/AlertRules.json#L1792 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/dataConnectors.json#L1472 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/dataConnectors.json#L1543 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/dataConnectors.json#L1550 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/dataConnectors.json#L1722 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/dataConnectors.json#L2096 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/dataConnectors.json#L2103 |
RPC-Policy-V1-05, RPC-Put-V1-23 |
The following errors/warnings exist before current PR submission:
Only 8 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
A PUT operation request body schema should be the same as its 200 response schema, to allow reusing the same entity between GET and PUT. If the schema of the PUT request body is a superset of the GET response body, make sure you have a PATCH operation to make the resource updatable. Operation: 'Actions_CreateOrUpdate' Request Model: 'parameters[6].schema' Response Model: 'responses[200].schema' Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/AlertRules.json#L338 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/AlertRules.json#L1926 |
|
Definitions must not have properties named additionalProperties except for user defined tags or predefined references. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/AlertRules.json#L2103 |
|
The delete response body must be empty. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/AutomationRules.json#L148 |
|
The delete response body must be empty. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/AutomationRules.json#L154 |
|
Properties of a PATCH request body must not be required, property:kind. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/Metadata.json#L266 |
|
Properties of a PATCH request body must not be required, property:tier. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/Metadata.json#L266 |
|
The resource name parameter 'sentinelOnboardingStateName' should be defined with a 'pattern' restriction. Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/OnboardingStates.json#L37 |
️❌Avocado: 69 Errors, 0 Warnings failed [Detail]
Only 8 items are listed, please refer to log for more details.
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/aggregations/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Aggregations.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/automationRules is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2019-01-01-preview/AutomationRules.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/automationRules/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2019-01-01-preview/AutomationRules.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks/{}/relations is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks/{}/expand is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/{}/workspaces/{}/providers/Microsoft.SecurityInsights/bookmarks/{}/relations/{} is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2019-01-01-preview/Bookmarks.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
xuhumsft
added
the
DoNotMerge
AzureRestAPISpecReview
added
ARMChangesRequested
ARMReview
BreakingChangeReviewRequired
|
Please address or respond to feedback from the ARM API reviewer. |
This was referenced Mar 25, 2024
xuhumsft
removed
the
DoNotMerge
Member
Author
|
The only newly introduced is business applications agents from #28504. The Breaking change, LintDiff etc. is generated from openAPIHub automatically. Please advise what is the next step |
xuhumsft
added
the
WaitForARMFeedback
Member
Author
Contributor
|
Please get a breaking change review before moving to ARM review (step 2). Please fill out the Due diligence checklist section and the Avocado Errors after you get the breaking change approval. |
gary-x-li
removed
the
WaitForARMFeedback
raosuhas
added
the
WaitForARMFeedback
raosuhas
reviewed
Apr 15, 2024
...manager/Microsoft.SecurityInsights/preview/2024-04-01-preview/BusinessApplicationAgents.json
Show resolved
Hide resolved
Member
Is this resource id differentfrom the workspace for which you are creating the "systems " resource ? Why do you need this duplication ? Refers to: specification/securityinsights/resource-manager/Microsoft.SecurityInsights/preview/2024-04-01-preview/examples/businessApplicationAgents/systems/Systems_CreateOrUpdate.json:14 in b1c80aa. [](commit_id = b1c80aa, deletion_comment = False) |
ramoka178
added
Approved-LintDiff
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
Member
Author
|
/pr RequestMerge |
xuhumsft
added
the
PublishToCustomers
Member
|
All the suppressions look justified to me mostly based on breaking change reasoning. |
…/resource-management/v5/types.json to resolve Go-SDK issue (#30556)
* Add blockchain to latest profile * Add additional types * Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview * Updates readme * Updates API version in new specs and examples * . * changes * . * . --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
* fix go-sdk error * remove odata parameters in post
…rityInsights-2024-04-01-preview
xuhumsft
added
the
WaitForARMFeedback
AzureRestAPISpecReview
removed
the
WaitForARMFeedback
viveksheelsingh
added
ARMSignedOff
viveksheelsingh
approved these changes
Sep 26, 2024
xuhumsft
deleted the
dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview
branch
This was referenced Nov 6, 2024
cheukchuen
pushed a commit
that referenced
this pull request
Jan 24, 2025
…preview (#28437) * Adds base for updating Microsoft.SecurityInsights from version preview/2024-01-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Release sentinel 2024 04 01 preview business applications agents (#28504) * businessApplicationAgents * prettier * businessApplicationAgents * add displayName to be required (#28720) * Add breaking changes from last stable version (#28904) * remove 4 values from enum (#28931) * [Enrichment API] Remove deprecated api (#29059) * remove deprecated api * delete examples * remove old enrichment.json reference --------- Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com> * update the pattern for bookmark (#29100) * update bizapps (#29122) * update bizapps * Update BusinessApplicationAgents.json * update name for SDK * update resource name for SDK * update agentsystem * Sentinel-2024-04-01-preview-AdvancedAutomationRulesConditionsForIncidentLabels (#29246) Support automation rules with conditions on incident labels as a collection * Add suppressions for AvoidAdditionalProperties (#29278) * Update readme.md Add suppressions for data connector * Add suppressions * add suppressions (#29432) Co-authored-by: Offir Shvartz <ofshvart@microsoft.com> * Update dataConnectors.json (#29394) * update suffix to port (#29372) * Added x-ms-pageable and NextList to GetRecommendations (#29465) * Fix readonly and additionalProperties in OnDemand (#29595) * fix readonly and additionalProperties in OnDemand * update reason for suppressing AvoidAdditionalProperties * fix prettier * Fix Lro in OnDemand (#29603) * Fix Lro Error in OnDemand * fix prettier * updated settings file (#29658) * updated settings file * fix model issues * ran prettier * Update Entities Controllers Lint Exceptions (#29462) * Update EntityQueryTemplates.json * Update EntityQueries.json * Update Entities.json * Fix File Import Failures (#29515) * fix failures * add 200 response option * update from PR comments * Fileimports fix (#29733) * fix failures * add 200 response option * update from PR comments * update cloud error * Fileimports fix (#29786) * fix failures * add 200 response option * update from PR comments * update cloud error * update error response * update --------- Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com> * Remove EnvironmentVariable from Enum (#29949) * Watchlist fix lint failures (#30191) * Watchlist fix lint failures * fix lint * lint * provisioning states * lint again * model validation * update suppression format (#30252) * Dev sentinel securityinsights microsoft.security insights 2024 04 01 preview (#30302) * update suppression format * update ThreatIntelligenceQuery in the readme to suppress AvoidAdditionalProperties * Update readme.md (#30313) * adding comments to the readme file (#30316) * Update BusinessApplicationAgents.json * update readme to fix Lint Diff Error (#30340) * update readme to fix Lint Diff Error * fix format * remove ---- * fix line break * Revert "remove ----" This reverts commit d6842b5. * suppress the correct file (#30375) * update common-types/resource-management/v3/types.json to common-types/resource-management/v5/types.json to resolve Go-SDK issue (#30556) * TI Query small fixes (#30567) * Add blockchain to latest profile * Add additional types * Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview * Updates readme * Updates API version in new specs and examples * . * changes * . * . --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com> * update resource in common to v5 (#30570) * fix ModelValidationError (#30571) * fix go-sdk error (#30699) * fix go-sdk error * remove odata parameters in post --------- Co-authored-by: Dvir Naim <106969883+dvir-ms@users.noreply.github.com> Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com> Co-authored-by: Camilo Gonzalez <cgs.camilogonzalez@gmail.com> Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com> Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com> Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com> Co-authored-by: Offir Shvartz <offirsh@yahoo.com> Co-authored-by: Offir Shvartz <ofshvart@microsoft.com> Co-authored-by: Itiel Maimon <itiel.maimon@gmail.com> Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com> Co-authored-by: Vaspate <103540155+Vaspate@users.noreply.github.com> Co-authored-by: NoaGoren-Microsoft <160013798+NoaGoren-Microsoft@users.noreply.github.com> Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com> Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com> Co-authored-by: Rotem2dvir <rotemdvir@microsoft.com> Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.Note
As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.
PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Click here to see the details of Step 1, Breaking Changes review
If you are in purview of Step 1 of the diagram, follow the Breaking Changes review process.
IMPORTANT! This applies even if you believe your PR was mislabeled, for any reason, including tool failure.
Click here to see the details of Step 2, ARM review
See https://aka.ms/azsdk/pr-arm-review.
Click here to see the diagram footnotes
Diagram footnotes
[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.Next Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.