[Enrichment API] Remove deprecated api#29059
Merged
xuhumsft merged 3 commits intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-previewfrom May 14, 2024
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| default | default(c1c517a) | default(dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview) |
️❌Avocado: 2 Errors, 0 Warnings failed [Detail]
| Rule | Message |
|---|---|
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.SecurityInsights/enrichment/ip/geodata/ is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2024-01-01-preview/Enrichment.json |
|
The default tag should contain all APIs. The API path /subscriptions/{}/resourceGroups/{}/providers/Microsoft.SecurityInsights/enrichment/domain/whois/ is not in the default tag. Please make sure the missing API swaggers are in the default tag.readme: specification/securityinsights/resource-manager/readme.md json: Microsoft.SecurityInsights/preview/2024-01-01-preview/Enrichment.json |
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced May 10, 2024
camilo86
force-pushed
the
camilo/fix-enrichment-api
branch
from
9276ce7 to
756fbd9
Compare
camilo86
changed the title
xuhumsft
approved these changes
May 14, 2024
xuhumsft
merged commit cd00b0e
into
Azure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview
xuhumsft
added a commit
that referenced
this pull request
Sep 26, 2024
…preview (#28437) * Adds base for updating Microsoft.SecurityInsights from version preview/2024-01-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Release sentinel 2024 04 01 preview business applications agents (#28504) * businessApplicationAgents * prettier * businessApplicationAgents * add displayName to be required (#28720) * Add breaking changes from last stable version (#28904) * remove 4 values from enum (#28931) * [Enrichment API] Remove deprecated api (#29059) * remove deprecated api * delete examples * remove old enrichment.json reference --------- Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com> * update the pattern for bookmark (#29100) * update bizapps (#29122) * update bizapps * Update BusinessApplicationAgents.json * update name for SDK * update resource name for SDK * update agentsystem * Sentinel-2024-04-01-preview-AdvancedAutomationRulesConditionsForIncidentLabels (#29246) Support automation rules with conditions on incident labels as a collection * Add suppressions for AvoidAdditionalProperties (#29278) * Update readme.md Add suppressions for data connector * Add suppressions * add suppressions (#29432) Co-authored-by: Offir Shvartz <ofshvart@microsoft.com> * Update dataConnectors.json (#29394) * update suffix to port (#29372) * Added x-ms-pageable and NextList to GetRecommendations (#29465) * Fix readonly and additionalProperties in OnDemand (#29595) * fix readonly and additionalProperties in OnDemand * update reason for suppressing AvoidAdditionalProperties * fix prettier * Fix Lro in OnDemand (#29603) * Fix Lro Error in OnDemand * fix prettier * updated settings file (#29658) * updated settings file * fix model issues * ran prettier * Update Entities Controllers Lint Exceptions (#29462) * Update EntityQueryTemplates.json * Update EntityQueries.json * Update Entities.json * Fix File Import Failures (#29515) * fix failures * add 200 response option * update from PR comments * Fileimports fix (#29733) * fix failures * add 200 response option * update from PR comments * update cloud error * Fileimports fix (#29786) * fix failures * add 200 response option * update from PR comments * update cloud error * update error response * update --------- Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com> * Remove EnvironmentVariable from Enum (#29949) * Watchlist fix lint failures (#30191) * Watchlist fix lint failures * fix lint * lint * provisioning states * lint again * model validation * update suppression format (#30252) * Dev sentinel securityinsights microsoft.security insights 2024 04 01 preview (#30302) * update suppression format * update ThreatIntelligenceQuery in the readme to suppress AvoidAdditionalProperties * Update readme.md (#30313) * adding comments to the readme file (#30316) * Update BusinessApplicationAgents.json * update readme to fix Lint Diff Error (#30340) * update readme to fix Lint Diff Error * fix format * remove ---- * fix line break * Revert "remove ----" This reverts commit d6842b5. * suppress the correct file (#30375) * update common-types/resource-management/v3/types.json to common-types/resource-management/v5/types.json to resolve Go-SDK issue (#30556) * TI Query small fixes (#30567) * Add blockchain to latest profile * Add additional types * Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview * Updates readme * Updates API version in new specs and examples * . * changes * . * . --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com> * update resource in common to v5 (#30570) * fix ModelValidationError (#30571) * fix go-sdk error (#30699) * fix go-sdk error * remove odata parameters in post --------- Co-authored-by: Dvir Naim <106969883+dvir-ms@users.noreply.github.com> Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com> Co-authored-by: Camilo Gonzalez <cgs.camilogonzalez@gmail.com> Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com> Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com> Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com> Co-authored-by: Offir Shvartz <offirsh@yahoo.com> Co-authored-by: Offir Shvartz <ofshvart@microsoft.com> Co-authored-by: Itiel Maimon <itiel.maimon@gmail.com> Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com> Co-authored-by: Vaspate <103540155+Vaspate@users.noreply.github.com> Co-authored-by: NoaGoren-Microsoft <160013798+NoaGoren-Microsoft@users.noreply.github.com> Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com> Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com> Co-authored-by: Rotem2dvir <rotemdvir@microsoft.com> Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
cheukchuen
pushed a commit
that referenced
this pull request
Jan 24, 2025
…preview (#28437) * Adds base for updating Microsoft.SecurityInsights from version preview/2024-01-01-preview to version 2024-04-01-preview * Updates readme * Updates API version in new specs and examples * Release sentinel 2024 04 01 preview business applications agents (#28504) * businessApplicationAgents * prettier * businessApplicationAgents * add displayName to be required (#28720) * Add breaking changes from last stable version (#28904) * remove 4 values from enum (#28931) * [Enrichment API] Remove deprecated api (#29059) * remove deprecated api * delete examples * remove old enrichment.json reference --------- Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com> * update the pattern for bookmark (#29100) * update bizapps (#29122) * update bizapps * Update BusinessApplicationAgents.json * update name for SDK * update resource name for SDK * update agentsystem * Sentinel-2024-04-01-preview-AdvancedAutomationRulesConditionsForIncidentLabels (#29246) Support automation rules with conditions on incident labels as a collection * Add suppressions for AvoidAdditionalProperties (#29278) * Update readme.md Add suppressions for data connector * Add suppressions * add suppressions (#29432) Co-authored-by: Offir Shvartz <ofshvart@microsoft.com> * Update dataConnectors.json (#29394) * update suffix to port (#29372) * Added x-ms-pageable and NextList to GetRecommendations (#29465) * Fix readonly and additionalProperties in OnDemand (#29595) * fix readonly and additionalProperties in OnDemand * update reason for suppressing AvoidAdditionalProperties * fix prettier * Fix Lro in OnDemand (#29603) * Fix Lro Error in OnDemand * fix prettier * updated settings file (#29658) * updated settings file * fix model issues * ran prettier * Update Entities Controllers Lint Exceptions (#29462) * Update EntityQueryTemplates.json * Update EntityQueries.json * Update Entities.json * Fix File Import Failures (#29515) * fix failures * add 200 response option * update from PR comments * Fileimports fix (#29733) * fix failures * add 200 response option * update from PR comments * update cloud error * Fileimports fix (#29786) * fix failures * add 200 response option * update from PR comments * update cloud error * update error response * update --------- Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com> * Remove EnvironmentVariable from Enum (#29949) * Watchlist fix lint failures (#30191) * Watchlist fix lint failures * fix lint * lint * provisioning states * lint again * model validation * update suppression format (#30252) * Dev sentinel securityinsights microsoft.security insights 2024 04 01 preview (#30302) * update suppression format * update ThreatIntelligenceQuery in the readme to suppress AvoidAdditionalProperties * Update readme.md (#30313) * adding comments to the readme file (#30316) * Update BusinessApplicationAgents.json * update readme to fix Lint Diff Error (#30340) * update readme to fix Lint Diff Error * fix format * remove ---- * fix line break * Revert "remove ----" This reverts commit d6842b5. * suppress the correct file (#30375) * update common-types/resource-management/v3/types.json to common-types/resource-management/v5/types.json to resolve Go-SDK issue (#30556) * TI Query small fixes (#30567) * Add blockchain to latest profile * Add additional types * Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview * Updates readme * Updates API version in new specs and examples * . * changes * . * . --------- Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com> * update resource in common to v5 (#30570) * fix ModelValidationError (#30571) * fix go-sdk error (#30699) * fix go-sdk error * remove odata parameters in post --------- Co-authored-by: Dvir Naim <106969883+dvir-ms@users.noreply.github.com> Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com> Co-authored-by: Camilo Gonzalez <cgs.camilogonzalez@gmail.com> Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com> Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com> Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com> Co-authored-by: Offir Shvartz <offirsh@yahoo.com> Co-authored-by: Offir Shvartz <ofshvart@microsoft.com> Co-authored-by: Itiel Maimon <itiel.maimon@gmail.com> Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com> Co-authored-by: Vaspate <103540155+Vaspate@users.noreply.github.com> Co-authored-by: NoaGoren-Microsoft <160013798+NoaGoren-Microsoft@users.noreply.github.com> Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com> Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com> Co-authored-by: Rotem2dvir <rotemdvir@microsoft.com> Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com> Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com> Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.