Skip to content

update common-types/resource-management/v3/types.json to common-types…#30556

Merged
xuhumsft merged 1 commit intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-previewfrom
xuhumsft:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview
Sep 13, 2024
Merged

update common-types/resource-management/v3/types.json to common-types…#30556
xuhumsft merged 1 commit intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-previewfrom
xuhumsft:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview

Conversation

@xuhumsft
Copy link
Member

…/resource-management/v5/types.json to resolve Go-SDK issue

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

…/resource-management/v5/types.json to resolve Go-SDK issue
@xuhumsft xuhumsft merged commit f77928e into Azure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview Sep 13, 2024
xuhumsft added a commit that referenced this pull request Sep 26, 2024
…preview (#28437)

* Adds base for updating Microsoft.SecurityInsights from version preview/2024-01-01-preview to version 2024-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Release sentinel 2024 04 01 preview business applications agents (#28504)

* businessApplicationAgents

* prettier

* businessApplicationAgents

* add displayName to be required (#28720)

* Add breaking changes from last stable version (#28904)

* remove 4 values from enum (#28931)

* [Enrichment API] Remove deprecated api (#29059)

* remove deprecated api

* delete examples

* remove old enrichment.json reference

---------

Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com>

* update the pattern for bookmark (#29100)

* update bizapps (#29122)

* update bizapps

* Update BusinessApplicationAgents.json

* update name for SDK

* update resource name for SDK

* update agentsystem

* Sentinel-2024-04-01-preview-AdvancedAutomationRulesConditionsForIncidentLabels (#29246)

Support automation rules with conditions on incident labels as a collection

* Add suppressions for AvoidAdditionalProperties  (#29278)

* Update readme.md

Add suppressions for data connector

* Add suppressions

* add suppressions (#29432)

Co-authored-by: Offir Shvartz <ofshvart@microsoft.com>

* Update dataConnectors.json (#29394)

* update suffix to port (#29372)

* Added x-ms-pageable and NextList to GetRecommendations (#29465)

* Fix readonly and additionalProperties in OnDemand (#29595)

* fix readonly and additionalProperties in OnDemand

* update reason for suppressing AvoidAdditionalProperties

* fix prettier

* Fix Lro in OnDemand (#29603)

* Fix Lro Error in OnDemand

* fix prettier

* updated settings file (#29658)

* updated settings file

* fix model issues

* ran prettier

* Update Entities Controllers Lint Exceptions (#29462)

* Update EntityQueryTemplates.json

* Update EntityQueries.json

* Update Entities.json

* Fix File Import Failures (#29515)

* fix failures

* add 200 response option

* update from PR comments

* Fileimports fix (#29733)

* fix failures

* add 200 response option

* update from PR comments

* update cloud error

* Fileimports fix (#29786)

* fix failures

* add 200 response option

* update from PR comments

* update cloud error

* update error response

* update

---------

Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>

* Remove EnvironmentVariable from Enum (#29949)

* Watchlist fix lint failures (#30191)

* Watchlist fix lint failures

* fix lint

* lint

* provisioning states

* lint again

* model validation

* update suppression format (#30252)

* Dev sentinel securityinsights microsoft.security insights 2024 04 01 preview (#30302)

* update suppression format

* update ThreatIntelligenceQuery in the readme to suppress AvoidAdditionalProperties

* Update readme.md (#30313)

* adding comments to the readme file (#30316)

* Update BusinessApplicationAgents.json

* update readme to fix Lint Diff Error (#30340)

* update readme to fix Lint Diff Error

* fix format

* remove ----

* fix line break

* Revert "remove ----"

This reverts commit d6842b5.

* suppress the correct file (#30375)

* update common-types/resource-management/v3/types.json to common-types/resource-management/v5/types.json to resolve Go-SDK issue (#30556)

* TI Query small fixes (#30567)

* Add blockchain to latest profile

* Add additional types

* Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview

* Updates readme

* Updates API version in new specs and examples

* .

* changes

* .

* .

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>

* update resource in common to v5 (#30570)

* fix ModelValidationError (#30571)

* fix go-sdk error (#30699)

* fix go-sdk error

* remove odata parameters in post

---------

Co-authored-by: Dvir Naim <106969883+dvir-ms@users.noreply.github.com>
Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com>
Co-authored-by: Camilo Gonzalez <cgs.camilogonzalez@gmail.com>
Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com>
Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
Co-authored-by: Offir Shvartz <offirsh@yahoo.com>
Co-authored-by: Offir Shvartz <ofshvart@microsoft.com>
Co-authored-by: Itiel Maimon <itiel.maimon@gmail.com>
Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: Vaspate <103540155+Vaspate@users.noreply.github.com>
Co-authored-by: NoaGoren-Microsoft <160013798+NoaGoren-Microsoft@users.noreply.github.com>
Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com>
Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com>
Co-authored-by: Rotem2dvir <rotemdvir@microsoft.com>
Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
…preview (#28437)

* Adds base for updating Microsoft.SecurityInsights from version preview/2024-01-01-preview to version 2024-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Release sentinel 2024 04 01 preview business applications agents (#28504)

* businessApplicationAgents

* prettier

* businessApplicationAgents

* add displayName to be required (#28720)

* Add breaking changes from last stable version (#28904)

* remove 4 values from enum (#28931)

* [Enrichment API] Remove deprecated api (#29059)

* remove deprecated api

* delete examples

* remove old enrichment.json reference

---------

Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com>

* update the pattern for bookmark (#29100)

* update bizapps (#29122)

* update bizapps

* Update BusinessApplicationAgents.json

* update name for SDK

* update resource name for SDK

* update agentsystem

* Sentinel-2024-04-01-preview-AdvancedAutomationRulesConditionsForIncidentLabels (#29246)

Support automation rules with conditions on incident labels as a collection

* Add suppressions for AvoidAdditionalProperties  (#29278)

* Update readme.md

Add suppressions for data connector

* Add suppressions

* add suppressions (#29432)

Co-authored-by: Offir Shvartz <ofshvart@microsoft.com>

* Update dataConnectors.json (#29394)

* update suffix to port (#29372)

* Added x-ms-pageable and NextList to GetRecommendations (#29465)

* Fix readonly and additionalProperties in OnDemand (#29595)

* fix readonly and additionalProperties in OnDemand

* update reason for suppressing AvoidAdditionalProperties

* fix prettier

* Fix Lro in OnDemand (#29603)

* Fix Lro Error in OnDemand

* fix prettier

* updated settings file (#29658)

* updated settings file

* fix model issues

* ran prettier

* Update Entities Controllers Lint Exceptions (#29462)

* Update EntityQueryTemplates.json

* Update EntityQueries.json

* Update Entities.json

* Fix File Import Failures (#29515)

* fix failures

* add 200 response option

* update from PR comments

* Fileimports fix (#29733)

* fix failures

* add 200 response option

* update from PR comments

* update cloud error

* Fileimports fix (#29786)

* fix failures

* add 200 response option

* update from PR comments

* update cloud error

* update error response

* update

---------

Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>

* Remove EnvironmentVariable from Enum (#29949)

* Watchlist fix lint failures (#30191)

* Watchlist fix lint failures

* fix lint

* lint

* provisioning states

* lint again

* model validation

* update suppression format (#30252)

* Dev sentinel securityinsights microsoft.security insights 2024 04 01 preview (#30302)

* update suppression format

* update ThreatIntelligenceQuery in the readme to suppress AvoidAdditionalProperties

* Update readme.md (#30313)

* adding comments to the readme file (#30316)

* Update BusinessApplicationAgents.json

* update readme to fix Lint Diff Error (#30340)

* update readme to fix Lint Diff Error

* fix format

* remove ----

* fix line break

* Revert "remove ----"

This reverts commit d6842b5.

* suppress the correct file (#30375)

* update common-types/resource-management/v3/types.json to common-types/resource-management/v5/types.json to resolve Go-SDK issue (#30556)

* TI Query small fixes (#30567)

* Add blockchain to latest profile

* Add additional types

* Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview

* Updates readme

* Updates API version in new specs and examples

* .

* changes

* .

* .

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>

* update resource in common to v5 (#30570)

* fix ModelValidationError (#30571)

* fix go-sdk error (#30699)

* fix go-sdk error

* remove odata parameters in post

---------

Co-authored-by: Dvir Naim <106969883+dvir-ms@users.noreply.github.com>
Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com>
Co-authored-by: Camilo Gonzalez <cgs.camilogonzalez@gmail.com>
Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com>
Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
Co-authored-by: Offir Shvartz <offirsh@yahoo.com>
Co-authored-by: Offir Shvartz <ofshvart@microsoft.com>
Co-authored-by: Itiel Maimon <itiel.maimon@gmail.com>
Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: Vaspate <103540155+Vaspate@users.noreply.github.com>
Co-authored-by: NoaGoren-Microsoft <160013798+NoaGoren-Microsoft@users.noreply.github.com>
Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com>
Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com>
Co-authored-by: Rotem2dvir <rotemdvir@microsoft.com>
Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant