Dev sentinel securityinsights microsoft.security insights 2024 09 01 by xuhumsft · Pull Request #30800 · Azure/azure-rest-api-specs

xuhumsft · 2024-09-30T18:09:49Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Updated the API version from stable/2024-03-01 to stable/2024-09-01.

openapi-pipeline-app · 2024-09-30T18:09:53Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

openapi-pipeline-app · 2024-09-30T18:09:53Z

Generated ApiView

Language	Package Name	ApiView Link
Go	sdk/resourcemanager/securityinsights/armsecurityinsights	https://apiview.dev/Assemblies/Review/06b0c4a98e094807b7c161c14692f77d?revisionId=c7ed5e67911741ddb0ad1c04f0ab131c
Python	azure-mgmt-securityinsight	https://apiview.dev/Assemblies/Review/36adc9563fba4ee0a3c59bc34463bf0a?revisionId=843808d7e3de44fea9290c954f57059c

rkmanda · 2024-10-05T04:23:10Z

Fix the errors here or add a suppression adding a reasoning for why you cant fix it

https://github.com/Azure/azure-rest-api-specs/pull/30800/checks?check_run_id=30872281352

https://github.com/Azure/autorest/blob/main/docs/generate/suppress-warnings.md

azure-pipelines · 2024-11-15T01:40:22Z

Azure Pipelines successfully started running 3 pipeline(s).

azure-sdk · 2024-11-15T01:43:00Z

API change check

APIView has identified API level changes in this PR and created following API reviews.

common

sagamzu · 2024-11-17T09:28:51Z

@razvanbadea-msft I fixed the typo, string format and V3 comments.
#31581

The rest (like enum, additonalPropertyValidation..) reviewed during the Preview version.

We had a long discussion therewith ARM team... I joined a few ARM meetings, discuss with PMs and the API approved by ARM.
This version is exactly the same definition as we have in Preview version and we want to have the same API (This API is in GA already for a few month with the preview definition)

if you need more explanation let me know, and i will join to ARM meeting

…31581)

* fix prettier check * mdti stable swagger * pmdti stable swagger * fix example name * fix pmdti swagger * add pmdti examples * fix spellcheck * fix enums * prettier fix * update lookback * lookback period for pmdti * fix date-time format in examples * minor format fix --------- Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>

…zure#30800) * Copy files from stable/2024-03-01 Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec. * Update version to stable/2024-09-01 Updated the API version from stable/2024-03-01 to stable/2024-09-01. * Added tag for 2024-09-01 in readme file * fix validation error * fix lint diff error - rleationTypes * suppress addtional properties in alertRules * update the common type version to resolve go-sdk error * fix prettier error * fix the model validation error * fix the prettier error * Watchlists 2024-09-01 (Azure#31040) * Watchlists 2024-09-01 * Fix errors * prettier run * address pr feedback * address pr feedback * Add stable version for Connectordefinitions API (Azure#30812) * add stable version for definition API * update readme file * update readme file * update cSpell * Create sdk-suppressions.yaml --------- Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> * Add new kind (RestApiPoller) to DataConnectors STABLE API (Azure#30813) * add restApiPoller kind to dataConnectors * exe prettier * fix prettier check (Azure#31449) * Update readme.python.md * Update sdk-suppressions.yaml * Fix some typos in DataConnectors and DataConnectorDefinitions APIs (Azure#31581) * Update sdk-suppressions.yaml * DataConnectors - MDTI and PMDTI connectors 2024-09-01 (Azure#31491) * fix prettier check * mdti stable swagger * pmdti stable swagger * fix example name * fix pmdti swagger * add pmdti examples * fix spellcheck * fix enums * prettier fix * update lookback * lookback period for pmdti * fix date-time format in examples * minor format fix --------- Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com> --------- Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com> Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com> Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn> Co-authored-by: ni-bhandari <120053375+ni-bhandari@users.noreply.github.com>

xuhumsft added 3 commits September 26, 2024 14:59

Copy files from stable/2024-03-01

6f5234f

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Update version to stable/2024-09-01

60dfcd8

Updated the API version from stable/2024-03-01 to stable/2024-09-01.

Added tag for 2024-09-01 in readme file

10c0b73

xuhumsft added NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR NotReadyForARMReview DoNotMerge <valid label in PR review process> use to hold merge after approval labels Sep 30, 2024

azure-sdk mentioned this pull request Sep 30, 2024

[AutoPR Azure.ResourceManager.SecurityInsights] Dev sentinel securityinsights microsoft.security insights 2024 09 01 azure-sdk/azure-sdk-for-net#9375

Closed

AzureRestAPISpecReview added ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Sep 30, 2024

azure-sdk added the BreakingChange-Python-Sdk label Sep 30, 2024

azure-sdk mentioned this pull request Sep 30, 2024

[AutoPR azure-mgmt-securityinsight] Dev sentinel securityinsights microsoft.security insights 2024 09 01 azure-sdk/azure-sdk-for-python#8916

Closed

rkmanda removed the NotReadyForReview <valid label in PR review process>It is in draft for swagger or not swagger PR label Oct 5, 2024

rkmanda added the ARMChangesRequested label Oct 5, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 5, 2024

xuhumsft added 3 commits October 8, 2024 10:44

fix validation error

0eb81a5

fix lint diff error - rleationTypes

a7dccba

suppress addtional properties in alertRules

e3d2e0e

AzureRestAPISpecReview added BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed ARMChangesRequested labels Oct 8, 2024

openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 8, 2024

update the common type version to resolve go-sdk error

8c2ad6b

azure-sdk added the BreakingChange-Python-Sdk label Nov 15, 2024

Update sdk-suppressions.yaml

a2c3cdd

azure-sdk removed the BreakingChange-Python-Sdk label Nov 15, 2024

Fix some typos in DataConnectors and DataConnectorDefinitions APIs (#…

43037b8

…31581)

sagamzu added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Nov 17, 2024

ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Nov 18, 2024

openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 18, 2024

msyyc added the BreakingChange-Python-Sdk-Suppression-Approved label Nov 19, 2024

Update sdk-suppressions.yaml

73b2f92

openapi-pipeline-app bot added the BreakingChange-Go-Sdk-Suppression label Nov 20, 2024

tadelesh added BreakingChange-Go-Sdk-Suppression-Approved BreakingChange-Go-Sdk-Suppression and removed BreakingChange-Go-Sdk-Suppression labels Nov 20, 2024

azure-sdk removed the BreakingChange-Go-Sdk label Nov 20, 2024

xuhumsft added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Nov 20, 2024

ni-bhandari approved these changes Nov 20, 2024

View reviewed changes

xuhumsft merged commit 52543df into main Nov 20, 2024

xuhumsft deleted the dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-09-01 branch November 20, 2024 19:07

xuhumsft mentioned this pull request Feb 24, 2025

Dev sentinel securityinsights microsoft.security insights 2025 03 01 #32680

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev sentinel securityinsights microsoft.security insights 2024 09 01#30800

Dev sentinel securityinsights microsoft.security insights 2024 09 01#30800
xuhumsft merged 19 commits intomainfrom
dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-09-01

xuhumsft commented Sep 30, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Sep 30, 2024 •

edited

Loading

Uh oh!

rkmanda commented Oct 5, 2024

Uh oh!

azure-pipelines bot commented Nov 15, 2024

Uh oh!

azure-sdk commented Nov 15, 2024

Uh oh!

sagamzu commented Nov 17, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

xuhumsft commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

openapi-pipeline-app bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

openapi-pipeline-app bot commented Sep 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

rkmanda commented Oct 5, 2024

Uh oh!

azure-pipelines bot commented Nov 15, 2024

Uh oh!

azure-sdk commented Nov 15, 2024

Uh oh!

sagamzu commented Nov 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

xuhumsft commented Sep 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 30, 2024 •

edited

Loading

openapi-pipeline-app bot commented Sep 30, 2024 •

edited

Loading

sagamzu commented Nov 17, 2024 •

edited

Loading