Skip to content

Fix Lro in OnDemand#29603

Merged
xuhumsft merged 2 commits intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-previewfrom
laithhisham:feature/lahisham/firLroErrorInOnDemand
Jun 28, 2024
Merged

Fix Lro in OnDemand#29603
xuhumsft merged 2 commits intoAzure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-previewfrom
laithhisham:feature/lahisham/firLroErrorInOnDemand

Conversation

@laithhisham
Copy link
Contributor

Fix Lro in OnDemand

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 27, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 27, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️⚠️Breaking Change(Cross-Version): 4 Warnings warning [Detail]
Compared specs (v0.10.12) new version base version
TriggeredAnalyticsRuleRuns.json 2024-04-01-preview(33d962d) 2024-01-01-preview(main)

The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L150:13
Old: Microsoft.SecurityInsights/preview/2024-01-01-preview/TriggeredAnalyticsRuleRuns.json#L150:13
⚠️ 1017 - ReferenceRedirection The '$ref' property points to different models in the old and new versions.
New: common-types/resource-management/v5/types.json#L307:9
Old: resource-manager/common/2.0/types.json#L77:9
⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L240:9
Old: Microsoft.SecurityInsights/preview/2024-01-01-preview/TriggeredAnalyticsRuleRuns.json#L239:9
⚠️ 1029 - ReadonlyPropertyChanged The read only property has changed from 'false' to 'true'.
New: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L168:5
Old: Microsoft.SecurityInsights/preview/2024-01-01-preview/TriggeredAnalyticsRuleRuns.json#L168:5
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-04 package-preview-2024-04(33d962d) package-preview-2024-04(dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview)

The following errors/warnings exist before current PR submission:

Rule Message
AvoidAdditionalProperties Definitions must not have properties named additionalProperties except for user defined tags or predefined references.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L243
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L21
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L24
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L37
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L61
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L73
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L76
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L82
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L121
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L124
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.SecurityInsights/preview/2024-04-01-preview/TriggeredAnalyticsRuleRuns.json#L127
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 27, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️⚠️ azure-sdk-for-net-track2 warning [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-go failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-sdk-for-python-track2 failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️🔄 azure-sdk-for-js inProgress [Detail]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-resource-manager-schemas failed [Detail]

Only 0 items are rendered, please refer to log for more details.

️❌ azure-powershell failed [Detail]

Only 0 items are rendered, please refer to log for more details.

Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 27, 2024

Generated ApiView

Language Package Name ApiView Link
Java azure-resourcemanager-securityinsights https://apiview.dev/Assemblies/Review/94d98f0a635f4ee98bd2349d9b276a14?revisionId=bb11d4ed7b224d80a5eba98667d0bf67
.Net Azure.ResourceManager.SecurityInsights There is no API change compared with the previous version
Swagger Microsoft.SecurityInsights https://apiview.dev/Assemblies/Review/d30cc3bd7c484ad880bc3b8126f67ba5?revisionId=306070adf34b4e62b0e8cc14addad5ac

@xuhumsft xuhumsft merged commit 674d152 into Azure:dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2024-04-01-preview Jun 28, 2024
xuhumsft added a commit that referenced this pull request Sep 26, 2024
…preview (#28437)

* Adds base for updating Microsoft.SecurityInsights from version preview/2024-01-01-preview to version 2024-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Release sentinel 2024 04 01 preview business applications agents (#28504)

* businessApplicationAgents

* prettier

* businessApplicationAgents

* add displayName to be required (#28720)

* Add breaking changes from last stable version (#28904)

* remove 4 values from enum (#28931)

* [Enrichment API] Remove deprecated api (#29059)

* remove deprecated api

* delete examples

* remove old enrichment.json reference

---------

Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com>

* update the pattern for bookmark (#29100)

* update bizapps (#29122)

* update bizapps

* Update BusinessApplicationAgents.json

* update name for SDK

* update resource name for SDK

* update agentsystem

* Sentinel-2024-04-01-preview-AdvancedAutomationRulesConditionsForIncidentLabels (#29246)

Support automation rules with conditions on incident labels as a collection

* Add suppressions for AvoidAdditionalProperties  (#29278)

* Update readme.md

Add suppressions for data connector

* Add suppressions

* add suppressions (#29432)

Co-authored-by: Offir Shvartz <ofshvart@microsoft.com>

* Update dataConnectors.json (#29394)

* update suffix to port (#29372)

* Added x-ms-pageable and NextList to GetRecommendations (#29465)

* Fix readonly and additionalProperties in OnDemand (#29595)

* fix readonly and additionalProperties in OnDemand

* update reason for suppressing AvoidAdditionalProperties

* fix prettier

* Fix Lro in OnDemand (#29603)

* Fix Lro Error in OnDemand

* fix prettier

* updated settings file (#29658)

* updated settings file

* fix model issues

* ran prettier

* Update Entities Controllers Lint Exceptions (#29462)

* Update EntityQueryTemplates.json

* Update EntityQueries.json

* Update Entities.json

* Fix File Import Failures (#29515)

* fix failures

* add 200 response option

* update from PR comments

* Fileimports fix (#29733)

* fix failures

* add 200 response option

* update from PR comments

* update cloud error

* Fileimports fix (#29786)

* fix failures

* add 200 response option

* update from PR comments

* update cloud error

* update error response

* update

---------

Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>

* Remove EnvironmentVariable from Enum (#29949)

* Watchlist fix lint failures (#30191)

* Watchlist fix lint failures

* fix lint

* lint

* provisioning states

* lint again

* model validation

* update suppression format (#30252)

* Dev sentinel securityinsights microsoft.security insights 2024 04 01 preview (#30302)

* update suppression format

* update ThreatIntelligenceQuery in the readme to suppress AvoidAdditionalProperties

* Update readme.md (#30313)

* adding comments to the readme file (#30316)

* Update BusinessApplicationAgents.json

* update readme to fix Lint Diff Error (#30340)

* update readme to fix Lint Diff Error

* fix format

* remove ----

* fix line break

* Revert "remove ----"

This reverts commit d6842b5.

* suppress the correct file (#30375)

* update common-types/resource-management/v3/types.json to common-types/resource-management/v5/types.json to resolve Go-SDK issue (#30556)

* TI Query small fixes (#30567)

* Add blockchain to latest profile

* Add additional types

* Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview

* Updates readme

* Updates API version in new specs and examples

* .

* changes

* .

* .

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>

* update resource in common to v5 (#30570)

* fix ModelValidationError (#30571)

* fix go-sdk error (#30699)

* fix go-sdk error

* remove odata parameters in post

---------

Co-authored-by: Dvir Naim <106969883+dvir-ms@users.noreply.github.com>
Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com>
Co-authored-by: Camilo Gonzalez <cgs.camilogonzalez@gmail.com>
Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com>
Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
Co-authored-by: Offir Shvartz <offirsh@yahoo.com>
Co-authored-by: Offir Shvartz <ofshvart@microsoft.com>
Co-authored-by: Itiel Maimon <itiel.maimon@gmail.com>
Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: Vaspate <103540155+Vaspate@users.noreply.github.com>
Co-authored-by: NoaGoren-Microsoft <160013798+NoaGoren-Microsoft@users.noreply.github.com>
Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com>
Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com>
Co-authored-by: Rotem2dvir <rotemdvir@microsoft.com>
Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
…preview (#28437)

* Adds base for updating Microsoft.SecurityInsights from version preview/2024-01-01-preview to version 2024-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* Release sentinel 2024 04 01 preview business applications agents (#28504)

* businessApplicationAgents

* prettier

* businessApplicationAgents

* add displayName to be required (#28720)

* Add breaking changes from last stable version (#28904)

* remove 4 values from enum (#28931)

* [Enrichment API] Remove deprecated api (#29059)

* remove deprecated api

* delete examples

* remove old enrichment.json reference

---------

Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com>

* update the pattern for bookmark (#29100)

* update bizapps (#29122)

* update bizapps

* Update BusinessApplicationAgents.json

* update name for SDK

* update resource name for SDK

* update agentsystem

* Sentinel-2024-04-01-preview-AdvancedAutomationRulesConditionsForIncidentLabels (#29246)

Support automation rules with conditions on incident labels as a collection

* Add suppressions for AvoidAdditionalProperties  (#29278)

* Update readme.md

Add suppressions for data connector

* Add suppressions

* add suppressions (#29432)

Co-authored-by: Offir Shvartz <ofshvart@microsoft.com>

* Update dataConnectors.json (#29394)

* update suffix to port (#29372)

* Added x-ms-pageable and NextList to GetRecommendations (#29465)

* Fix readonly and additionalProperties in OnDemand (#29595)

* fix readonly and additionalProperties in OnDemand

* update reason for suppressing AvoidAdditionalProperties

* fix prettier

* Fix Lro in OnDemand (#29603)

* Fix Lro Error in OnDemand

* fix prettier

* updated settings file (#29658)

* updated settings file

* fix model issues

* ran prettier

* Update Entities Controllers Lint Exceptions (#29462)

* Update EntityQueryTemplates.json

* Update EntityQueries.json

* Update Entities.json

* Fix File Import Failures (#29515)

* fix failures

* add 200 response option

* update from PR comments

* Fileimports fix (#29733)

* fix failures

* add 200 response option

* update from PR comments

* update cloud error

* Fileimports fix (#29786)

* fix failures

* add 200 response option

* update from PR comments

* update cloud error

* update error response

* update

---------

Co-authored-by: xuhumsft <116764429+xuhumsft@users.noreply.github.com>

* Remove EnvironmentVariable from Enum (#29949)

* Watchlist fix lint failures (#30191)

* Watchlist fix lint failures

* fix lint

* lint

* provisioning states

* lint again

* model validation

* update suppression format (#30252)

* Dev sentinel securityinsights microsoft.security insights 2024 04 01 preview (#30302)

* update suppression format

* update ThreatIntelligenceQuery in the readme to suppress AvoidAdditionalProperties

* Update readme.md (#30313)

* adding comments to the readme file (#30316)

* Update BusinessApplicationAgents.json

* update readme to fix Lint Diff Error (#30340)

* update readme to fix Lint Diff Error

* fix format

* remove ----

* fix line break

* Revert "remove ----"

This reverts commit d6842b5.

* suppress the correct file (#30375)

* update common-types/resource-management/v3/types.json to common-types/resource-management/v5/types.json to resolve Go-SDK issue (#30556)

* TI Query small fixes (#30567)

* Add blockchain to latest profile

* Add additional types

* Adds base for updating Microsoft.SecurityInsights from version preview/2022-04-01-preview to version 2022-05-01-preview

* Updates readme

* Updates API version in new specs and examples

* .

* changes

* .

* .

---------

Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>

* update resource in common to v5 (#30570)

* fix ModelValidationError (#30571)

* fix go-sdk error (#30699)

* fix go-sdk error

* remove odata parameters in post

---------

Co-authored-by: Dvir Naim <106969883+dvir-ms@users.noreply.github.com>
Co-authored-by: ityankel <47292630+ityankel@users.noreply.github.com>
Co-authored-by: Camilo Gonzalez <cgs.camilogonzalez@gmail.com>
Co-authored-by: Camilo Gonzalez Tabares <camilog@microsoft.com>
Co-authored-by: loriatarms <105870291+loriatarms@users.noreply.github.com>
Co-authored-by: sagamzu <52034287+sagamzu@users.noreply.github.com>
Co-authored-by: Offir Shvartz <offirsh@yahoo.com>
Co-authored-by: Offir Shvartz <ofshvart@microsoft.com>
Co-authored-by: Itiel Maimon <itiel.maimon@gmail.com>
Co-authored-by: Laith Hisham <49263932+laithhisham@users.noreply.github.com>
Co-authored-by: Vaspate <103540155+Vaspate@users.noreply.github.com>
Co-authored-by: NoaGoren-Microsoft <160013798+NoaGoren-Microsoft@users.noreply.github.com>
Co-authored-by: rheabansal <93624991+rheabansal@users.noreply.github.com>
Co-authored-by: nbatyrbb <115049492+nbatyrbb@users.noreply.github.com>
Co-authored-by: Rotem2dvir <rotemdvir@microsoft.com>
Co-authored-by: moranraz <59017169+moranraz@users.noreply.github.com>
Co-authored-by: Mark Cowlishaw <markcowl@microsoft.com>
Co-authored-by: Anat Gilenson <53407600+anat-gilenson@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants