Skip to content

Dev sentinel securityinsights microsoft.security insights 2025 04 01 preview#33317

Merged
xuhumsft merged 11 commits intomainfrom
dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-04-01-preview
May 1, 2025
Merged

Dev sentinel securityinsights microsoft.security insights 2025 04 01 preview#33317
xuhumsft merged 11 commits intomainfrom
dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-04-01-preview

Conversation

@xuhumsft
Copy link
Member

@xuhumsft xuhumsft commented Mar 19, 2025

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

xuhumsft and others added 6 commits March 11, 2025 11:24
Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.
Updated the API version from preview/2025-01-01-preview to preview/2025-04-01-preview.
Co-authored-by: SentinelEcoDevs <sentinelecodevs@microsoft.com>
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 19, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Mar 19, 2025

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@github-actions github-actions bot added the brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. label Mar 19, 2025
@azure-sdk
Copy link
Collaborator

azure-sdk commented Mar 19, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger common

@AzureRestAPISpecReview AzureRestAPISpecReview removed the VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required label Apr 28, 2025
@gary-x-li gary-x-li added Approved-Avocado ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review labels Apr 28, 2025
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Apr 28, 2025
@xuhumsft
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

@xuhumsft xuhumsft added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label May 1, 2025
@xuhumsft xuhumsft merged commit c1e9dcd into main May 1, 2025
85 of 92 checks passed
@xuhumsft xuhumsft deleted the dev-Sentinel-securityinsights-Microsoft.SecurityInsights-2025-04-01-preview branch May 1, 2025 18:31
koen-mertens pushed a commit to koen-mertens/azure-rest-api-specs that referenced this pull request May 7, 2025
…preview (Azure#33317)

* Copy files from preview/2025-01-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-04-01-preview

Updated the API version from preview/2025-01-01-preview to preview/2025-04-01-preview.

* Added tag for 2025-04-01-preview in readme file

* fix the tag error generated by the script

* fix the prettier issue generated by the script

* add CustomData metadataKind (Azure#33292)

Co-authored-by: SentinelEcoDevs <sentinelecodevs@microsoft.com>

* add suppressions (Azure#33527)

* fix indentation (Azure#33548)

* suppression (Azure#33695)

* update the old version to resolve the MISSING_APIS_IN_DEFAULT_TAG issue (Azure#34261)

* Revert "update the old version to resolve the MISSING_APIS_IN_DEFAULT_TAG issue (Azure#34261)" (Azure#34280)

This reverts commit d0357f6.

---------

Co-authored-by: coled-ms <coled@microsoft.com>
Co-authored-by: SentinelEcoDevs <sentinelecodevs@microsoft.com>
nwnt pushed a commit to nwnt/azure-rest-api-specs that referenced this pull request Jun 10, 2025
…preview (Azure#33317)

* Copy files from preview/2025-01-01-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2025-04-01-preview

Updated the API version from preview/2025-01-01-preview to preview/2025-04-01-preview.

* Added tag for 2025-04-01-preview in readme file

* fix the tag error generated by the script

* fix the prettier issue generated by the script

* add CustomData metadataKind (Azure#33292)

Co-authored-by: SentinelEcoDevs <sentinelecodevs@microsoft.com>

* add suppressions (Azure#33527)

* fix indentation (Azure#33548)

* suppression (Azure#33695)

* update the old version to resolve the MISSING_APIS_IN_DEFAULT_TAG issue (Azure#34261)

* Revert "update the old version to resolve the MISSING_APIS_IN_DEFAULT_TAG issue (Azure#34261)" (Azure#34280)

This reverts commit d0357f6.

---------

Co-authored-by: coled-ms <coled@microsoft.com>
Co-authored-by: SentinelEcoDevs <sentinelecodevs@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Avocado Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. new-api-version PipelineBotTrigger PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants