Skip to content

Dropped private access code#1486

Merged
balajikris merged 1 commit intoAzure:currentfrom
EvgenyAgafonchikov:drop-private-access
Jul 31, 2017
Merged

Dropped private access code#1486
balajikris merged 1 commit intoAzure:currentfrom
EvgenyAgafonchikov:drop-private-access

Conversation

@EvgenyAgafonchikov
Copy link
Copy Markdown
Contributor

@EvgenyAgafonchikov EvgenyAgafonchikov commented Jul 28, 2017

Removing private access feature by request; Contact @DeepakRajendranMsft for details.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 84
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@azuresdkciprbot
Copy link
Copy Markdown

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 84
After the PR: Warning(s): 151 Error(s): 83

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@balajikris
Copy link
Copy Markdown
Contributor

change looks straight forward - all deletes. If SDKs were shipped with this service, make sure to follow procedures for rolling out breaking changes to SDKs, CLIs and PS.

@balajikris
Copy link
Copy Markdown
Contributor

@balajikris balajikris merged commit 53b26d1 into Azure:current Jul 31, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

@EvgenyAgafonchikov EvgenyAgafonchikov deleted the drop-private-access branch May 15, 2019 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants