Skip to content

feat: optionally disable publishing L1 txs#17326

Merged
alexghr merged 1 commit intonextfrom
ag/disable-publishing
Sep 30, 2025
Merged

feat: optionally disable publishing L1 txs#17326
alexghr merged 1 commit intonextfrom
ag/disable-publishing

Conversation

@alexghr
Copy link
Contributor

@alexghr alexghr commented Sep 26, 2025

This PR adds the option to disable publishing L1 txs from the prover/sequencer

Fix A-6

@alexghr alexghr force-pushed the ag/disable-publishing branch 2 times, most recently from ea2329f to 52a14c2 Compare September 26, 2025 12:30
@alexghr alexghr mentioned this pull request Sep 26, 2025
Merged
spalladino
spalladino approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@spalladino spalladino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to suggest turning the variables into PUBLISHER_DISABLED so the default is false, but we're already using the booleanConfigHelper(true) in other critical places (like real proofs), so let's go!

@spalladino
Copy link
Contributor

spalladino commented Sep 26, 2025

Also, heads up that this will cause sequencers to enter a block-building loop: once they get to the sequencer publisher call, it'll fail, and then try again to build the block repeteadly. It's not terrible, but it'll pollute the p2p layer with multiple repeated proposals for the same slot from the same sequencer.

@PhilWindle
Copy link
Collaborator

PhilWindle commented Sep 26, 2025

Also, heads up that this will cause sequencers to enter a block-building loop: once they get to the sequencer publisher call, it'll fail, and then try again to build the block repeteadly. It's not terrible, but it'll pollute the p2p layer with multiple repeated proposals for the same slot from the same sequencer.

Maybe we should only implement this for the prover for the time being

PhilWindle added a commit that referenced this pull request Sep 29, 2025
@PhilWindle @alexghr @spalladino
chore: Backport of fixes into v2 (#17206)
5f821fd 
This PR is a backport of the following into V2.

#17169
#17176 
#17186 
#17178 
#17177
#17130
#17039 
#17230
#17245 
#17273
#17186
#17192
#17194 
#17225 
#17285 
#17312 
#17326

---------

Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com>
Co-authored-by: Santiago Palladino <santiago@aztec-labs.com>
Co-authored-by: Santiago Palladino <spalladino@gmail.com>
Co-authored-by: alexghr <3816165+alexghr@users.noreply.github.com>
@alexghr alexghr force-pushed the ag/disable-publishing branch from 52a14c2 to bc7ae9a Compare September 30, 2025 14:31
@alexghr alexghr enabled auto-merge September 30, 2025 14:37
@alexghr alexghr added this pull request to the merge queue Sep 30, 2025
Merged via the queue into next with commit 1f5124a Sep 30, 2025
14 checks passed
@alexghr alexghr deleted the ag/disable-publishing branch September 30, 2025 15:36
@alexghr alexghr mentioned this pull request Oct 2, 2025
Merged
alexghr added a commit that referenced this pull request Oct 6, 2025
@alexghr @PhilWindle @spalladino
chore: backport (#17444)
e2b88ec 
Backports of #17312, #17326 and #17407

Fix A-109

---------

Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com>
Co-authored-by: Santiago Palladino <santiago@aztec-labs.com>
ludamad pushed a commit that referenced this pull request Dec 16, 2025
@alexghr @ludamad
feat: optionally disable publishing L1 txs (#17326)
ba77856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spalladino spalladino spalladino approved these changes

@PhilWindle PhilWindle PhilWindle approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexghr @spalladino @PhilWindle