fix: Register validator callbacks on p2p client before starting#17230
Merged
PhilWindle merged 1 commit intonextfrom Sep 23, 2025
Merged
fix: Register validator callbacks on p2p client before starting#17230PhilWindle merged 1 commit intonextfrom
PhilWindle merged 1 commit intonextfrom
Conversation
spalladino
force-pushed
the
palla/register-p2p-handlers-before-starting-it-2
branch
from
ab200b8 to
52c4cc2
Compare
PhilWindle
approved these changes
Sep 23, 2025
PhilWindle
deleted the
palla/register-p2p-handlers-before-starting-it-2
branch
spalladino
pushed a commit
that referenced
this pull request
Sep 25, 2025
Second attempt at #17207 The issue was that the `start` method on p2p client would overwrite all previously registered subprotocol handlers, hence the errors we were seeing on CI: ``` 22:00:04 [22:00:04.697] WARN: p2p:4506:libp2p_service:4506:libp2p_service:4506:reqresp:4506 Unknown stream error while handling the stream, aborting {"protocol":"/aztec/req/auth/1.0.0"} 22:00:04 err: { 22:00:04 "type": "TypeError", 22:00:04 "message": "handler is not a function", 22:00:04 "stack": 22:00:04 TypeError: handler is not a function 22:00:04 at /home/aztec-dev/aztec-packages/yarn-project/p2p/dest/services/reqresp/reqresp.js:452:40 22:00:04 at processTicksAndRejections (node:internal/process/task_queues:105:5) 22:00:04 at duplex.sink (/home/aztec-dev/aztec-packages/yarn-project/node_modules/it-byte-stream/src/index.ts:86:22) 22:00:04 } ``` The test was also failing locally (it had passed before I submitted due to a build issue I missed), and since it was tagged as flake it was greenlighted by CI on the PR.
PhilWindle
added a commit
that referenced
this pull request
Sep 29, 2025
This PR is a backport of the following into V2. #17169 #17176 #17186 #17178 #17177 #17130 #17039 #17230 #17245 #17273 #17186 #17192 #17194 #17225 #17285 #17312 #17326 --------- Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com> Co-authored-by: Santiago Palladino <spalladino@gmail.com> Co-authored-by: alexghr <3816165+alexghr@users.noreply.github.com>
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second attempt at #17207
The issue was that the
startmethod on p2p client would overwrite all previously registered subprotocol handlers, hence the errors we were seeing on CI:The test was also failing locally (it had passed before I submitted due to a build issue I missed), and since it was tagged as flake it was greenlighted by CI on the PR.