Conversation
alexghr
commented
Sep 26, 2025
alexghr
force-pushed
the
ag/remote-config
branch
from
963b6e4 to
20287f5
Compare
alexghr
commented
Sep 26, 2025
alexghr
commented
Sep 26, 2025
Comment on lines
+7
to
+8
| registryAddress: z.string(), | ||
| feeAssetHandlerAddress: z.string().optional(), |
Contributor
Author
There was a problem hiding this comment.
I think we have a circular import issue here. If I make these schemas.EthAddress we can no longer bootstrap cleanly
alexghr
commented
Sep 26, 2025
Comment on lines
+266
to
272
| const data = await cachedFetch(url, { | ||
| cacheDurationMs: BOOTNODE_CACHE_DURATION_MS, | ||
| cacheFile: cacheDir ? join(cacheDir, networkName, 'bootnodes.json') : undefined, | ||
| }); | ||
|
|
||
| return json['bootnodes']; | ||
| return data.bootnodes; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
We no longer crash if the bootnodes file is not available (fix A-61), so I've added a warning if starting a P2P client with 0 boot nodes defined.
alexghr
force-pushed
the
ag/remote-config
branch
2 times, most recently
from
2a07d39 to
54afb8d
Compare
PhilWindle
added a commit
that referenced
this pull request
Sep 29, 2025
This PR is a backport of the following into V2. #17169 #17176 #17186 #17178 #17177 #17130 #17039 #17230 #17245 #17273 #17186 #17192 #17194 #17225 #17285 #17312 #17326 --------- Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com> Co-authored-by: Santiago Palladino <spalladino@gmail.com> Co-authored-by: alexghr <3816165+alexghr@users.noreply.github.com>
alexghr
force-pushed
the
ag/remote-config
branch
2 times, most recently
from
41bf560 to
bd712e6
Compare
alexghr
force-pushed
the
ag/remote-config
branch
2 times, most recently
from
8fc808b to
777c4af
Compare
PhilWindle
approved these changes
Sep 30, 2025
Co-authored-by: PhilWindle <60546371+PhilWindle@users.noreply.github.com>
alexghr
force-pushed
the
ag/remote-config
branch
from
777c4af to
71d9b5b
Compare
PhilWindle
approved these changes
Sep 30, 2025
Merged
alexghr
added a commit
that referenced
this pull request
Oct 6, 2025
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix A-30 A-61