Conversation
PhilWindle
approved these changes
Sep 23, 2025
alexghr
force-pushed
the
ag/remote-signers
branch
from
ebfa2b0 to
e0727cd
Compare
alexghr
commented
Sep 24, 2025
Comment on lines
+38
to
+39
| await createWeb3SignerKeystore(getWeb3SignerTestKeystoreDir(), privateKey.toString()); | ||
| await refreshWeb3Signer(web3SignerUrl); |
Contributor
Author
There was a problem hiding this comment.
I could probably merge this into a single loadKeysIntoWeb3Signer call 🤔
alexghr
force-pushed
the
ag/remote-signers
branch
from
e0727cd to
7beb824
Compare
alexghr
force-pushed
the
ag/remote-signers
branch
from
7beb824 to
0816330
Compare
alexghr
force-pushed
the
ag/remote-signers
branch
from
0816330 to
9a5cfa1
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
PhilWindle
added a commit
that referenced
this pull request
Sep 29, 2025
This PR is a backport of the following into V2. #17169 #17176 #17186 #17178 #17177 #17130 #17039 #17230 #17245 #17273 #17186 #17192 #17194 #17225 #17285 #17312 #17326 --------- Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com> Co-authored-by: Santiago Palladino <spalladino@gmail.com> Co-authored-by: alexghr <3816165+alexghr@users.noreply.github.com>
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a validation step after opening up a keystore to make sure remote signers are available.
Fix A-45