feat!: Handle multiple snapshot urls for sync#17407
Merged
PhilWindle merged 1 commit intonextfrom Oct 1, 2025
Merged
Conversation
spalladino
force-pushed
the
palla/snapshot-urls
branch
from
f0324f8 to
cc8f123
Compare
Nodes will download the index for each snapshot location and pick the one synced to the latest L1 block. If download fails from a given location, they will try the next one. Renames the env var from `SYNC_SNAPSHOTS_URL` to `SYNC_SNAPSHOTS_URLS`, but keeps the old one as fallback. The flag is changed from `--snapshots-url` to `--snapshots-urls`.
spalladino
force-pushed
the
palla/snapshot-urls
branch
from
cc8f123 to
86eb62e
Compare
PhilWindle
reviewed
Oct 1, 2025
| }); | ||
| return true; | ||
| } catch (err) { | ||
| log.error(`Failed to download snapshot from ${url}. Trying next candidate.`, err, { |
Collaborator
There was a problem hiding this comment.
Do we need to implement any cleanup logic here?
Contributor
Author
There was a problem hiding this comment.
That's handled on the snapshotSync function, which calls tryRmDir on the download dir in a finally block.
PhilWindle
approved these changes
Oct 1, 2025
Collaborator
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Contributor
|
This is being backported in #17444 |
Merged
alexghr
added a commit
that referenced
this pull request
Oct 6, 2025
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodes will download the index for each snapshot location and pick the one synced to the latest L1 block. If download fails from a given location, they will try the next one.
Renames the env var from
SYNC_SNAPSHOTS_URLtoSYNC_SNAPSHOTS_URLS, but keeps the old one as fallback. The flag is changed from--snapshots-urlto--snapshots-urls.Fix A-101