fix: Do not reexecute all pruned blocks in the prune watcher#17178
Merged
PhilWindle merged 1 commit intonextfrom Sep 20, 2025
Merged
fix: Do not reexecute all pruned blocks in the prune watcher#17178PhilWindle merged 1 commit intonextfrom
PhilWindle merged 1 commit intonextfrom
Conversation
When deciding whether to slash committee members for an epoch, the epoch prune watcher tries reexecuting all blocks in the pruned epoch. It also uses that to decide whether to slash for data withholding, if not all data is available. However, the blocks being reexecuted (and the txs being gathered) were from ALL pruned epochs, which could be more than one if the proof submission window was long enough. So we ended up slashing committee members from the first epoch for data withholding offenses perpetrated by members in future epochs.
spalladino
force-pushed
the
palla/epoch-prune-watcher-filter-by-epoch-blocks
branch
from
cd8bc8b to
59f2d78
Compare
PhilWindle
approved these changes
Sep 20, 2025
PhilWindle
deleted the
palla/epoch-prune-watcher-filter-by-epoch-blocks
branch
PhilWindle
added a commit
that referenced
this pull request
Sep 29, 2025
This PR is a backport of the following into V2. #17169 #17176 #17186 #17178 #17177 #17130 #17039 #17230 #17245 #17273 #17186 #17192 #17194 #17225 #17285 #17312 #17326 --------- Co-authored-by: Alex Gherghisan <alexghr@users.noreply.github.com> Co-authored-by: Santiago Palladino <santiago@aztec-labs.com> Co-authored-by: Santiago Palladino <spalladino@gmail.com> Co-authored-by: alexghr <3816165+alexghr@users.noreply.github.com>
ludamad
pushed a commit
that referenced
this pull request
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deciding whether to slash committee members for an epoch, the epoch prune watcher tries reexecuting all blocks in the pruned epoch. It also uses that to decide whether to slash for data withholding, if not all data is available.
However, the blocks being reexecuted (and the txs being gathered) were from ALL pruned epochs, which could be more than one if the proof submission window was long enough. So we ended up slashing committee members from the first epoch for data withholding offenses perpetrated by members in future epochs.