Merged
Conversation
* move update to VerifyInfoConcern changelog: Internal, Refactor, Move verify info update to concern
* Remove redundant cancel changelog: User-Facing Improvements, Authentication, Remove redundant cancel button
…flows (#8288) * LG-9072 Update state ID workflows * LG-9072 Add testing for workflow updates * LG-9072 Fix lint issues * LG-9072 Fix lint issues * LG-9072 Fix link issues * LG-9072 Fix lint issues * LG-9072 Update all instance of state_id_... I introduced. Variables were recently renamed * changelog: Upcoming Features, In-person proofing, Applicant verify your information page- update state ID workflow * LG-9072 Updates from var name changes * LG-9072 Removed unnecessary change and testing * LG-9072 Update what I am eval to hit clearing addr * LG-9072 update text * LG-9072 Use helper to set variable, del unused var * LG-9072 Use helper to set var, move comments * LG-9072 update comments * LG-9072 tests for flow and updates * LG-9072 Combine specs with existing describe block * LG-9072 Remove unnecessary setup code * LG-9072 Combine call specs * LG-9072 Use helper methods, lint * LG-9072 Remove but & and from test descriptions * LG-9072 Add more tests, linter
changelog: Internal, ThreatMetrix, Use Profile methods for checking TMx status * Check fraud status in profile instead of proofing components * Updating profile activation to check for TMx being enabled * Use profiles instead of proofing components in gpo specs * Using fraud timestamp columns instead of booleans * Renaming fraud check methods Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
* changelog: Bug Fixes, Authentication, prevent users registering to being a page they shouldn't see * update sp email confirmation * use single line * email confirmation * rubocop fixes * bump auth code in specific areas * fix rubocop * sign up confirmation * make sure to call request url * fix rubocop
* Update references to Acuant 11.8.2 (This is a cleanup commit) [skip changelog] * Rework Acuant SDK loading tests - Remove references to specific version numbers - Test all versions present in the git repo - Just test loading in JSDOM session (don't bother importing) * Remove default values for sdkSrc and cameraSrc In actual use these are derived from the `data-acuant-version` on the `.document-capture-form`. All views that render the doc capture form provide this data. * Don't use an actual version number in _document_capture.html.erb_spec.rb The version number doesn't actually matter for this test, so remove the desire to update it when we upgrade the Acuant SDK * Update spec/javascripts/packages/document-capture/components/acuant-sdk-spec.js Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Don't use `verified_at` for pending fraud review * changelog: Internal, Identity Verification, Remove unnecessary fraud review task test
…r PIV/CAC (#8316) * add failing spec * set auth_method in backup code setup * failing spec * mark user as authenticated after setting up PIV/CAC * Ensure authentication method is stored when setting up backup codes or PIV/CAC changelog: Bug Fixes, Authentication, Ensure authentication method is stored when setting up backup codes or PIV/CAC * differentiate between webauthn and webauthn platform when assigning auth_method in webautn setup controller
* Content changes * fixing french translation * changelog: User-facing changes, In-person proofing, update translations and content in prep for location and prepare step swap * changelog: User-facing improvements, In-person proofing, update translations and content in prep for location and prepare step swap * Update spanish translation
* Remove unnecessary bypass_sign_in calls changelog: Internal, Authentication, Remove unnecessary bypass_sign_in calls * add comment describing usage of bypass_sign_in
…ed to send asynchronously (#8328) changelog: Bug Fixes, Emails, Ensure account deletion emails get sent even when emails are configured to send asynchronously
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> changelog: Internal, Update reporting options, Allows monthly authentication and IDV reports
#8291) * LG-9294 Rate limit for 'Verify your ID' must include a link back to SP Add link to throttled error page enabled rate limited user to link back to SP using defined failure to proof url changelog: User-Facing Improvements, Identity Verification, Rate limited user can link back to SP using defined failure to proof url * fix test for throttled failure to proof link * lint fix * fix rate limiting message for image upload controller * fix paragraph hierarchy * happy linting * happier linting. * fix single quote in spec * create new i18n key for exiting idv due to failure * update test to use idv.failure.exit.with_sp * add status bar and cond'l sp_name failure exit message * happy linting * fix i18n unused keys error * happy linting * fix current step in spec * check exit link without sp * exit message in 1 line * put exit msg in variable * refactor exit text * happy linting * refactor back to original link test to satisfy unused keys test --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain>
* changelog: User-Facing Improvements, 508 Issues, change language for default behavior to new tab instead of window * update tab * change name * update to new tab * fix erb lint * french translation * change to new tab * fix html * update spec * add spanish translation
* Adding Cancel option to review-issues of doc capture * Adding test for not displaying sp option when reviewing errors * Adding spec for displaying sp troubleshooting option * Adding test for showSPOption to doc troubleshooting component changelog: User-Facing Improvements, Document Capture, Adding cancel to document capture error view
changelog: Internal, In-Person Proofing, Bugfix when verifying IPP data Co-authored-by: Tomas Apodaca <Thomas.Apodaca@gsa.gov>
* Redirect old hybrid text link to new controller When a user saves a text link, we want them to be directed to the new code path rather than a 404, even if the new path will tell them their session has expired. changelog: Internal, Code quality, redirect from old hybrid flow text link to new code * Remove FSM capture_doc tests that depend on old text link routes Disabled tests will be removed by the big delete PR along with the rest of the code
changelog: Internal, Dependencies, Upgrade JS YAML package to resolve security advisory
changelog: Bug Fixes, Testing, Fix tests using updated new_window/new_tab content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features