LG-9464 GPO Verify to use profile instead of proofing components#8263
LG-9464 GPO Verify to use profile instead of proofing components#8263
Conversation
There was a problem hiding this comment.
i would remove the name threatmetrix and replace it with fraud_check_failed?
There was a problem hiding this comment.
see previous comment about naming
There was a problem hiding this comment.
Following up on pairing conversation for others reading the PR: We should be able to delete the proofing components from this test setup if we're only looking at profiles. However, in_person_enrollment is still determined from the ProofingComponent, and GpoVerifyForm is looking at ProofingComponents for both in_person_enrollment and threatmetrix status. Changing the code is relatively straightforward. Changing the test setup is much more complex. There's a lot of room for consolidation and refactoring in how we check threatmetrix and in_person_enrollment status throughout the code.
In lieu of checking the actual proofing component result changelog: Internal, ThreatMetrix, Use Profile methods for checking TMx status
Co-authored-by: Eric Gade <eric.gade@gsa.gov>
Stop mocking fraud_review_pending in helper method stub_user_with_pending_profile Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov>
3 participants
In lieu of checking the actual proofing component result
changelog: Internal, ThreatMetrix, Use Profile methods for checking TMx status
🎫 Ticket
LG-9464
🛠 Summary of changes
Instead of checking fraud check values directly in the proofing component result, we look for the set values in the user's current Profile.