LG-9294 Rate limit for 'Verify your ID' must include a link back to SP by amirbey · Pull Request #8291 · 18F/identity-idp

amirbey · 2023-04-26T22:05:30Z

🎫 Ticket

🛠 Summary of changes

Add link to throttled error page enabled rate limited user to link back to SP using defined failure to proof url

removed the failure to proof url from the action/secondary actions
added failure to proof url in the paragraph error
add progress bar

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

During the verification process visit the /verify/session/errors/throttled path

👀 Screenshots

Before:

After:

Add link to throttled error page enabled rate limited user to link back to SP using defined failure to proof url changelog: User-Facing Improvements, Identity Verification, Rate limited user can link back to SP using defined failure to proof url

app/views/idv/session_errors/throttled.html.erb

spec/views/idv/session_errors/throttled.html.erb_spec.rb

app/views/idv/session_errors/throttled.html.erb

spec/views/idv/session_errors/throttled.html.erb_spec.rb

matthinz

LGTM! 🎉

matthinz · 2023-05-02T19:33:04Z

app/controllers/idv/session_errors_controller.rb

@@ -1,5 +1,6 @@
 module Idv
  class SessionErrorsController < ApplicationController
+    include StepIndicatorConcern


👍 Good job bringing that step indicator in.

matthinz · 2023-05-02T19:33:55Z

config/locales/idv/en.yml

          back later.
        text_html: Please try again. If you keep getting these errors, %{link}.
+      exit:
+        with_sp: Exit %{app_name} and return to %{sp_name}


soniaconnolly

LGTM

* LG-8948 Content changes only (#8312) * Content changes * fixing french translation * changelog: User-facing changes, In-person proofing, update translations and content in prep for location and prepare step swap * changelog: User-facing improvements, In-person proofing, update translations and content in prep for location and prepare step swap * Update spanish translation * Remove unnecessary bypass_sign_in calls (#8324) * Remove unnecessary bypass_sign_in calls changelog: Internal, Authentication, Remove unnecessary bypass_sign_in calls * add comment describing usage of bypass_sign_in * Ensure account deletion emails get sent even when emails are configured to send asynchronously (#8328) changelog: Bug Fixes, Emails, Ensure account deletion emails get sent even when emails are configured to send asynchronously * LG-9613 Update reporting CLI to allow monthly queries (#8318) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> changelog: Internal, Update reporting options, Allows monthly authentication and IDV reports * LG-9294 Rate limit for 'Verify your ID' must include a link back to SP (#8291) * LG-9294 Rate limit for 'Verify your ID' must include a link back to SP Add link to throttled error page enabled rate limited user to link back to SP using defined failure to proof url changelog: User-Facing Improvements, Identity Verification, Rate limited user can link back to SP using defined failure to proof url * fix test for throttled failure to proof link * lint fix * fix rate limiting message for image upload controller * fix paragraph hierarchy * happy linting * happier linting. * fix single quote in spec * create new i18n key for exiting idv due to failure * update test to use idv.failure.exit.with_sp * add status bar and cond'l sp_name failure exit message * happy linting * fix i18n unused keys error * happy linting * fix current step in spec * check exit link without sp * exit message in 1 line * put exit msg in variable * refactor exit text * happy linting * refactor back to original link test to satisfy unused keys test --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain> * LG-9386: 508 Complaince, Move from using window to tab. (#8317) * changelog: User-Facing Improvements, 508 Issues, change language for default behavior to new tab instead of window * update tab * change name * update to new tab * fix erb lint * french translation * change to new tab * fix html * update spec * add spanish translation * LG-9297 Add Cancel Link (#8321) * Adding Cancel option to review-issues of doc capture * Adding test for not displaying sp option when reviewing errors * Adding spec for displaying sp troubleshooting option * Adding test for showSPOption to doc troubleshooting component changelog: User-Facing Improvements, Document Capture, Adding cancel to document capture error view * LG-9438 | Fix bug with IPP redirect (#8303) changelog: Internal, In-Person Proofing, Bugfix when verifying IPP data Co-authored-by: Tomas Apodaca <Thomas.Apodaca@gsa.gov> * test all review status in loop to avoid dupe code * LG-9107 Redirect old hybrid text link to new controller (#8325) * Redirect old hybrid text link to new controller When a user saves a text link, we want them to be directed to the new code path rather than a 404, even if the new path will tell them their session has expired. changelog: Internal, Code quality, redirect from old hybrid flow text link to new code * Remove FSM capture_doc tests that depend on old text link routes Disabled tests will be removed by the big delete PR along with the rest of the code * proofing_device_profiling enabled and disabled testing * redefine contexts * happy linting * Upgrade JS YAML package to resolve security advisory (#8331) changelog: Internal, Dependencies, Upgrade JS YAML package to resolve security advisory * Fix javascript tests using updated new_window/new_tab content (#8333) changelog: Bug Fixes, Testing, Fix tests using updated new_window/new_tab content --------- Co-authored-by: Jack Ryan <jackryan@navapbc.com> Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> Co-authored-by: Davida (she/they) <davida.marion@gsa.gov> Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain> Co-authored-by: Malick Diarra <malick.diarra@gsa.gov> Co-authored-by: Eric Gade <105373963+eric-gade@users.noreply.github.com> Co-authored-by: Matt Wagner <mattwagner@navapbc.com> Co-authored-by: Tomas Apodaca <Thomas.Apodaca@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>

amirbey self-assigned this Apr 26, 2023

AmirReavis-Bey added 5 commits April 27, 2023 10:06

fix test for throttled failure to proof link

3400b95

lint fix

4a94e96

fix rate limiting message for image upload controller

e454d03

fix paragraph hierarchy

dbe5315

happy linting

7c60aa0

matthinz reviewed Apr 27, 2023

View reviewed changes

app/views/idv/session_errors/throttled.html.erb Outdated Show resolved Hide resolved

AmirReavis-Bey added 3 commits April 27, 2023 11:54

happier linting.

aacf65a

fix single quote in spec

9d23ba5

create new i18n key for exiting idv due to failure

7468615

amirbey requested a review from matthinz May 1, 2023 13:58

amirbey commented May 1, 2023

View reviewed changes

spec/views/idv/session_errors/throttled.html.erb_spec.rb Outdated Show resolved Hide resolved

amirbey and others added 7 commits May 1, 2023 10:01

update test to use idv.failure.exit.with_sp

c79a6d4

add status bar and cond'l sp_name failure exit message

6c12032

happy linting

d94862e

fix i18n unused keys error

e2450ff

happy linting

b06b37d

fix current step in spec

a67984c

check exit link without sp

6b9b693

amirbey marked this pull request as ready for review May 2, 2023 17:55

amirbey requested a review from a team May 2, 2023 17:55

soniaconnolly reviewed May 2, 2023

View reviewed changes

app/views/idv/session_errors/throttled.html.erb Show resolved Hide resolved

spec/views/idv/session_errors/throttled.html.erb_spec.rb Show resolved Hide resolved

matthinz approved these changes May 2, 2023

View reviewed changes

AmirReavis-Bey added 2 commits May 3, 2023 10:25

exit message in 1 line

9d97bc6

put exit msg in variable

f1dd2d6

soniaconnolly approved these changes May 3, 2023

View reviewed changes

AmirReavis-Bey added 3 commits May 3, 2023 11:15

refactor exit text

18d5137

happy linting

9659793

refactor back to original link test to satisfy unused keys test

22f798f

amirbey merged commit 1b30a0e into main May 3, 2023

amirbey deleted the amirbey/LG-9294-rate-limited branch May 3, 2023 18:21

mdiarra3 mentioned this pull request May 4, 2023

Deploy RC 277 to Prod #8338

Merged

mitchellhenke mentioned this pull request May 4, 2023

Remove step indicator concern from idv sessions error #8339

Merged

mdiarra3 mentioned this pull request May 4, 2023

Deploy RC 277.1 to Prod #8340

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

LG-9294 Rate limit for 'Verify your ID' must include a link back to SP#8291

LG-9294 Rate limit for 'Verify your ID' must include a link back to SP#8291
amirbey merged 21 commits intomainfrom
amirbey/LG-9294-rate-limited

amirbey commented Apr 26, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matthinz left a comment

Uh oh!

matthinz May 2, 2023

Uh oh!

matthinz May 2, 2023

Uh oh!

soniaconnolly left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

amirbey commented Apr 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠 Summary of changes

📜 Testing Plan

👀 Screenshots

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matthinz left a comment

Choose a reason for hiding this comment

Uh oh!

matthinz May 2, 2023

Choose a reason for hiding this comment

Uh oh!

matthinz May 2, 2023

Choose a reason for hiding this comment

Uh oh!

soniaconnolly left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amirbey commented Apr 26, 2023 •

edited

Loading