Skip to content

LG-9410: CTA fixes on Account deletion and reset screen#8305

Merged
jc-gsa merged 5 commits intomainfrom
LG-9410-fix-cta-cancel
May 2, 2023
Merged

LG-9410: CTA fixes on Account deletion and reset screen#8305
jc-gsa merged 5 commits intomainfrom
LG-9410-fix-cta-cancel

Conversation

@jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented Apr 28, 2023

🎫 Ticket

LG-9410

🛠 Summary of changes

Removes a button now considered redundant.

changelog: User-Facing Improvements, Authentication, Remove redundant cancel button
@jc-gsa jc-gsa force-pushed the LG-9410-fix-cta-cancel branch from fdbfaf9 to a33c244 Compare April 28, 2023 15:31
@jc-gsa jc-gsa requested a review from a team April 28, 2023 16:34
@aduth
Copy link
Contributor

aduth commented Apr 28, 2023

Can you provide testing instructions and/or a screenshot for this? Because when visiting the page I'm assuming is related to the ticket, I still see two "Cancel" links.

  1. Sign in
  2. When prompted for MFA, click "Choose another authentication method"
  3. Click "deleting your account"
  4. Click "Yes, continue deletion"

image

@jc-gsa
Copy link
Contributor Author

jc-gsa commented Apr 28, 2023

@aduth I suspect more than one location should be changed. Will confirm the list of locations on Monday.

@jc-gsa
Copy link
Contributor Author

jc-gsa commented Apr 28, 2023

@aduth The location referenced in the design is identity-idp/app/views/account_reset/request/show.html.erb which corresponds to the route /account_reset/request.

There are two hits for the translation key account_reset.request.title, which includes the additional location identity-idp/app/views/account_reset/cancel/show.html.erb which corresponds to the route /account_reset/cancel. This brings up the question, should this location be changed as well? And are there similar UI patterns we want to remove?

@aduth
Copy link
Contributor

aduth commented May 1, 2023

This brings up the question, should this location be changed as well? And are there similar UI patterns we want to remove?

That's a good question. Personally I think it'd make sense to update both of them, but might be worth confirming with UX folks in Slack or standup, since it seems like we were only anticipating one screen being updated with this ticket.

It's worth highlighting that the two "Cancel" links work a bit differently on one of these screens (cancel/show.html.erb), where one link just redirects to the home page, while the other also tracks and cancels the account deletion request. I still think it makes sense to just have the one link that does the tracking and request cancellation.

@aduth
Copy link
Contributor

aduth commented May 1, 2023

This brings up the question, should this location be changed as well? And are there similar UI patterns we want to remove?

That's a good question. Personally I think it'd make sense to update both of them, but might be worth confirming with UX folks in Slack or standup, since it seems like we were only anticipating one screen being updated with this ticket.

It's worth highlighting that the two "Cancel" links work a bit differently on one of these screens (cancel/show.html.erb), where one link just redirects to the home page, while the other also tracks and cancels the account deletion request. I still think it makes sense to just have the one link that does the tracking and request cancellation.

The other screen looks quite a bit different too, where having two different "Cancel" links might make a bit more sense?

Another plan of action could be to just update the one screen described in the ticket, and start the discussion whether we should do the same for the other screen, creating a follow-up ticket depending on where that conversation goes.

image

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jc-gsa jc-gsa merged commit eef9219 into main May 2, 2023
@jc-gsa jc-gsa deleted the LG-9410-fix-cta-cancel branch May 2, 2023 15:03
@mdiarra3 mdiarra3 mentioned this pull request May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants