LG-9107 Redirect old hybrid text link to new controller#8325
Merged
soniaconnolly merged 5 commits intomainfrom May 3, 2023
Merged
LG-9107 Redirect old hybrid text link to new controller#8325soniaconnolly merged 5 commits intomainfrom
soniaconnolly merged 5 commits intomainfrom
Conversation
When a user saves a text link, we want them to be directed to the new code path rather than a 404, even if the new path will tell them their session has expired.
Disabled tests will be removed by the big delete PR along with the rest of the code
matthinz
approved these changes
May 3, 2023
Contributor
matthinz
left a comment
matthinz
left a comment
There was a problem hiding this comment.
LGTM, assuming all the xit tests will be removed eventually?
Contributor
Author
Yes, those go away with the delete PR for LG-9107. |
zachmargolis
reviewed
May 3, 2023
amirbey
added a commit
that referenced
this pull request
May 4, 2023
* LG-8948 Content changes only (#8312) * Content changes * fixing french translation * changelog: User-facing changes, In-person proofing, update translations and content in prep for location and prepare step swap * changelog: User-facing improvements, In-person proofing, update translations and content in prep for location and prepare step swap * Update spanish translation * Remove unnecessary bypass_sign_in calls (#8324) * Remove unnecessary bypass_sign_in calls changelog: Internal, Authentication, Remove unnecessary bypass_sign_in calls * add comment describing usage of bypass_sign_in * Ensure account deletion emails get sent even when emails are configured to send asynchronously (#8328) changelog: Bug Fixes, Emails, Ensure account deletion emails get sent even when emails are configured to send asynchronously * LG-9613 Update reporting CLI to allow monthly queries (#8318) Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> changelog: Internal, Update reporting options, Allows monthly authentication and IDV reports * LG-9294 Rate limit for 'Verify your ID' must include a link back to SP (#8291) * LG-9294 Rate limit for 'Verify your ID' must include a link back to SP Add link to throttled error page enabled rate limited user to link back to SP using defined failure to proof url changelog: User-Facing Improvements, Identity Verification, Rate limited user can link back to SP using defined failure to proof url * fix test for throttled failure to proof link * lint fix * fix rate limiting message for image upload controller * fix paragraph hierarchy * happy linting * happier linting. * fix single quote in spec * create new i18n key for exiting idv due to failure * update test to use idv.failure.exit.with_sp * add status bar and cond'l sp_name failure exit message * happy linting * fix i18n unused keys error * happy linting * fix current step in spec * check exit link without sp * exit message in 1 line * put exit msg in variable * refactor exit text * happy linting * refactor back to original link test to satisfy unused keys test --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain> * LG-9386: 508 Complaince, Move from using window to tab. (#8317) * changelog: User-Facing Improvements, 508 Issues, change language for default behavior to new tab instead of window * update tab * change name * update to new tab * fix erb lint * french translation * change to new tab * fix html * update spec * add spanish translation * LG-9297 Add Cancel Link (#8321) * Adding Cancel option to review-issues of doc capture * Adding test for not displaying sp option when reviewing errors * Adding spec for displaying sp troubleshooting option * Adding test for showSPOption to doc troubleshooting component changelog: User-Facing Improvements, Document Capture, Adding cancel to document capture error view * LG-9438 | Fix bug with IPP redirect (#8303) changelog: Internal, In-Person Proofing, Bugfix when verifying IPP data Co-authored-by: Tomas Apodaca <Thomas.Apodaca@gsa.gov> * test all review status in loop to avoid dupe code * LG-9107 Redirect old hybrid text link to new controller (#8325) * Redirect old hybrid text link to new controller When a user saves a text link, we want them to be directed to the new code path rather than a 404, even if the new path will tell them their session has expired. changelog: Internal, Code quality, redirect from old hybrid flow text link to new code * Remove FSM capture_doc tests that depend on old text link routes Disabled tests will be removed by the big delete PR along with the rest of the code * proofing_device_profiling enabled and disabled testing * redefine contexts * happy linting * Upgrade JS YAML package to resolve security advisory (#8331) changelog: Internal, Dependencies, Upgrade JS YAML package to resolve security advisory * Fix javascript tests using updated new_window/new_tab content (#8333) changelog: Bug Fixes, Testing, Fix tests using updated new_window/new_tab content --------- Co-authored-by: Jack Ryan <jackryan@navapbc.com> Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> Co-authored-by: Davida (she/they) <davida.marion@gsa.gov> Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain> Co-authored-by: Malick Diarra <malick.diarra@gsa.gov> Co-authored-by: Eric Gade <105373963+eric-gade@users.noreply.github.com> Co-authored-by: Matt Wagner <mattwagner@navapbc.com> Co-authored-by: Tomas Apodaca <Thomas.Apodaca@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9107
🛠 Summary of changes
When a user saves and then uses an old text link for hybrid document capture, we want them to be directed to the new code path rather than a 404, even if the new path will tell them their session has expired.
📜 Testing Plan
/verify/hybrid_mobile/document_captureon mobile