Require less cleanup after updating Acuant#8306
Merged
Conversation
aduth
reviewed
Apr 28, 2023
spec/javascripts/packages/document-capture/components/acuant-sdk-spec.js
Outdated
Show resolved
Hide resolved
(This is a cleanup commit) [skip changelog]
- Remove references to specific version numbers - Test all versions present in the git repo - Just test loading in JSDOM session (don't bother importing)
In actual use these are derived from the `data-acuant-version` on the `.document-capture-form`. All views that render the doc capture form provide this data.
The version number doesn't actually matter for this test, so remove the desire to update it when we upgrade the Acuant SDK
…dk-spec.js Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
matthinz
force-pushed
the
matthinz/acuant-11.8.2-cleanup
branch
from
8cc6d95 to
1c6af6d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9566
🛠 Summary of changes
We have a few places in the codebase where we refer to specific versions of the Acuant SDK. This means we have to make additional code updates after upgrading the SDK. This PR attempts to reduce the amount of cleanup work necessary by: