LG-8908: Add USPS document check to ProofingComponent when enrollment is created

app/controllers/idv/in_person/usps_locations_controller.rb

@@ -38,21 +38,28 @@ def index
         render json: response.to_json
       end
 
-      def proofer
-        @proofer ||= EnrollmentHelper.usps_proofer
-      end
-
       # save the Post Office location the user selected to an enrollment
       def update
         enrollment.update!(
           selected_location_details: update_params.as_json,
           issuer: current_sp&.issuer,
         )
+        add_proofing_component
 
         render json: { success: true }, status: :ok
       end
 
-      protected
+      private
+
+      def proofer
+        @proofer ||= EnrollmentHelper.usps_proofer
+      end
+
+      def add_proofing_component
+        ProofingComponent.
+          create_or_find_by(user: effective_user).
+          update(document_check: Idp::Constants::Vendors::USPS)
+      end
 
       def handle_error(err)
         remapped_error = case err

app/controllers/idv/in_person/verify_info_controller.rb

@@ -44,7 +44,6 @@ def update
 
         pii[:uuid_prefix] = ServiceProvider.find_by(issuer: sp_session[:issuer])&.app_id
         pii[:state_id_type] = 'drivers_license' unless pii.blank?
-        add_proofing_component
 
         ssn_throttle.increment!
         if ssn_throttle.throttled?
@@ -95,12 +94,6 @@ def renders_404_if_flag_not_set
         render_not_found unless IdentityConfig.store.in_person_verify_info_controller_enabled
       end
 
-      def add_proofing_component
-        ProofingComponent.
-          create_or_find_by(user: current_user).
-          update(document_check: Idp::Constants::Vendors::USPS)
-      end
-
       # copied from address_controller
       def confirm_ssn_step_complete
         return if pii.present? && pii[:ssn].present?

app/services/idv/steps/in_person/verify_step.rb

@@ -14,7 +14,6 @@ def self.analytics_submitted_event
 
         def call
           pii[:state_id_type] = 'drivers_license' unless invalid_state?
-          add_proofing_component
           enqueue_job
         end
 
@@ -28,12 +27,6 @@ def extra_view_variables
 
         private
 
-        def add_proofing_component
-          ProofingComponent.
-            create_or_find_by(user: current_user).
-            update(document_check: Idp::Constants::Vendors::USPS)
-        end
-
         def capture_secondary_id_enabled?
           current_user.establishing_in_person_enrollment.capture_secondary_id_enabled
         end

spec/controllers/idv/in_person/usps_locations_controller_spec.rb

@@ -257,6 +257,14 @@
       expect(enrollment.service_provider).to be_nil
     end
 
+    it 'updates proofing component vendor' do
+      expect(user.proofing_component&.document_check).to be_nil
+
+      response
+
+      expect(user.proofing_component.document_check).to eq Idp::Constants::Vendors::USPS
+    end
+
     context 'when unauthenticated' do
       let(:user) { nil }
 

spec/controllers/idv/in_person/verify_info_controller_spec.rb

@@ -158,12 +158,6 @@
           expect(response).to redirect_to(idv_session_errors_ssn_failure_url)
         end
       end
-
-      it 'updates proofing component vendor' do
-        put :update
-
-        expect(user.proofing_component.document_check).to eq Idp::Constants::Vendors::USPS
-      end
     end
   end
 end

spec/features/idv/steps/in_person/verify_info_spec.rb

@@ -24,6 +24,7 @@
     complete_ssn_step(user)
 
     # verify page
+    expect_in_person_step_indicator_current_step(t('step_indicator.flows.idv.verify_info'))
     expect(page).to have_current_path(idv_in_person_verify_info_path)
     expect(page).to have_content(t('headings.verify'))
     expect(page).to have_text(InPersonHelper::GOOD_FIRST_NAME)

spec/services/idv/steps/in_person/verify_step_spec.rb

@@ -141,11 +141,5 @@ def redirect(step_instance)
         expect(redirect(user2_step)).to eq(idv_session_errors_ssn_failure_url)
       end
     end
-
-    it 'updates proofing component vendor' do
-      step.call
-
-      expect(user.proofing_component.document_check).to eq Idp::Constants::Vendors::USPS
-    end
   end
 end