Merged
Conversation
* Add doc_auth_ssn_controller_enabled flag * Initial SsnController, template, specs has show route renders 404 if feature flag not set * Pull common code into StepUtilitiesConcern * Add IdvSession and stub user in specs * Add pii_from_doc before action * Add analytics to ssn_controller * Add update and specs * Divert from document capture step to ssn controller Correct :put url in ssn show template * Local params for :show * Correct step_count key * Get ssn from correct form param, fix spec, update works * Get SsnController#update tests working * Add feature specs * Add submitted analytics and redo action Add test in verify_info_step_spec for ssn redo action and analytics * Use get, not put, to edit SSN from verify_info * Update idv_session when ssn is updated * If no ssn in pii, VerifyInfo checks ssn feature flag and redirects to SsnController if it is set. * remove the old verify info controller feature flag --------- Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Eric Gade <eric.gade@gsa.gov> Co-authored-by: Doug Price <douglas.price@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> changelog: Internal, refactor, remove ssn step from fsm (feature flagged)
) Prior to the introduction of the flow state machine, the "applicant" value in the IdV session was created when the proofing process was started. After the introduction of the FSM the applicant was created once the FSM flow was complete. The IdvStepConcern is intended to route users to the correct step based on the state of proofing. Currently it is empty because the Flow State Machine primarily handles this logic. There is a desire to re-introduce the logic to route users to the correct step to this concern. The IdvStepConcern has a before action to verify that proofing has started. It does that by checking for the applicant which, as described above, does not make sense in the post-FSM world. This commit removes that before action and adds it explicitly to controllers that require an applicant to function. changelog: Improvements, Rails controller management, A before action that was used to identify if a user has started proofing was removed from a concern and explicitly called in individual controllers that depended on that before action. The logic in that before action was superceded by the flow state machine.
changelog: Improvements, OpenID Connect Add ial and aal to userinfo response Include IAL/AAL string value in the OIDC authorization userinfo response.
changelog: Bug Fixes, Phone Input, Preserve selected phone country when displaying form errors
Add alt text to the "Your letter is on the way" graphic. changelog: User-Facing Improvements, accessibility, Add alt text to GPO header graphic
changelog: User-Facing Improvements, Accessibility, Improve color contrast of phone input country code
* Added alert component to state id step page and included relevant translations. * Using with_content to match other render function styles. * Added small styling chage for list items in alerts * changelog: User-facing improvements, In-person proofing, add alert specifying accepted forms of identification * Reverting change in stylesheet. Adding class to translation files. * Ramblings * Removed HTML from translation file instead passing in block to alert component * Remove binding.pry * Normalize yml * Adding colon and fixing order of text --------- Co-authored-by: Matt Gardner <wilburnforce@gmail.com>
* Bump Lookbook and ViewComponent to latest versions * Fix truncated preview white background when scrollbar present changelog: Internal, Component Previews, Upgrade and improve component preview environment * Hide "Base" component superclass from preview navigation * Update Step Indicator preview to show selected step * Fix error for Validated Field workbench "Email" input type * Show Validated Field text input as single-line text, not textarea
…g new SsnController (#7848) * Use link rather than button to update ssn with new SsnController Note that when the ssn_controller goes live, a couple of other tests will have to change from click_button to click_link. * Rename IdvSession#ssn_updated! to invalidate_steps_after_ssn! per feedback from Zach Co-authored-by: Matt Hinz <matt.hinz@gsa.gov> [skip changelog]
Add TimeComponent for use with improved personal_key_generated_at to views changelog: User-Facing Improvements, Authentication, Deployment, Improve display of personal_key_generated_at
changelog: Internal, Remember Device, Refactor tests to improve test runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal