LG-8734 direct link to update ssn from VerifyInfoController when using new SsnController#7848
Merged
soniaconnolly merged 5 commits intomainfrom Feb 17, 2023
Merged
Conversation
Note that when the ssn_controller goes live, a couple of other tests will have to change from click_button to click_link. Co-authored-by: Matt Hinz <matt.hinz@gsa.gov>
from Zach's feedback in previous SsnController PR
per feedback from Zach [skip changelog]
zachmargolis
approved these changes
Feb 17, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! thanks for following up with those suggestions!
| ) | ||
|
|
||
| idv_session.ssn_updated! | ||
| idv_session.invalidate_steps_after_ssn! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8734
🛠 Summary of changes
Behind the feature flag for the new SsnController, use a direct link to update the SSN on the Verify Info page, rather than a button that looks like a link. This gets rid of a trailing
?on the url in the browser address bar.Also added small whitespace changes and renamed
IdvSession#ssn_updated!toinvalidate_steps_after_ssn!per feedback from @zachmargolis on #7810 that I saw after merging it.Note: Once we get rid of the feature flag, a couple more tests will need to change click_button to click_link for ssn update on the VerifyInfo view.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
doc_auth_ssn_controller_enabledfeature flag is set to trueverify/ssnwithout a?at the end.👀 Screenshots
After:
