Move remembered device feature specs to controller specs#7851
Merged
mitchellhenke merged 1 commit intomainfrom Feb 17, 2023
Merged
Move remembered device feature specs to controller specs#7851mitchellhenke merged 1 commit intomainfrom
mitchellhenke merged 1 commit intomainfrom
Conversation
changelog: Internal, Remember Device, Refactor tests to improve test runtime
mitchellhenke
force-pushed
the
mitchellhenke/refactor-remember-device-tests
branch
from
57443f1 to
4005028
Compare
mitchellhenke
deleted the
mitchellhenke/refactor-remember-device-tests
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
In working on some re-authentication and remembered device things, these tests conflicted with the potential changes and seemed to be a candidate for converting to controller tests to improve test time. The behavior being tested relies on remembered device revocation, which is tested in other areas including the remember device shared example and the remember_device_cookie_spec. It seemed sufficient to test that remembered devices were revoked and rely on other tests to ensure that it operates as expected across different contexts.