New SSN Controller behind a feature flag#7810
Merged
soniaconnolly merged 25 commits intomainfrom Feb 15, 2023
Merged
Conversation
has show route renders 404 if feature flag not set
Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
Co-authored-by: Eric Gade <eric.gade@gsa.gov>
To allow better naming for future standalone controllers extracted from the FSM Co-authored-by: Eric Gade <eric.gade@gsa.gov>
Add feature test (which doesn't pass yet) Correct :put url in ssn show template
Co-authored-by Doug Price <douglas.price@gsa.gov> Co-authored-by Eric Gade <eric.gade@gsa.gov>
Change step count key not to be ssn to avoid triggering SensitiveKey exception on session Co-authored-by: Doug Price <douglas.price@gsa.gov> Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov>
Add test in verify_info_step_spec for ssn redo action and analytics
changelog: Internal, refactor, remove ssn step from fsm (feature flagged)
Also rename VerifyInfoConcern to StepUtilitiesConcern
and redirects to SsnController if it is set.
jmhooper
approved these changes
Feb 13, 2023
Comment on lines
+27
to
+28
| acuant_sdk_upgrade_ab_test_bucket: | ||
| AbTests::ACUANT_SDK.bucket(capture_session_uuid), |
Contributor
There was a problem hiding this comment.
style nit, I'd indent this for clarity
Suggested change
| acuant_sdk_upgrade_ab_test_bucket: | |
| AbTests::ACUANT_SDK.bucket(capture_session_uuid), | |
| acuant_sdk_upgrade_ab_test_bucket: | |
| AbTests::ACUANT_SDK.bucket(capture_session_uuid), |
Comment on lines
+139
to
+145
| def ssn_updated! | ||
| # Guard against unvalidated attributes from in-person flow in review controller | ||
| session[:applicant] = nil | ||
|
|
||
| invalidate_verify_info_step! | ||
| invalidate_phone_step! | ||
| end |
Contributor
There was a problem hiding this comment.
to me, the name was confusing here compared to what the method does, WDYT about invalidate_steps_before_ssn!?
Contributor
Author
There was a problem hiding this comment.
I can change it to invalidate_steps_after_ssn!
Comment on lines
104
to
+105
| </div> | ||
| <% if IdentityConfig.store.doc_auth_ssn_controller_enabled %> |
Contributor
There was a problem hiding this comment.
I would indent this whole block and line it up with the </div> above? If the worry was about diff noise, we can always suggest reviews hide whitespace
Suggested change
| </div> | |
| <% if IdentityConfig.store.doc_auth_ssn_controller_enabled %> | |
| </div> | |
| <% if IdentityConfig.store.doc_auth_ssn_controller_enabled %> |
Merged
4 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-8733
🛠 Summary of changes
📜 Testing Plan