Retain country code in phone initialization#7823
Merged
Conversation
changelog: Bug Fixes, Phone Input, Preserve selected phone country when displaying form errors
mitchellhenke
approved these changes
Feb 15, 2023
mdiarra3
approved these changes
Feb 15, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Related to ongoing reCAPTCHA efforts, e.g. LG-8771
🛠 Summary of changes
This pull request aims to resolve an issue where the selected country associated with an entered phone number would not be preserved if the submission yielded errors, such as when trying to add a phone number already associated with an account.
This would prove problematic for reCAPTCHA efforts, where the phone number submission relies on the selected country to determine whether an exemption would apply.
📜 Testing Plan
Before: Country flag in phone input would show as grey box.
After: Selected country is maintained.
👀 Screenshots