Skip to content

Retain country code in phone initialization#7823

Merged
aduth merged 1 commit intomainfrom
aduth-phone-input-init-error
Feb 16, 2023
Merged

Retain country code in phone initialization#7823
aduth merged 1 commit intomainfrom
aduth-phone-input-init-error

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented Feb 13, 2023

🎫 Ticket

Related to ongoing reCAPTCHA efforts, e.g. LG-8771

🛠 Summary of changes

This pull request aims to resolve an issue where the selected country associated with an entered phone number would not be preserved if the submission yielded errors, such as when trying to add a phone number already associated with an account.

This would prove problematic for reCAPTCHA efforts, where the phone number submission relies on the selected country to determine whether an exemption would apply.

📜 Testing Plan

  1. Sign in
  2. Click "Add a phone number"
  3. Enter a phone number already associated with the account
  4. Click "Continue"

Before: Country flag in phone input would show as grey box.
After: Selected country is maintained.

👀 Screenshots

Before After
image image

changelog: Bug Fixes, Phone Input, Preserve selected phone country when displaying form errors
@aduth aduth requested a review from a team February 13, 2023 21:44
@aduth aduth merged commit e28310c into main Feb 16, 2023
@aduth aduth deleted the aduth-phone-input-init-error branch February 16, 2023 15:09
@solipet solipet mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants