Merged
Conversation
changelog: Bug Fixes, Sign In, Remove prefillign email/password via URL params
Add INCOMPLETE StepStatus to StepIndicatorStep custom component and set statusText to step_indicator.status.not_complete Co-authored-by: Eric Gade <eric.gade@gsa.gov> changelog: User-Facing Improvements, Accessibility, Step indicator screen reader tags
Removed old three-screen path which we kept around for a while to support in-flight sessions. [skip changelog]
* Update to Ruby 3.2.0 changelog: Internal, Ruby, Upgrade to Ruby 3.2.0
changelog: Internal, Code Quality, Remove unreachable code paths
* LG-8071: Add logging for WebAuthn frontend error reasons changelog: Internal, Analytics, Track error reasons for failed WebAuthn authentication * Enhance specs for WebauthnVerificationForm * Enhance specs for WebauthnVerificationController
* Remove <lg-download-button> component, it was only needed for IE - Now that we have dropped support for Internet Explorer, we can rely on browsers having correct support for <a href="data://> links [skip changelog]
[skip changelog]
[skip changelog] Co-authored-by: Matt Gardner <wilburnforce@gmail.com>
* Update saml_idp gem changelog: Internal, Dependencies, Update saml_idp gem * fix UUID validation
…ion object (#7616) * changelog: Bug Fixes, SAML Auth, Update ForceAuthn enforcement * Track SAML final auth request state in the SP session hash * Add feature specs for forceauthn and saml sign in flow, update unit tests
changelog: Internal, Dependencies, Update webauthn gem
After we upgraded to Ruby 3.2 we lost support for mailcatcher. Mailcatcher depends on Fixnum was was previously deprecated and is now removed in Rby 3.2 This commit removes mailcatcher and adds 2 new options for previewing emails: 1. Letter opener 2. File previews This commit has letter opener as the default method with the ability to switch to the file method by changing configs in your local `application.yml`. [skip changelog]
* Add proofing_device_profiling config - Move logic around "should this be enabled?" into FeatureManagement - Add logic to automatically enable the ThreatMetrix mock in lower environments changelog: Internal, ThreatMetrix, Simplify ThreatMetrix config flags. * Update references to old flags in app/ & config/ dirs * Update specs * Look at profile in PersonalKeyController Profile should've been deactivated by this point, so don't look at ProofingComponent. * Refactor Idv::Session::threatmetrix_failed_and_needs_review * Use [] instead of send() when probing for keys * Roll back threatmetrix_mock_enabled? changes Checking domain is kind of smelly. We can approximate this by setting good defaults. * Remove check for org_id in SSN partial The ThreatMetrix mock does not use org ID. It feels needlessly complex to check for it (it should _always_ be configured when TM is enabled for real)
* freezing strings * freeze action_view template strings changelog: Internal, Performance, Reduce memory allocation by freezing more strings * constantize Browser default and limit * constantize encryptor key regex * update newrelic * update nokogiri * update gems * add used translation to ignore unused error list
Change feature flag name [skip changelog]
* Add `ignored_columns` to be removed * [skip changelog] * Use single quotes * Remove tracking ial2 in analytics
…ExecutedStepName` (#7630) The LexisNexis InstantVerify response includes a list of products that ran. We parse error messages out of these products and use info from the product as a key for those errors in a hash. Currently we use the `ExecutedStepName` as the key for a product. This key can change between products. This commit makes a change to use the `ProductType` key which should be more consistent as the workflow changes. [skip changelog] Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mdiarra3
approved these changes
Jan 17, 2023
mitchellhenke
approved these changes
Jan 17, 2023
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢 🚢
zachmargolis
force-pushed
the
stages/rc-2023-01-18
branch
from
b14cec6 to
2e50964
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal