Conversation
After we upgraded to Ruby 3.2 we lost support for mailcatcher. Mailcatcher depends on Fixnum was was previously deprecated and is now removed in Rby 3.2 This commit removes mailcatcher and adds 2 new options for previewing emails: 1. Letter opener 2. File previews This commit has letter opener as the default method with the ability to switch to the file method by changing configs in your local `application.yml`. [skip changelog]
aduth
approved these changes
Jan 13, 2023
aduth
reviewed
Jan 13, 2023
Contributor
Author
|
I want to make sure to include a s/o to @svalexander for figuring out how to get |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After we upgraded to Ruby 3.2 we lost support for mailcatcher. Mailcatcher depends on Fixnum was was previously deprecated and is now removed in Ruby 3.2
This commit removes mailcatcher and adds 2 new options for previewing emails:
This commit has letter opener as the default method with the ability to switch to the file method by changing configs in your local
application.yml.