Remove <lg-download-button> component, it was only needed for IE#7624
Merged
zachmargolis merged 2 commits intomainfrom Jan 12, 2023
Merged
Remove <lg-download-button> component, it was only needed for IE#7624zachmargolis merged 2 commits intomainfrom
zachmargolis merged 2 commits intomainfrom
Conversation
- Now that we have dropped support for Internet Explorer, we can rely on browsers having correct support for <a href="data://> links
zachmargolis
commented
Jan 11, 2023
Comment on lines
-35
to
-43
| triggerInternetExplorerDownload = (event: MouseEvent) => { | ||
| event.preventDefault(); | ||
|
|
||
| const filename = this.link.getAttribute('download')!; | ||
| const uri = this.link.getAttribute('href')!; | ||
| const blob = new Blob([dataURIToBlob(uri)], { type: 'text/plain' }); | ||
|
|
||
| window.navigator.msSaveBlob?.(blob, filename); | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
this is the bulk of the logic the component did
[skip changelog]
aduth
approved these changes
Jan 12, 2023
| import '@18f/identity-download-button/download-button-element'; | ||
| ``` | ||
|
|
||
| The custom element will implement the copying behavior, but all markup must already exist. |
Contributor
There was a problem hiding this comment.
[...] will implement the copying behavior [...]
Good thing this will hide my continued copy-pasting mistakes 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<a href="data://">links