Skip to content

LG-8402: Add a cancel link to the in-person proofing barcode page#7618

Merged
sheldon-b merged 5 commits intomainfrom
sbachstein/lg-8402-add-cancel-button-to-barcode-page
Jan 12, 2023
Merged

LG-8402: Add a cancel link to the in-person proofing barcode page#7618
sheldon-b merged 5 commits intomainfrom
sbachstein/lg-8402-add-cancel-button-to-barcode-page

Conversation

@sheldon-b
Copy link
Contributor

@sheldon-b sheldon-b commented Jan 11, 2023

🎫 Ticket

LG-8402

🛠 Summary of changes

  • Adds a cancel link to the in-person proofing barcode page. This link redirects the user to the existing start over page.
  • Note: the designs call for a 32px gap between the horizontal but that doesn't match other cancel links in the application. I've kept the consistency with the other pages.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before:

localhost_3000_verify_in_person_ready_to_verify (7)

After:

localhost_3000_verify_in_person_ready_to_verify (6)

@sheldon-b sheldon-b marked this pull request as ready for review January 12, 2023 14:36
@sheldon-b sheldon-b requested review from a team and tomas-nava January 12, 2023 14:36
@svalexander
Copy link
Contributor

LGTM

Copy link
Contributor

@allthesignals allthesignals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added an idea for re-using a partial somewehre else but looks good to me.....

Comment on lines +115 to +117
<%= render PageFooterComponent.new do %>
<%= link_to t('in_person_proofing.body.barcode.cancel_link_text'), idv_cancel_path(step: 'verify') %>
<% end %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed that there's a shared partial for this (app/views/idv/doc_auth/_cancel.html.erb) and wonder if it could be re-used instead, or re-using this (app/views/shared/_cancel.html.erb) instead...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the reason I didn't use those is that they use a different text string for the link text ("Cancel" instead of "Cancel your barcode"). I considered adding a link text parameter to one of those but it didn't seem worth it since we're only doing this in one place and it doesn't seem likely that we'll want to do it elsewhere with different text again

@sheldon-b sheldon-b requested a review from a team January 12, 2023 17:50
@sheldon-b sheldon-b merged commit 3fe32e3 into main Jan 12, 2023
@sheldon-b sheldon-b deleted the sbachstein/lg-8402-add-cancel-button-to-barcode-page branch January 12, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants