Conversation
… link on the in-person proofing barcode page
|
LGTM |
allthesignals
left a comment
There was a problem hiding this comment.
Just added an idea for re-using a partial somewehre else but looks good to me.....
| <%= render PageFooterComponent.new do %> | ||
| <%= link_to t('in_person_proofing.body.barcode.cancel_link_text'), idv_cancel_path(step: 'verify') %> | ||
| <% end %> |
There was a problem hiding this comment.
Noticed that there's a shared partial for this (app/views/idv/doc_auth/_cancel.html.erb) and wonder if it could be re-used instead, or re-using this (app/views/shared/_cancel.html.erb) instead...
There was a problem hiding this comment.
Yeah, the reason I didn't use those is that they use a different text string for the link text ("Cancel" instead of "Cancel your barcode"). I considered adding a link text parameter to one of those but it didn't seem worth it since we're only doing this in one place and it doesn't seem likely that we'll want to do it elsewhere with different text again
🎫 Ticket
LG-8402
🛠 Summary of changes
👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: