Freeze strings and other constants#7638
Merged
mitchellhenke merged 8 commits intomainfrom Jan 13, 2023
Merged
Conversation
zachmargolis
approved these changes
Jan 12, 2023
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
LGTM! I'd be in favor of adding that comment to all files via Rubocop
added 7 commits
January 13, 2023 10:14
changelog: Internal, Performance, Reduce memory allocation by freezing more strings
mitchellhenke
force-pushed
the
mitchellhenke/freezing-strings
branch
from
6738d93 to
5ae6c59
Compare
mitchellhenke
force-pushed
the
mitchellhenke/freezing-strings
branch
from
c63785a to
7509865
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This PR intends to freeze strings and other values in some of the warmer paths and also enables
config.action_view.frozen_string_literalwhich will freeze string literals in templates. We could do# frozen_string_literal: trueeverywhere with Rubocop, but I am hoping to start smaller since we may eventually be able to useRUBYOPT=--enable=frozen-string-literalSome preliminary testing suggests this patch could reduce memory allocation by 2-3% on a
GET /request