Skip to content

LG-8529: Change feature flag name#7617

Merged
jc-gsa merged 2 commits intomainfrom
lg-8529-phone-service-name
Jan 13, 2023
Merged

LG-8529: Change feature flag name#7617
jc-gsa merged 2 commits intomainfrom
lg-8529-phone-service-name

Conversation

@jc-gsa
Copy link
Contributor

@jc-gsa jc-gsa commented Jan 11, 2023

Change feature flag name per request.

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect we're using the default value in most live environments, but it might be a good idea to do a pass for how it's configured, and update for the rename or remove redundant configurations.

[skip changelog]
@jc-gsa jc-gsa force-pushed the lg-8529-phone-service-name branch from 505a9c2 to f1c5b67 Compare January 11, 2023 20:59
@jc-gsa jc-gsa merged commit cd865f3 into main Jan 13, 2023
@jc-gsa jc-gsa deleted the lg-8529-phone-service-name branch January 13, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants